openbsd
5 months agoforgot to add a history section for the TLS PRF API
tb [Wed, 10 Jul 2024 10:22:03 +0000 (10:22 +0000)]
forgot to add a history section for the TLS PRF API

5 months agouse better endian swaps for populating the irq map request
jmatthew [Wed, 10 Jul 2024 09:50:28 +0000 (09:50 +0000)]
use better endian swaps for populating the irq map request

from NetBSD's if_iavf.c r1.1

5 months agoSplit vmd into mi/md parts.
dv [Wed, 10 Jul 2024 09:27:32 +0000 (09:27 +0000)]
Split vmd into mi/md parts.

Makes as much of the core of vmd mi, pushing x86-isms into separate
compilation units. Adds build logic for arm64, but no emulation
yet. (You can build vmd, but it won't have a vmm device to connect
to.)

Some more cleanup probably needed around interrupt controller
abstraction, but that can come as we implement more than the i8259.

ok mlarkin@

5 months agoSweep up more softdep crumbs.
krw [Wed, 10 Jul 2024 09:24:03 +0000 (09:24 +0000)]
Sweep up more softdep crumbs.

Nuke #if notyet/#endif chunks containing references to never defined
STATFS_SOFTUPD;

ok otto@

5 months agoSweep up more softdep crumbs.
krw [Wed, 10 Jul 2024 09:20:33 +0000 (09:20 +0000)]
Sweep up more softdep crumbs.

FFS_SOFTUPDATES is no longer used. Remove stray defined(FFS_SOFTUPDATES) checks
and an #if/#endif block referencing no longer defined softdep_fsync().

ok otto@

5 months agoiaq_datalen is 16 bits, so always use htole16 to populate it
jmatthew [Wed, 10 Jul 2024 09:14:50 +0000 (09:14 +0000)]
iaq_datalen is 16 bits, so always use htole16 to populate it

from NetBSD's if_iavf.c r1.2

5 months agoSweep up another softdep crumb.
krw [Wed, 10 Jul 2024 09:12:11 +0000 (09:12 +0000)]
Sweep up another softdep crumb.

Remove #if notyet/#endif chunk that references the never-defined STATFS_SOFTUPD.

ok jsg@

5 months agosync
tb [Wed, 10 Jul 2024 08:52:12 +0000 (08:52 +0000)]
sync

5 months agolink EVP_PKEY_CTX_set_tls1_prf_md.3 to build
tb [Wed, 10 Jul 2024 08:51:28 +0000 (08:51 +0000)]
link EVP_PKEY_CTX_set_tls1_prf_md.3 to build

5 months agoImport EVP_PKEY_CTX_set_tls1_prf_md.3 from OpenSSL 1.1.1
tb [Wed, 10 Jul 2024 08:49:48 +0000 (08:49 +0000)]
Import EVP_PKEY_CTX_set_tls1_prf_md.3 from OpenSSL 1.1.1

With only slight application of color to this entelodont's lips. It's the
usual deal - hard to say what's worse, the code or its docs...

5 months agoas per if_ixl.c r1.88, protect the admin queue with a muteX
jmatthew [Wed, 10 Jul 2024 08:48:20 +0000 (08:48 +0000)]
as per if_ixl.c r1.88, protect the admin queue with a muteX
cVS: ----------------------------------------------------------------------

5 months agoIncluding kdf.h isn't enough, you also need evp.h
tb [Wed, 10 Jul 2024 07:57:37 +0000 (07:57 +0000)]
Including kdf.h isn't enough, you also need evp.h

It will be a cold day in hell before I see an OpenSSL manpage without
mistakes in it.

5 months agocorrect some Broadcom adapter model numbers that I mistyped
jmatthew [Wed, 10 Jul 2024 07:56:21 +0000 (07:56 +0000)]
correct some Broadcom adapter model numbers that I mistyped

from Bryan Vyhmeister

5 months agoUnwrap two lines
tb [Wed, 10 Jul 2024 06:53:27 +0000 (06:53 +0000)]
Unwrap two lines

5 months agoremove stray ".Xc";
jmc [Wed, 10 Jul 2024 05:41:34 +0000 (05:41 +0000)]
remove stray ".Xc";

5 months agogrammar tweak;
jmc [Wed, 10 Jul 2024 05:40:08 +0000 (05:40 +0000)]
grammar tweak;

5 months agogrammar/macro/spelling fixes;
jmc [Wed, 10 Jul 2024 05:39:25 +0000 (05:39 +0000)]
grammar/macro/spelling fixes;

5 months agoan universal -> a universal
jmc [Wed, 10 Jul 2024 05:19:02 +0000 (05:19 +0000)]
an universal -> a universal

5 months agoPrepare pmap for using the AMD SEV C-bit to encrypt guest memory.
bluhm [Tue, 9 Jul 2024 19:11:06 +0000 (19:11 +0000)]
Prepare pmap for using the AMD SEV C-bit to encrypt guest memory.

The C-bit in a page table entry is used by a SEV guest to specify,
which pages are to be encrypted and which not.  The latter is needed
to share pages with the hypervisor for virtio(4).
The actual position of the C-bit within a PTE is CPU implementation
dependend and needs to be determined dynamically at system boot.
The position of the C-bit also determines the actual size of page
frame mask.  This will be provided by a separate change.
To be able to use the same kernel as both host and guest, the C-bit
is provided as variable similar to the NX-bit.  Same holds for the
page frame masks.
Right now, pg_crypt is set to 0, pg_frame an pg_lgframe to PG_FRAME
and PG_LGFRAME respectively.  Thus the kernel works as a host system
same as before.
Also introduce a PMAP_NOCRYPT flag.  A guest will use this with
busdma to establish unencrypted mappings that can be shared with
the hypervisor.

from hshoexer@; OK mlarkin@

5 months agombuf.9: Add missing fields, fix order and spacing.
jan [Tue, 9 Jul 2024 18:56:54 +0000 (18:56 +0000)]
mbuf.9: Add missing fields, fix order and spacing.

fine by jmc@
sure mvs@

5 months agovmd(8): Avoid double DHCP reply when using the internal dhcp server.
jan [Tue, 9 Jul 2024 18:49:05 +0000 (18:49 +0000)]
vmd(8): Avoid double DHCP reply when using the internal dhcp server.

DHCP request should no leave vmd if its answered internally.

ok dv@

5 months agoAdd another empty line
tb [Tue, 9 Jul 2024 17:58:36 +0000 (17:58 +0000)]
Add another empty line

5 months agoTurn tls1_prf_alg() into single exit
tb [Tue, 9 Jul 2024 17:56:41 +0000 (17:56 +0000)]
Turn tls1_prf_alg() into single exit

requested by jsing on review
ok beck

5 months agoUnwrap a few more lines
tb [Tue, 9 Jul 2024 17:47:20 +0000 (17:47 +0000)]
Unwrap a few more lines

5 months agoUnwrap a couple of lines
tb [Tue, 9 Jul 2024 17:46:32 +0000 (17:46 +0000)]
Unwrap a couple of lines

5 months agoAlign math with t1_enc.c
tb [Tue, 9 Jul 2024 17:44:18 +0000 (17:44 +0000)]
Align math with t1_enc.c

suggested by jsing on review

5 months agoMinor cosmetics in pkey_tls1_prf_derive()
tb [Tue, 9 Jul 2024 17:35:55 +0000 (17:35 +0000)]
Minor cosmetics in pkey_tls1_prf_derive()

noticed by jsing on review

5 months agoFix a typo
yasuoka [Tue, 9 Jul 2024 17:34:10 +0000 (17:34 +0000)]
Fix a typo

5 months agoReplace explicit_bzero() plus free() with freezero()
tb [Tue, 9 Jul 2024 17:29:51 +0000 (17:29 +0000)]
Replace explicit_bzero() plus free() with freezero()

This is simpler, if slightly more expensive

5 months agoAdd radiusd_ipcp(8). A module which provides IP configuration through
yasuoka [Tue, 9 Jul 2024 17:26:14 +0000 (17:26 +0000)]
Add radiusd_ipcp(8).  A module which provides IP configuration through
RADIUS Access-Accept messages and manages IP address pool through
RADIUS accounting messages.

5 months agoImprove test coverage for TLS1-PRF
tb [Tue, 9 Jul 2024 17:24:12 +0000 (17:24 +0000)]
Improve test coverage for TLS1-PRF

This is basically a copy of the libssl unit tests, moved to libcrypto to
avoid starting the infection of libssl with this particular piece of EVP
garbage.

5 months agoAdd a minimal regress test for TLS1-PRF
tb [Tue, 9 Jul 2024 17:09:23 +0000 (17:09 +0000)]
Add a minimal regress test for TLS1-PRF

5 months agoShuffle things into a more sensible order
tb [Tue, 9 Jul 2024 17:05:46 +0000 (17:05 +0000)]
Shuffle things into a more sensible order

no functional change

5 months agoUse better order in EVP_PKEY_CTRL_TLS_SECRET
tb [Tue, 9 Jul 2024 17:04:50 +0000 (17:04 +0000)]
Use better order in EVP_PKEY_CTRL_TLS_SECRET

Also avoid an unnecessary NULL check.

5 months agoAdd tls1_prf_pkey_meth to pkey_methods
tb [Tue, 9 Jul 2024 17:02:29 +0000 (17:02 +0000)]
Add tls1_prf_pkey_meth to pkey_methods

ok jsing

5 months agoMake a NULL check explicit
tb [Tue, 9 Jul 2024 17:01:40 +0000 (17:01 +0000)]
Make a NULL check explicit

5 months agoZap or align some ugly comments
tb [Tue, 9 Jul 2024 17:00:59 +0000 (17:00 +0000)]
Zap or align some ugly comments

5 months agoTest & assign once more
tb [Tue, 9 Jul 2024 17:00:25 +0000 (17:00 +0000)]
Test & assign once more

5 months agosec_len -> secret_len
tb [Tue, 9 Jul 2024 16:59:50 +0000 (16:59 +0000)]
sec_len -> secret_len

5 months agoTest and assign in tls1_prf_P_hash()
tb [Tue, 9 Jul 2024 16:59:07 +0000 (16:59 +0000)]
Test and assign in tls1_prf_P_hash()

5 months agoFix whitespace around '/'
tb [Tue, 9 Jul 2024 16:58:13 +0000 (16:58 +0000)]
Fix whitespace around '/'

5 months agoInvert logic in tls1_prf_alg()
tb [Tue, 9 Jul 2024 16:57:27 +0000 (16:57 +0000)]
Invert logic in tls1_prf_alg()

5 months agoolen -> out_len
tb [Tue, 9 Jul 2024 16:54:13 +0000 (16:54 +0000)]
olen -> out_len

5 months agoAdd a few empty lines
tb [Tue, 9 Jul 2024 16:53:33 +0000 (16:53 +0000)]
Add a few empty lines

5 months agoseedlen -> seed_len
tb [Tue, 9 Jul 2024 16:52:34 +0000 (16:52 +0000)]
seedlen -> seed_len

5 months agoseclen -> secret_len
tb [Tue, 9 Jul 2024 16:51:50 +0000 (16:51 +0000)]
seclen -> secret_len

5 months agoslen -> secret_len
tb [Tue, 9 Jul 2024 16:51:01 +0000 (16:51 +0000)]
slen -> secret_len

5 months agosec -> secret
tb [Tue, 9 Jul 2024 16:50:07 +0000 (16:50 +0000)]
sec -> secret

5 months agoReplace local typedef with spelling out the struct name
tb [Tue, 9 Jul 2024 16:48:39 +0000 (16:48 +0000)]
Replace local typedef with spelling out the struct name

5 months agoRemove a few useless comments
tb [Tue, 9 Jul 2024 16:47:36 +0000 (16:47 +0000)]
Remove a few useless comments

5 months agoApply a knfmt(8) sledgehammer
tb [Tue, 9 Jul 2024 16:46:33 +0000 (16:46 +0000)]
Apply a knfmt(8) sledgehammer

5 months agoAdd an RCS tag
tb [Tue, 9 Jul 2024 16:45:33 +0000 (16:45 +0000)]
Add an RCS tag

5 months agoReplace license stub with full license
tb [Tue, 9 Jul 2024 16:44:42 +0000 (16:44 +0000)]
Replace license stub with full license

This reverts to the license added in OpenSSL's initial import of this
file in commit 1eff3485b63f84956b5f212aa4d853783bf6c8b5

5 months agolink tls1_prf.c to build
tb [Tue, 9 Jul 2024 16:41:44 +0000 (16:41 +0000)]
link tls1_prf.c to build

ok jsing

5 months agoReplace a malloc() call with calloc()
tb [Tue, 9 Jul 2024 16:38:40 +0000 (16:38 +0000)]
Replace a malloc() call with calloc()

5 months agoReplace an ossl_assert() with an error check
tb [Tue, 9 Jul 2024 16:37:43 +0000 (16:37 +0000)]
Replace an ossl_assert() with an error check

5 months agoUse C99 initializers for tls1_prf_pkey_meth()
tb [Tue, 9 Jul 2024 16:36:46 +0000 (16:36 +0000)]
Use C99 initializers for tls1_prf_pkey_meth()

5 months agoInline an instance of OPENSSL_memdup()
tb [Tue, 9 Jul 2024 16:33:10 +0000 (16:33 +0000)]
Inline an instance of OPENSSL_memdup()

5 months agoTidy up includes
tb [Tue, 9 Jul 2024 16:31:40 +0000 (16:31 +0000)]
Tidy up includes

5 months agoOPENSSL_free() -> free()
tb [Tue, 9 Jul 2024 16:30:54 +0000 (16:30 +0000)]
OPENSSL_free() -> free()

5 months agoOPENSSL_cleanse() -> explicit_bzero()
tb [Tue, 9 Jul 2024 16:30:28 +0000 (16:30 +0000)]
OPENSSL_cleanse() -> explicit_bzero()

5 months agoOPENSSL_clear_free() -> freezero()
tb [Tue, 9 Jul 2024 16:29:27 +0000 (16:29 +0000)]
OPENSSL_clear_free() -> freezero()

5 months agoOPENSSL_malloc() -> malloc()
tb [Tue, 9 Jul 2024 16:28:31 +0000 (16:28 +0000)]
OPENSSL_malloc() -> malloc()

5 months agoSpell OPENSSL_zalloc() correctly as calloc()
tb [Tue, 9 Jul 2024 16:27:48 +0000 (16:27 +0000)]
Spell OPENSSL_zalloc() correctly as calloc()

5 months agoMechanically replace KDFerr() with KDFerror()
tb [Tue, 9 Jul 2024 16:26:59 +0000 (16:26 +0000)]
Mechanically replace KDFerr() with KDFerror()

5 months agoTrack configured and new prefix delegations in iface.
florian [Tue, 9 Jul 2024 16:24:57 +0000 (16:24 +0000)]
Track configured and new prefix delegations in iface.

When the DHCPv6 server renumbers and hands us new delegations we have
to deconfigure the old prefixes. To prevent situations where we have
no IPv6 at all, first configure the new prefixes and then remove the
old prefixes.

5 months agoAdd a verbatim copy of tls1_prf.c from OpenSSL 1.1.1
tb [Tue, 9 Jul 2024 16:24:47 +0000 (16:24 +0000)]
Add a verbatim copy of tls1_prf.c from OpenSSL 1.1.1

From the last public commit b372b1f76450acdfed1e2301a39810146e28b02c
of the OpenSSL_1_1_1-stable branch

SHA256 (kdf/tls1_prf.c) = a519d3ff721d4ec59befac8586e24624fa87d9d8f6479327f7af58d652b6e4e5

Will be beat (a little bit) into shape in tree before linking it to the
build.

ok jsing

5 months agoAdd various defines for TLS1-PRF
tb [Tue, 9 Jul 2024 16:20:17 +0000 (16:20 +0000)]
Add various defines for TLS1-PRF

ok jsing

5 months agoSkip prefixes with vltime 0.
florian [Tue, 9 Jul 2024 16:15:42 +0000 (16:15 +0000)]
Skip prefixes with vltime 0.

Servers indicate unusable prefixes with vltime 0 when we are in
state reboot and probably hand us new, valid prefixes.
In IPv4 dhcp we would receive a NACK instead...

5 months agoAdd EVP_PKEY_TLS1_PRF as alias for NID_tls1_prf
tb [Tue, 9 Jul 2024 16:15:37 +0000 (16:15 +0000)]
Add EVP_PKEY_TLS1_PRF as alias for NID_tls1_prf

ok jsing

5 months agoChoose fixed NID for TLS1-PRF
tb [Tue, 9 Jul 2024 16:12:33 +0000 (16:12 +0000)]
Choose fixed NID for TLS1-PRF

5 months agoAdd NID for TLS1-PRF
tb [Tue, 9 Jul 2024 16:12:08 +0000 (16:12 +0000)]
Add NID for TLS1-PRF

ok jsing

5 months agoRead the whole buffer, not its size minus one.
mpi [Tue, 9 Jul 2024 16:08:30 +0000 (16:08 +0000)]
Read the whole buffer, not its size minus one.

From Christian Ludwig cludwig at genua.de.

5 months agonetlock is no longer held for SIOCSIFMEDIA and SIOCGIFMEDIA, so rely on
jmatthew [Tue, 9 Jul 2024 16:04:15 +0000 (16:04 +0000)]
netlock is no longer held for SIOCSIFMEDIA and SIOCGIFMEDIA, so rely on
the kernel lock instead, as done in if_ixl.c r1.84.

from Yuichiro NAITO

5 months agovmctl(8): set exit code for vmctl stat -r
mlarkin [Tue, 9 Jul 2024 15:51:11 +0000 (15:51 +0000)]
vmctl(8): set exit code for vmctl stat -r

set exit code to 1 if no running VMs are detected with vmctl stat -r.

ok dv

5 months agoRemove splassert() for now since IPL_STATCLOCK is MD and not all archs have it.
claudio [Tue, 9 Jul 2024 15:20:15 +0000 (15:20 +0000)]
Remove splassert() for now since IPL_STATCLOCK is MD and not all archs have it.
Noticed by bluhm@ on octeon

5 months agodocument C-u handling on shell-command{,-on-region}, forgot in previous
op [Tue, 9 Jul 2024 14:51:37 +0000 (14:51 +0000)]
document C-u handling on shell-command{,-on-region}, forgot in previous

5 months agoRemoving 'softdep' options from fstab entries during upgrade is no longer
krw [Tue, 9 Jul 2024 14:47:21 +0000 (14:47 +0000)]
Removing 'softdep' options from fstab entries during upgrade is no longer
necessary as 'softdep' is now a no-op.

ok beck@ sthen@

5 months agomg: handle C-u in M-! and M-|
op [Tue, 9 Jul 2024 14:46:17 +0000 (14:46 +0000)]
mg: handle C-u in M-! and M-|

With the C-u modifier, these commands (respectively shell-command
and shell-command-on-region) will operate in-place instead of opening
a special buffer with the result.

ok and lots of feedback from florian@

(signature for iomux and preadin changed after the ok -- the buffer
pointer was no longer needed)

5 months agoDon't push the error stack in ssl_sigalg_select()
beck [Tue, 9 Jul 2024 13:43:57 +0000 (13:43 +0000)]
Don't push the error stack in ssl_sigalg_select()

Doing so breaks certificate selection if a TLS 1.3 client does not support
EC certs, and needs to fall back to RSA.

ok tb@

5 months agoremove unnused prototype
florian [Tue, 9 Jul 2024 13:27:18 +0000 (13:27 +0000)]
remove unnused prototype

5 months agoDocument MODFONT_DOCDIR and MODFONT_DOCFILES.
bentley [Tue, 9 Jul 2024 13:05:15 +0000 (13:05 +0000)]
Document MODFONT_DOCDIR and MODFONT_DOCFILES.

5 months agoFix TLS key share check to not fire when using < TLS 1.3
beck [Tue, 9 Jul 2024 12:27:27 +0000 (12:27 +0000)]
Fix TLS key share check to not fire when using < TLS 1.3

The check was being too aggressive and was catching us when the
extension was being sent by a client which supports tls 1.3 but
the server was capped at TLS 1.2. This moves the check after the
max version check, so we won't error out if we do not support
TLS 1.3

Reported by obsd@bartula.de

ok tb@

5 months agodo not need to force bss values to 0
deraadt [Tue, 9 Jul 2024 11:21:44 +0000 (11:21 +0000)]
do not need to force bss values to 0

5 months agodo a manual ret-clean operation inside the vmm_dispatch_intr asm code
deraadt [Tue, 9 Jul 2024 11:15:58 +0000 (11:15 +0000)]
do a manual ret-clean operation inside the vmm_dispatch_intr asm code
ok mlarkin

5 months agosync with userland: let z_off_t fall back to long long instead of long
tb [Tue, 9 Jul 2024 10:51:14 +0000 (10:51 +0000)]
sync with userland: let z_off_t fall back to long long instead of long

In the boot blocks, this would result in various 64-bit instruction being
used, which might result in undesirable bloat in legacy boot loaders, so
add a workaround for the _STANDALONE case to still fall back to long
instead of long long.

with/ok deraadt, ok millert

5 months agoLet z_off_t fall back to long long instead of only long
tb [Tue, 9 Jul 2024 10:48:31 +0000 (10:48 +0000)]
Let z_off_t fall back to long long instead of only long

This is a noop on OpenBSD in userland

ok deraadt millert

5 months agoActually enable namespaced builds in both libcrypto and libssl
beck [Tue, 9 Jul 2024 09:39:14 +0000 (09:39 +0000)]
Actually enable namespaced builds in both libcrypto and libssl

(instead of commiting only one part)

5 months agoIPv6 forward copies small packet content on the stack.
bluhm [Tue, 9 Jul 2024 09:33:13 +0000 (09:33 +0000)]
IPv6 forward copies small packet content on the stack.

Unfortunately RFC 4443 demands that the ICMP6 error packet containing
the orignal packet is up to 1280 bytes long.  That means for every
forwarded packet forward() creates a mbuf copy, just in case delivery
fails.

For small packets we can copy the content on the stack like IPv4
forward does.  This saves us some mbuf allocations if the content
is shorter than the mbuf data size.

OK mvs@

5 months agovmd/vmm: move vm_run_params into mi header.
dv [Tue, 9 Jul 2024 09:31:37 +0000 (09:31 +0000)]
vmd/vmm: move vm_run_params into mi header.

To prepare for mi/md splitting vmd, need to fixup the dev/vmm/vmm.h
mi header. Move the vm_run_params struct and clean up the includes
in vmd.

"sure", mlarkin@

5 months agoReshuffle the switch cases in ptsignal and single_thread_set to be
claudio [Tue, 9 Jul 2024 09:22:50 +0000 (09:22 +0000)]
Reshuffle the switch cases in ptsignal and single_thread_set to be
in the order needed for future changes. No functional change.
OK mpi@

5 months agoImplement MSI multiple-vector support.
kettenis [Tue, 9 Jul 2024 08:47:10 +0000 (08:47 +0000)]
Implement MSI multiple-vector support.

ok patrick@

5 months agoIn sched_toidle() only call the TRACEPOINT if curproc is set.
claudio [Tue, 9 Jul 2024 08:44:36 +0000 (08:44 +0000)]
In sched_toidle() only call the TRACEPOINT if curproc is set.
sched_toidle() is called by cpu_hatch() to start APs and then curproc
may be NULL.
OK mpi@

5 months agoAdd bounded attributes to hmac.h
tb [Tue, 9 Jul 2024 07:57:57 +0000 (07:57 +0000)]
Add bounded attributes to hmac.h

ok beck

5 months agoKNF a pile of else if blocks; ok tb
deraadt [Tue, 9 Jul 2024 07:51:09 +0000 (07:51 +0000)]
KNF a pile of else if blocks; ok tb

5 months agoEnable namespaced builds by default for libssl and libcrypto.
beck [Tue, 9 Jul 2024 07:39:21 +0000 (07:39 +0000)]
Enable namespaced builds by default for libssl and libcrypto.

Some further refinements will happen to the build process to
automatically generate the Symbols.namespace file, and to remove
our last public unhidden symbol (which was a mistake, but waits for
a major bump to get removed)

But for now everything should be using this.

ok tb@

5 months agoRemove trailing whitespace. No code change.
mlarkin [Tue, 9 Jul 2024 07:28:12 +0000 (07:28 +0000)]
Remove trailing whitespace. No code change.

5 months agoHide remaining unused ERR functions in err.h
beck [Tue, 9 Jul 2024 07:17:13 +0000 (07:17 +0000)]
Hide remaining unused ERR functions in err.h

ok tb@

5 months agoHide CRYPTO_get_dynlock_create_callback
beck [Tue, 9 Jul 2024 07:16:44 +0000 (07:16 +0000)]
Hide CRYPTO_get_dynlock_create_callback

ok tb@

5 months agoHide DES global variables
beck [Tue, 9 Jul 2024 07:16:13 +0000 (07:16 +0000)]
Hide DES global variables

ok tb@