eric [Wed, 8 Apr 2020 07:30:44 +0000 (07:30 +0000)]
bump smtpd version
djm [Wed, 8 Apr 2020 00:10:37 +0000 (00:10 +0000)]
let sshkey_try_load_public() load public keys from the unencrypted
envelope of private key files if not sidecar public key file is
present.
ok markus@
djm [Wed, 8 Apr 2020 00:09:24 +0000 (00:09 +0000)]
simplify sshkey_try_load_public()
ok markus@
djm [Wed, 8 Apr 2020 00:08:46 +0000 (00:08 +0000)]
add sshkey_parse_pubkey_from_private_fileblob_type()
Extracts a public key from the unencrypted envelope of a new-style
OpenSSH private key.
ok markus@
djm [Wed, 8 Apr 2020 00:07:19 +0000 (00:07 +0000)]
simplify sshkey_parse_private_fileblob_type()
Try new format parser for all key types first, fall back to PEM
parser only for invalid format errors.
ok markus@
djm [Wed, 8 Apr 2020 00:05:59 +0000 (00:05 +0000)]
check private key type against requested key type in new-style private
decoding; ok markus@
djm [Wed, 8 Apr 2020 00:04:32 +0000 (00:04 +0000)]
check that pubkey in private key envelope matches actual private key
(this public key is currently unusued)
ok markus@
djm [Wed, 8 Apr 2020 00:01:52 +0000 (00:01 +0000)]
refactor private key parsing a little
Split out the base64 decoding and private section decryption steps in
to separate functions. This will make the decryption step easier to fuzz
as well as making it easier to write a "load public key from new-format
private key" function.
ok markus@
schwarze [Tue, 7 Apr 2020 22:45:37 +0000 (22:45 +0000)]
Separate the place to put the <a href> permalink (now marked
with NODE_HREF) from the target element of the link (still marked
with NODE_ID). In many cases, use this to move the target to the
beginning of the paragraph, such that readers don't get dropped
into the middle of a sentence.
tobhe [Tue, 7 Apr 2020 18:52:57 +0000 (18:52 +0000)]
Always prefer generic signature authentication (RFC 7427) , not just for RSA.
ok markus@
claudio [Tue, 7 Apr 2020 18:05:47 +0000 (18:05 +0000)]
Do not create /hooray as part of the regress test. Regress tests
should not create random files in the root partition.
OK beck@
kettenis [Tue, 7 Apr 2020 15:23:42 +0000 (15:23 +0000)]
Claim framebuffer that was configured by bootloader.
ok patrick@
nicm [Tue, 7 Apr 2020 13:55:24 +0000 (13:55 +0000)]
Do not restore history flag if it was never set.
nicm [Tue, 7 Apr 2020 13:38:30 +0000 (13:38 +0000)]
Do not send mouse events if the program has not requested them.
visa [Tue, 7 Apr 2020 13:38:14 +0000 (13:38 +0000)]
Zap a stray Pp.
visa [Tue, 7 Apr 2020 13:36:18 +0000 (13:36 +0000)]
Fix a few old typos.
visa [Tue, 7 Apr 2020 13:33:50 +0000 (13:33 +0000)]
Document SMR_TAILQ macros.
nicm [Tue, 7 Apr 2020 13:33:00 +0000 (13:33 +0000)]
Limit size to 1x1 (total size 3x3).
claudio [Tue, 7 Apr 2020 13:30:23 +0000 (13:30 +0000)]
For open with O_CREAT pass a mask of 0644 with else files are created
with somewhat random filemodes.
OK beck@
visa [Tue, 7 Apr 2020 13:27:50 +0000 (13:27 +0000)]
Abstract the head of knote lists. This allows extending the lists,
for example, with locking assertions.
OK mpi@, anton@
visa [Tue, 7 Apr 2020 12:52:27 +0000 (12:52 +0000)]
Defer selwakeup() from kqueue_wakeup() to kqueue_task() to prevent
deep recursion. This also helps making kqueue_wakeup() free of the
kernel lock because the current implementation of selwakeup()
requires the lock.
OK mpi@
kettenis [Tue, 7 Apr 2020 10:11:01 +0000 (10:11 +0000)]
Kill board_id variable; its last consumer is gone now.
ok jsg@
espie [Tue, 7 Apr 2020 09:40:09 +0000 (09:40 +0000)]
install -d should error out if no directory is given
(this would have prevented a recent typo in bsd.port.mk from
going in)
as discussed with theo, merge the check that's in FreeBSD
kettenis [Tue, 7 Apr 2020 09:32:44 +0000 (09:32 +0000)]
Kill unused extern declaration.
mpi [Tue, 7 Apr 2020 09:29:45 +0000 (09:29 +0000)]
Unified diff makes it easier to understand where regressions are.
kettenis [Tue, 7 Apr 2020 09:09:46 +0000 (09:09 +0000)]
Use PHY framework to replace hardcoded board-specific GPIO poking.
ok jsg@
kettenis [Tue, 7 Apr 2020 09:08:15 +0000 (09:08 +0000)]
Implement support for "usb-nop-xceiv" PHYs.
ok jsg@
kettenis [Tue, 7 Apr 2020 09:06:52 +0000 (09:06 +0000)]
Fix off-by-one in check for valid pin numbers and use the existing
#define in the check.
kettenis [Tue, 7 Apr 2020 09:04:34 +0000 (09:04 +0000)]
Remove entry that is no longer needed.
ok jsg@
claudio [Tue, 7 Apr 2020 08:23:54 +0000 (08:23 +0000)]
Implement a SMR TAILQ implementation. The only operations which can be used
in SMR read-side critical sections are SMR_TAILQ_FOREACH(), SMR_TAILQ_FIRST()
and SMR_TAILQ_NEXT(). Most notably the last element can not be accessed
in a read-side critical section.
OK visa@
claudio [Tue, 7 Apr 2020 07:11:22 +0000 (07:11 +0000)]
Deny to create a pipex session if the session id already exists.
From Vitaliy Makkoveev
OK yasuoka@
mpi [Tue, 7 Apr 2020 07:09:47 +0000 (07:09 +0000)]
Remove superfluous NULL check from allocation with PR_WAITOK.
From Vitaliy Makkoveev
cheloha [Mon, 6 Apr 2020 23:16:50 +0000 (23:16 +0000)]
acpi(4): acpi_sleep(): tsleep(9) -> tsleep_nsec(9)
kettenis@ notes that ACPI integers are supposed to be unsigned, but
ours are signed. This is a much deeper problem than what I'm looking
to change with this conversion. To work around the issue for now we
can round the sleep interval up to 1 millisecond.
There is a very nasty-looking rwsleep(9) call elsewhere in
dev/acpi/dsdt.c that I'm going to leave as-is for now to avoid
breaking something.
With input from pirofti@, kettenis@, and mortimer@.
Tested by Lucas Raab, Moises Simon, mortimer@, and gkoehler@.
ok kettenis@
tobhe [Mon, 6 Apr 2020 20:23:16 +0000 (20:23 +0000)]
Fix pubkey leak in CA process for ASN1_DN IDs.
ok markus@
cheloha [Mon, 6 Apr 2020 19:45:47 +0000 (19:45 +0000)]
wi(4): tsleep(9) -> tsleep_nsec(9); ok stsp@
cheloha [Mon, 6 Apr 2020 19:03:09 +0000 (19:03 +0000)]
sunkbd(4): timeout_add(9) -> timeout_add_msec(9); ok kettenis@
cheloha [Mon, 6 Apr 2020 17:54:50 +0000 (17:54 +0000)]
pcppi(4), spkr(4): ticks -> milliseconds
In pcppi(4), convert from ticks to milliseconds.
While we're doing this, we can also convert spkr(4), too.
The spkr(4) conversion from ticks to milliseconds is trickier because
the driver is written with musical intervals (whole notes, quarter
notes, etc.), not the typical units (seconds, milliseconds, etc.) used
in most software.
I think the conversion is correct... but the code is a challenging
read, so it might be subtly incorrect.
ratchov@ intends to move spkr(4) into the attic sometime soon so I
doubt it matters much if I got it wrong.
Input from schwarze@, jsg@, and ratchov@.
Tested by schwarze@.
ok ratchov@
nicm [Mon, 6 Apr 2020 17:51:34 +0000 (17:51 +0000)]
Change copy mode to make copy of the pane history so it does not need to
freeze updates (which does not play nicely with some applications, a
longstanding problem) and will allow some other changes later. From
Anindya Mukherjee.
krw [Mon, 6 Apr 2020 17:05:40 +0000 (17:05 +0000)]
dhcpd could reference freed memory after releasing a lease with
an unusually long uid.
Reported by Adarsh Dinesh. Thanks!
jsing [Mon, 6 Apr 2020 16:53:45 +0000 (16:53 +0000)]
Re-enable the client test now that it passes again.
jsing [Mon, 6 Apr 2020 16:53:09 +0000 (16:53 +0000)]
Minor code improvements.
jsing [Mon, 6 Apr 2020 16:52:26 +0000 (16:52 +0000)]
Add tests that cover TLSv1.2 and disable those that trigger TLSv1.3.
This allows the test to pass again.
jsing [Mon, 6 Apr 2020 16:50:27 +0000 (16:50 +0000)]
Zero the client random field in the TLSv1.2 golden value.
jsing [Mon, 6 Apr 2020 16:49:42 +0000 (16:49 +0000)]
Improve comparision with test data.
First check the client random against the zeroed value, then zero the
client random in the client hello, before comparing with the golden value.
This makes failures more obvious and the test code more readable.
jsing [Mon, 6 Apr 2020 16:45:50 +0000 (16:45 +0000)]
Dump the test data when the lengths differ in order to aid debugging.
jsing [Mon, 6 Apr 2020 16:44:15 +0000 (16:44 +0000)]
Use errx() if we fail to build the client hello.
visa [Mon, 6 Apr 2020 16:29:53 +0000 (16:29 +0000)]
Remove redundant VOP_CLOSE() and vput(). The fail branch will close
the vnode because `open' is true.
OK deraadt@, anton@
jsing [Mon, 6 Apr 2020 16:28:38 +0000 (16:28 +0000)]
Send a zero-length session identifier if TLSv1.3 is not enabled.
If the maximum version is less than TLSv1.3, send a zero-length session
identifier (matching the behaviour of the legacy TLS stack), rather than
a 32 byte random identifier. The 32 byte random identifier is only needed
for "compatibility" mode in TLSv1.3.
ok beck@
visa [Mon, 6 Apr 2020 16:23:44 +0000 (16:23 +0000)]
Build bootecoff with divdi3.c. bootecoff needs __divdi3,
but the linker does not complain about missing symbols.
Prompted by miod@
claudio [Mon, 6 Apr 2020 13:14:04 +0000 (13:14 +0000)]
use LIST_FOERACH_SAFE() instead of manual rolling the loop.
From Vitaliy Makkoveev
kettenis [Mon, 6 Apr 2020 13:03:02 +0000 (13:03 +0000)]
Add support for the cd-gpios property.
ok jsg@
kettenis [Mon, 6 Apr 2020 13:01:36 +0000 (13:01 +0000)]
Register controller with the gpio "framework".
ok jsg@
claudio [Mon, 6 Apr 2020 12:31:30 +0000 (12:31 +0000)]
Pass struct pipex_iface_context pointer down to pipex ioctl functions.
This way pppx(4) and pppac(4) can be further unified. This is an
intermediary step that does not introduce any behaviour change.
From Vitaliy Makkoveev
jmatthew [Mon, 6 Apr 2020 11:27:23 +0000 (11:27 +0000)]
fix previous: use the correct offset for sq/rq creation, and don't
reset the mbox counter to 0 after calculating it.
schwarze [Mon, 6 Apr 2020 09:55:49 +0000 (09:55 +0000)]
Support manual tagging of .Pp, .Bd, .D1, .Dl, .Bl, and .It.
In HTML output, improve the logic for writing inside permalinks:
skip them when there is no child content or when there is a risk
that the children might contain flow content.
dtucker [Mon, 6 Apr 2020 09:43:55 +0000 (09:43 +0000)]
Add utf8.c for asmprintf used by krl.c
mpi [Mon, 6 Apr 2020 08:31:04 +0000 (08:31 +0000)]
Make it possible to use ix(4) with MSI-X, currently disabled by default.
The current implementation still uses a single queue but already establishes
a different handler for link interrupts. This is done in preparation for
multi-queues support.
The performance and i386 regression exposed by the last version of this
diff have been fixed thanks to the help of Hrvoje Popovski.
Based on a bigger diff from haesbaert@ and on the FreeBSD code.
Tested by Sigi Rudzio, Hrvoje Popovski and jmatthew@, ok jmatthew@
claudio [Mon, 6 Apr 2020 07:52:12 +0000 (07:52 +0000)]
Fix single thread behaviour in sleep_setup_signal(). If a thread needs to
suspend (SINGLE_SUSPEND or SINGLE_PTRACE) it needs to do this in
sleep_setup_signal(). This way the case where single_thread_clear() is
called before the sleep gets its wakeup call can be correctly handled and
the thread is put back to sleep in sleep_finish(). If the wakeup happens
before unsuspend then p_wchan is 0 and the thread will not go to sleep again.
In case of a unwind an error is returned causing the thread to return
immediatly with that error.
With and OK mpi@ kettenis@
cheloha [Mon, 6 Apr 2020 02:44:31 +0000 (02:44 +0000)]
futex(2): FUTEX_WAIT: rwsleep_nsec(9) at least one nanosecond
mpi@ and I added a warning log to *sleep_nsec(9) last year to smoke
out division-to-zero bugs when converting kernel code from *sleep(9)
to the new interfaces. It whines if you tell it to sleep for zero
nanoseconds.
Now that rwsleep_nsec(9) is exposed to userspace via futex(2), though,
it is possible to get a legitimate zero-nanosecond timeout from the
user. This can cause a lot of logging, which apparently can cause
hiccups and hangs in Mesa.
As a quick fix we can round the timeout up to one nanosecond and
silence the warning. No logs, no delays, no hiccups or hangs.
--
Aside: it is unclear what we are supposed to do in the FUTEX_WAIT
zero-nanosecond timeout case: block for a tick or return ETIMEDOUT
immediately. The Linux futex(2) manpage does not mention the case.
It'd be nice to knew what the proper behavior is.
--
Prompted by matthieu@. Input from kettenis@ and deraadt@.
Tested by matthieu@, ajacoutot@.
In snaps since Mar 27 2020.
ok ajacoutot@, deraadt@, kettenis@.
visa [Mon, 6 Apr 2020 02:10:33 +0000 (02:10 +0000)]
Enable FFS2 in sgi bootblocks and ramdisks.
Tested with boot64 on IP30. State of boot32 and bootecoff is unknown.
OK otto@, deraadt@
jmatthew [Mon, 6 Apr 2020 01:28:58 +0000 (01:28 +0000)]
Add a helper function for writing physical addresses for queues into
command queue mailboxes, and use this for all queue setup commands.
Previously we just assumed the addresses would fit in the first mailbox,
which is currently true but may not be for much longer.
ok dlg@
pirofti [Mon, 6 Apr 2020 00:01:08 +0000 (00:01 +0000)]
Update my email address.
sthen [Sun, 5 Apr 2020 21:34:15 +0000 (21:34 +0000)]
sync
deraadt [Sun, 5 Apr 2020 20:14:14 +0000 (20:14 +0000)]
minor cranking of libraries exposes a problem, details too long to explain.
Run ldconfig -R after installing base libraries, and once again after
installing gnu libraries.
ok kettenis
jmc [Sun, 5 Apr 2020 19:39:21 +0000 (19:39 +0000)]
sitaracm removed;
jmc [Sun, 5 Apr 2020 19:37:55 +0000 (19:37 +0000)]
add arch to the Dt line;
denis [Sun, 5 Apr 2020 18:19:04 +0000 (18:19 +0000)]
Handle connected routes as ospfd(8) does.
OK remi@
tb [Sun, 5 Apr 2020 16:15:39 +0000 (16:15 +0000)]
adjust day of the week and year
krw [Sun, 5 Apr 2020 15:15:42 +0000 (15:15 +0000)]
Make FFS2 the default filesystem type on installs except for landisk,
luna88k and sgi.
ok otto@ deraadt@ (for diff with same effect)
kettenis [Sun, 5 Apr 2020 14:02:29 +0000 (14:02 +0000)]
Use OF_is_compatible() to simplify the initialization for the "mdio" node.
Add code to enable the clock which is present in new device trees.
ok jsg@
kettenis [Sun, 5 Apr 2020 13:55:53 +0000 (13:55 +0000)]
Define the appropriate __GCC_HAVE_SYNC_COMPARE_AND_SWAP_* symbols like all
other clang platforms do.
ok jca@
tobhe [Sun, 5 Apr 2020 13:52:14 +0000 (13:52 +0000)]
Fix size checks in ikev2_getimsgdata().
ok markus@
kettenis [Sun, 5 Apr 2020 13:21:54 +0000 (13:21 +0000)]
Remove sitaracm(4).
kettenis [Sun, 5 Apr 2020 13:19:49 +0000 (13:19 +0000)]
Fix pasto
kettenis [Sun, 5 Apr 2020 13:18:50 +0000 (13:18 +0000)]
omrng(4)
kettenis [Sun, 5 Apr 2020 13:11:13 +0000 (13:11 +0000)]
Add omrng(4), a driver for te random number generator found on TI OMAP SoCs.
ok jsg@
jmc [Sun, 5 Apr 2020 10:11:07 +0000 (10:11 +0000)]
"Protocol" keyword no longer used; from martin vahlensieck
nicm [Sun, 5 Apr 2020 08:40:31 +0000 (08:40 +0000)]
Add an argument to list-commands to show only a single command.
mpi [Sun, 5 Apr 2020 08:32:14 +0000 (08:32 +0000)]
Do not assume futex(2) is always returning an errno value.
In the case of FUTEX_WAKE a number of woken threads is returned.
ok guenther@
visa [Sun, 5 Apr 2020 07:31:45 +0000 (07:31 +0000)]
Declare pledgenames[] as const.
OK deraadt@
deraadt [Sun, 5 Apr 2020 06:38:02 +0000 (06:38 +0000)]
syn
deraadt [Sun, 5 Apr 2020 06:34:19 +0000 (06:34 +0000)]
crank to 6.7-beta
deraadt [Sun, 5 Apr 2020 04:57:53 +0000 (04:57 +0000)]
sync
jca [Sat, 4 Apr 2020 23:46:30 +0000 (23:46 +0000)]
Make libcxxabi provide __register_frame, _Unwind_Backtrace and friends
on sparc64
Discrepancy spotted in
http://build-failures.rhaalovely.net/sparc64/2020-04-03/devel/llvm,,-main.log
Input from gkoehler@, ok kettenis@ deraadt@
dtucker [Sat, 4 Apr 2020 23:04:41 +0000 (23:04 +0000)]
Indicate if we're using a cached key in trace output.
dtucker [Sat, 4 Apr 2020 22:14:26 +0000 (22:14 +0000)]
Some platforms don't have "hostname -s", so use cut to trim short hostname
instead.
kettenis [Sat, 4 Apr 2020 22:11:36 +0000 (22:11 +0000)]
Implement __atomic_is_lock_free for powerpc. Needed because the
architecture doesn't implement 64-bit atomic operations. This
implementation is pessimistic and only flags naturally aligned
operations up to and including 32-bit as lock free.
tested by cwen@
ok gkoehler@
kettenis [Sat, 4 Apr 2020 22:08:02 +0000 (22:08 +0000)]
Tweak the code that wakes up uvm_pmalloc sleepers in the page daemin.
Although there are open questions about whether we should flag failures with
UVM_PMA_FAIL or not, we really should only wake up a sleeper if we unlink
the pma. For now only do that if pages were actually freed in the requested
region.
Prompted by:
CID
1453061 Logically dead code
which should be fixed by this commit.
ok (and together with) beck@
tobhe [Sat, 4 Apr 2020 20:36:34 +0000 (20:36 +0000)]
It makes no sense to fall back to original policy if the relookup with the
received initiator ID fails. Send AUTH_FAILED message and exit instead.
ok markus@
schwarze [Sat, 4 Apr 2020 20:23:06 +0000 (20:23 +0000)]
automatically tag .SH and .SS in man(7) terminal output
in the same way as it was done for .Sh and .Ss in mdoc(7)
mpi [Sat, 4 Apr 2020 16:41:23 +0000 (16:41 +0000)]
Prevent the destruction of a session owned by another interface.
Issue reported by and fix from Vitaliy Makkoveev.
gkoehler [Sat, 4 Apr 2020 14:06:21 +0000 (14:06 +0000)]
Fix powerpc libunwind for cpus without altivec.
Defer saving the altivec registers until we need to access them (like
how arm defers saving the VFP registers). This prevents a SIGILL on a
G3 cpu when code throws a C++ exception.
ok kettenis@
deraadt [Sat, 4 Apr 2020 13:28:46 +0000 (13:28 +0000)]
clang bsd.rd is a bit bigger..
kettenis [Sat, 4 Apr 2020 09:54:04 +0000 (09:54 +0000)]
Fix "small pic" secure plt support.
ok mortimer@
mpi [Sat, 4 Apr 2020 08:57:36 +0000 (08:57 +0000)]
Prevent shadowing of local variable by the EV_SET() macro.
Use two underbars to start the locally defined variable, as suggested by
guenther@. The other option to avoid namespace conflict would be to start
the identifier with an underbar and a capital.
ok beck@, guenther@
ratchov [Sat, 4 Apr 2020 08:43:08 +0000 (08:43 +0000)]
Use /dev/audioctlN instead of /dev/mixerN.
/dev/audioctlN files are opened in O_WRONLY mode because mixerctl(2)
doesn't need to read them.
tweaks and ok mestre and kn
espie [Sat, 4 Apr 2020 08:41:54 +0000 (08:41 +0000)]
document new additions to control socket
remove "new" in the description of addpath, since
it lead to false assumptions
note that stub hasn't been tested yet
deraadt [Sat, 4 Apr 2020 03:24:03 +0000 (03:24 +0000)]
sync
jmatthew [Sat, 4 Apr 2020 01:48:03 +0000 (01:48 +0000)]
Return ENETRESET on success from mcx_up() so mcx_ioctl() will call
mcx_iff(), repplying the promisc and allmulti flags on the interface.
This may have contributed to some problems dlg@ and I had the other day.
ok dlg@
jsg [Fri, 3 Apr 2020 23:18:36 +0000 (23:18 +0000)]
increase rdroot size
ok kettenis@ deraadt@