tb [Sat, 28 Aug 2021 08:16:39 +0000 (08:16 +0000)]
Add RCS marker
beck [Sat, 28 Aug 2021 07:54:57 +0000 (07:54 +0000)]
Add case 2c to the go side. Don't tell jsing I touched go.
beck [Sat, 28 Aug 2021 07:49:00 +0000 (07:49 +0000)]
Remove the "dump_chain" flag and code. This was a workaround for a problem where
roots were not checked correctly before intermediates that has since been fixed
and is no longer necessary. It is regress checked by case 2c in
regress/lib/libcrypto/x509/verify.c
ok jsing@ tb@
robert [Sat, 28 Aug 2021 06:46:49 +0000 (06:46 +0000)]
use stderr for printing error and informational messages
this makes it easier to parse what passwd(1) is doing if
spawned from a GUI
ok millert@
kettenis [Sat, 28 Aug 2021 06:03:25 +0000 (06:03 +0000)]
Remove bogus code that tries to unmap GTT pages in a codepath that clearly
doesn't deal with non-GTT mappings. What the Linux code does here isn't
possible on OpenBSD and probably unecessary.
Seems to fix a crash reported by sthen@
ok jsg@
inoguchi [Sat, 28 Aug 2021 05:30:09 +0000 (05:30 +0000)]
Check X509_get_notAfter return value in openssl(1) ca.c
inoguchi [Sat, 28 Aug 2021 05:14:30 +0000 (05:14 +0000)]
Use strndup instead of malloc, memcpy and NULL termination in openssl(1) ca.c
suggested from tb@ for do_updatedb(),
and applied the same for do_body() and do_revoke().
inoguchi [Sat, 28 Aug 2021 04:02:20 +0000 (04:02 +0000)]
Remove ASN1_TIME_new and use NULL for X509_gmtime_adj, free tmptm in err path
comments from tb@
inoguchi [Sat, 28 Aug 2021 02:40:17 +0000 (02:40 +0000)]
Unwrap lines in openssl(1) ca.c
suggested from tb@
inoguchi [Sat, 28 Aug 2021 02:24:10 +0000 (02:24 +0000)]
Avoid leak with X509_REVOKED variable in openssl(1) ca.c
pointed out by tb@
inoguchi [Sat, 28 Aug 2021 02:11:18 +0000 (02:11 +0000)]
Checking the return value in openssl(1) ca.c
Some functions are used without verifying the return value in openssl(1) ca.
This diff adds checking for the function return value.
With this diff, I changed return value of the write_new_certificate from void
to int to return the condition to the caller.
ok and comments from tb@
nicm [Fri, 27 Aug 2021 17:25:55 +0000 (17:25 +0000)]
Replace %% in command lists (by copying them) for template arguments ,
this means they can be used with {} as well. Also make argument
processing from an existing vector preserve commands. GitHub issue 2858.
nicm [Fri, 27 Aug 2021 17:15:57 +0000 (17:15 +0000)]
Allow control mode clients to set a hard limit on the window width and
height, GitHub issue 2594.
beck [Fri, 27 Aug 2021 16:15:42 +0000 (16:15 +0000)]
Add regress test testing having the root cert in the intermediate bundle
tb [Fri, 27 Aug 2021 16:12:33 +0000 (16:12 +0000)]
Remove unused #include <assert.h>.
This is from upstream where there is an assert() that EVP_MD_size(digest)
matches the length returned by HMAC(). We avoid asserts in our libraries.
From Martin Vahlensieck
krw [Fri, 27 Aug 2021 11:28:22 +0000 (11:28 +0000)]
Replace stray hand-rolled nitems() with nitems().
jsg [Fri, 27 Aug 2021 02:47:48 +0000 (02:47 +0000)]
drm/amd/display: workaround for hard hang on HPD on native DP
From Qingqing Zhuo
2e6cc93e1b8cf3ec2966961c1e98722ee7281023 in linux 5.10.y/5.10.61
c4152b297d56d3696ad0a9003169bc5b98ad7b72 in mainline linux
jsg [Fri, 27 Aug 2021 02:43:55 +0000 (02:43 +0000)]
drm/amd/display: Fix Dynamic bpp issue with 8K30 with Navi 1X
From Bing Guo
dcc8c5fb8d8595f5061c7b000ca1d16449a5e865 in linux 5.10.y/5.10.61
06050a0f01dbac2ca33145ef19a72041206ea983 in mainline linux
jsg [Fri, 27 Aug 2021 02:41:36 +0000 (02:41 +0000)]
drm/amdgpu: fix the doorbell missing when in CGPG issue for renoir.
From Yifan Zhang
7525f2e4de0069983497a9d3eab1ca9813ae1b4b in linux 5.10.y/5.10.61
1c0539a6fc8a4a4b77278e35d763073890de96b9 in mainline linux
jcs [Thu, 26 Aug 2021 21:05:01 +0000 (21:05 +0000)]
Request wMaxInputLength bytes of data on each interrupt which should
already account for the two-byte length and one-byte report id,
rather than adding them ourself and requesting wMaxInputLength + 3.
Fixes dwiic timeouts requesting data from at least one touchpad.
Tested by various
anton [Thu, 26 Aug 2021 10:32:35 +0000 (10:32 +0000)]
Rename ucc_intr_to_usage() to ucc_bits_to_usage(), no functional change.
anton [Thu, 26 Aug 2021 10:29:02 +0000 (10:29 +0000)]
Add missing leading colon to error message.
kevlo [Thu, 26 Aug 2021 07:11:09 +0000 (07:11 +0000)]
There are some races in the hardware which thus require a few more tries
to get ownership.
See Linux commit
501fd9895c1d7d8161ed56698ae2fccb10ef14f5
ok stsp@
krw [Wed, 25 Aug 2021 23:47:36 +0000 (23:47 +0000)]
Two more Capt. Obvious comments go away.
krw [Wed, 25 Aug 2021 21:07:47 +0000 (21:07 +0000)]
Don't use log_procname before it is initialized. In particular
set_iff_up() is called from initialize_interface() and was using
log_procname instead of ifi->name in its fatal()'s.
Diagnosed by tb@ from a recent reddit post by zielonykid1234.
krw [Wed, 25 Aug 2021 13:25:23 +0000 (13:25 +0000)]
Consolidate '-e' edit command parsing into ask_cmd(), simplifying
the main '-e' loop.
No functional change.
nicm [Wed, 25 Aug 2021 10:18:01 +0000 (10:18 +0000)]
Improve some logging.
nicm [Wed, 25 Aug 2021 10:15:15 +0000 (10:15 +0000)]
Ignore client creating session when working out size if it is a control
client.
nicm [Wed, 25 Aug 2021 09:18:08 +0000 (09:18 +0000)]
bind-key needs to allow commands for any argument for the moment.
nicm [Wed, 25 Aug 2021 08:51:55 +0000 (08:51 +0000)]
Validate command argument types (string or command list) and give more
useful error messages.
nicm [Wed, 25 Aug 2021 07:37:20 +0000 (07:37 +0000)]
setupterm needs char * not const char * on some platforms.
nicm [Wed, 25 Aug 2021 07:09:30 +0000 (07:09 +0000)]
Fix up some printflike attributes.
nicm [Wed, 25 Aug 2021 06:36:05 +0000 (06:36 +0000)]
Start inputs as NULL so not freeing random stack garbage, GitHub issue 2852.
anton [Wed, 25 Aug 2021 05:48:50 +0000 (05:48 +0000)]
Make all conversion routines consistent by returning a struct
ucc_keysym. No functional change.
anton [Wed, 25 Aug 2021 05:48:02 +0000 (05:48 +0000)]
Remove the KB_DEFAULT flag from the wskbd keymap layout. Presence of
this flag will cause wskbd to discard the given keymap layout and
instead favor the layout of the associated wsmux. This is not a problem
while attaching ucc(4) during boot as the wsmux uses the default layout
at this point. However, if the layout is changed using /etc/kbdtype from
rc(8) during boot, attaching ucc(4) at this point would cause
wskbd_attach() to get stuck in an infinite loop:
wskbdX: cannot load keymap, falling back to default
... which in turn is caused by ucc(4) only providing a us layout and
using anything else in /etc/kbdtype would not work.
I missed this as I don't use /etc/kbdtype but cwen@ and Mazzurco
Riccardo <mazzurco dot riccardo at protonmail dot com> reported the same
problem.
anton [Wed, 25 Aug 2021 05:47:15 +0000 (05:47 +0000)]
Prevent ucc(4) from matching report IDs with an empty input report.
Fixes cwen@'s Creative BT-W3 audio device.
anton [Wed, 25 Aug 2021 05:46:31 +0000 (05:46 +0000)]
If the buffer given to the ucc interrupt handler is too long, do not
discard it but instead just inspect the first bytes that can make up a
usage. This is a work around as the correct solution is to only inspect
a limited number of bits as given by the report count and size
associated with the Consumer usage page.
Final piece to get florian@'s Microsoft Sculpt keyboard working.
anton [Wed, 25 Aug 2021 05:45:33 +0000 (05:45 +0000)]
Determine if a hid item is an array by solely inspecting presence of
associated min/max boundaries. Assuming that every usage array starts
with the Control usage is incorrect.
Fixes claudio@'s GMMK keyboard and partial fix for florian@'s Microsoft
Sculpt keyboard.
bluhm [Tue, 24 Aug 2021 21:50:09 +0000 (21:50 +0000)]
Fix automatic upgrade after fetching response file with dhcp.
When the auto upgrader tried to fetch the sets, sometimes ftp did
not find any. The interface was down and had no address. As
autoconf was not cleared, the upgrade's static netstart and dhcpleased
both tried to configure the interface, which cannot work.
Disable dhcp with "ifconfig inet -autoconf" in get_responsefile()
after it is not used anymore.
OK florian@
jmc [Tue, 24 Aug 2021 20:04:28 +0000 (20:04 +0000)]
- guiness -> guinness
- heros -> heroes
- kill a dup
from tom
kettenis [Tue, 24 Aug 2021 16:18:50 +0000 (16:18 +0000)]
Fix ping group offsets.
ok jcs@
krw [Tue, 24 Aug 2021 15:36:05 +0000 (15:36 +0000)]
Add an #ifdef DEBUG/#endif chunk that dumps the entire GPT header when
printing a GPT.
No functional change outside of DEBUG.
tb [Tue, 24 Aug 2021 15:23:03 +0000 (15:23 +0000)]
Fix various read buffer overflow when printing ASN.1 strings (which are
not necessarily NUL terminated). Same as schwarze's fix in t_x509a.c r1.9.
From David Benjamin and Matt Caswell (part of the fixes in OpenSSL 1.1.1l)
ok inoguchi
florian [Tue, 24 Aug 2021 14:56:06 +0000 (14:56 +0000)]
When an interface disappears, e.g. when a usb dongle gets unplugged,
we get a RTM_IFANNOUNCE message not a RTM_IFINFO message.
Handle this message to not accumulate "unknown" interfaces.
While here fix a bug where we would remove an interface only in the
engine process but not in the frontend when an interfaces gets
unplugged while we process a RTM_IFINFO message for it.
OK benno
florian [Tue, 24 Aug 2021 14:54:02 +0000 (14:54 +0000)]
When an interface disappears, e.g. when a usb dongle gets unplugged,
we get a RTM_IFANNOUNCE message not a RTM_IFINFO message.
Handle this message to not accumulate "unknown" interfaces.
OK benno
jmc [Tue, 24 Aug 2021 13:53:21 +0000 (13:53 +0000)]
use Pa for resolv.conf.tail, since there is no longer a man page
to Xr;
jmc [Tue, 24 Aug 2021 13:16:07 +0000 (13:16 +0000)]
vini vidi vici -> veni vidi vici
jmc [Tue, 24 Aug 2021 13:15:07 +0000 (13:15 +0000)]
make SYNOPSIS match usage to indicate -l is optional in:
swapctl [[-l] | -s] [-k]
from martin vahlensieck
krw [Tue, 24 Aug 2021 12:55:06 +0000 (12:55 +0000)]
A couple more Capt. Obvious comments can go.
krw [Tue, 24 Aug 2021 12:34:04 +0000 (12:34 +0000)]
Trim leading/trailing whitespace from -e input to make command
parsing more robust (e.g. 'edit 0 ' is now accepted) and strict
(e.g. 'reinit gptx' is now rejected).
Input which may want that whitespace is not trimmed (e.g. GPT
partition names).
Use consistent definition of whitespace corresponding to that
used by isspace().
patrick [Tue, 24 Aug 2021 11:44:30 +0000 (11:44 +0000)]
Fix compilation with debug enabled.
ok kettenis@
anton [Tue, 24 Aug 2021 10:53:43 +0000 (10:53 +0000)]
Some consumer control descriptor reports uses an array of usages instead
of enumerating all supported ones. This representation is more compact
as all supported usages are given by the array min and max boundaries.
In enumerating mode, the interrupt report has one level indirection as
it includes the bit offset of the usage requiring the driver to map bits
to usages in order to resolve the key press.
In array mode, the interrupt report includes the usage without any
indirection, removing the need map bits to usages.
ucc(4) can now operate either in enumerating or array mode depending on
the descriptor report. This should make more keyboards usable.
Thanks to Alessandro De Laurenzis <just22 at atlantide dot mooo dot com>
for testing.
benno [Tue, 24 Aug 2021 10:07:30 +0000 (10:07 +0000)]
fix outdated comments, from Emil Engler, thanks.
florian [Tue, 24 Aug 2021 07:30:32 +0000 (07:30 +0000)]
We no longer have resolv.conf.tail.
From Scott Bennett, thanks!
florian [Mon, 23 Aug 2021 18:22:56 +0000 (18:22 +0000)]
Say which read failed, helps debugging.
florian [Mon, 23 Aug 2021 18:21:48 +0000 (18:21 +0000)]
We don't have a config file on the ramdisks; prevents a warning.
florian [Mon, 23 Aug 2021 18:09:05 +0000 (18:09 +0000)]
Since we have a config file now we should Xr its manpage.
From Scott Bennett, thanks!
anton [Mon, 23 Aug 2021 17:50:26 +0000 (17:50 +0000)]
I missed that wskbd_rawinput() is hidden behind WSDISPLAY_COMPAT_RAWKBD
as discovered by deraadt@; should hopefully make ucc(4) work on alpha.
nicm [Mon, 23 Aug 2021 17:05:43 +0000 (17:05 +0000)]
args_make_commands_now needs to take an extra reference to the returned
command list since it will be freed already.
nicm [Mon, 23 Aug 2021 12:33:55 +0000 (12:33 +0000)]
Move command argument parsing common functions and don't bother to parse
again if given a command rather than a string.
nicm [Mon, 23 Aug 2021 11:48:21 +0000 (11:48 +0000)]
Key bindings steal a reference to the command instead of adding their
own, it was correct not to add a reference when parsing, but the
bind-key then needs to add one.
nicm [Mon, 23 Aug 2021 11:08:26 +0000 (11:08 +0000)]
Revert one of previous, for some reason it is being freed.
nicm [Mon, 23 Aug 2021 11:04:21 +0000 (11:04 +0000)]
Fix a few memory leaks.
stsp [Mon, 23 Aug 2021 08:59:31 +0000 (08:59 +0000)]
Fix the initial length check in iwx_fill_probe_req() to match iwm(4).
Patch by zxystd from OpenIntelWireless.
nicm [Mon, 23 Aug 2021 08:17:41 +0000 (08:17 +0000)]
Limit width and height to tty correctly, GitHub issue 2843.
nicm [Sun, 22 Aug 2021 15:33:14 +0000 (15:33 +0000)]
Fix handling of leading #s when working out width.
nicm [Sun, 22 Aug 2021 13:48:29 +0000 (13:48 +0000)]
Do not double free expanded path in source-file, also remove some
unnecessary assignments.
nicm [Sun, 22 Aug 2021 13:00:28 +0000 (13:00 +0000)]
Insert alias in the right place, GitHub issue 2842.
anton [Sun, 22 Aug 2021 07:20:40 +0000 (07:20 +0000)]
Since the raw keymap already has a capacity of holding all present keys,
use it as a lookup table using the bit as the index. Removes the need to
linearly scan the same keymap during handling of a key press, not that
performance matters here since the length of the keymap is small but the
code gets a bit simpler and one struct becomes redundant.
While here, fix two incorrect conditionals in ucc_parse_hid() which
compared two different quantities.
deraadt [Sun, 22 Aug 2021 06:26:28 +0000 (06:26 +0000)]
ucc also fails to work here, because there is no wskbd_rawinput
nicm [Sat, 21 Aug 2021 20:57:52 +0000 (20:57 +0000)]
Free value properly.
nicm [Sat, 21 Aug 2021 20:46:43 +0000 (20:46 +0000)]
Preserve argument type in command and convert to string on demand.
nicm [Sat, 21 Aug 2021 18:39:07 +0000 (18:39 +0000)]
Pass typed arguments out of the parser into the arguments list and let
it convert them into strings.
jmc [Sat, 21 Aug 2021 18:28:52 +0000 (18:28 +0000)]
ioc(4) disappeared with sgi removal...
jmc [Sat, 21 Aug 2021 18:18:05 +0000 (18:18 +0000)]
escape two instances of the word "An" in Rs/Re blocks: although mandoc
can handle it, groff does not like it;
nicm [Sat, 21 Aug 2021 17:41:19 +0000 (17:41 +0000)]
Use new syntax for default key bindings.
nicm [Sat, 21 Aug 2021 17:25:32 +0000 (17:25 +0000)]
Stop caring about empty commands, just treat as a null command.
deraadt [Sat, 21 Aug 2021 14:46:25 +0000 (14:46 +0000)]
octeon has no wskbd, so ucc cannot link. the files.usb parts should have
handled this, but they don't. disable until this is revisited.
nicm [Sat, 21 Aug 2021 14:10:08 +0000 (14:10 +0000)]
Remove some members of struct cmd which are no longer used.
nicm [Sat, 21 Aug 2021 14:06:17 +0000 (14:06 +0000)]
Preserve command group when moving temporary list to current list being
buit.
nicm [Sat, 21 Aug 2021 10:28:05 +0000 (10:28 +0000)]
Rename a member to match what it will be in future.
jmc [Sat, 21 Aug 2021 10:27:10 +0000 (10:27 +0000)]
make the description for ucc match exactly;
nicm [Sat, 21 Aug 2021 10:22:38 +0000 (10:22 +0000)]
Add args parsing callback for some future work, currently unused.
nicm [Sat, 21 Aug 2021 08:44:59 +0000 (08:44 +0000)]
Wrap command argument definitions in their own struct.
anton [Sat, 21 Aug 2021 06:52:52 +0000 (06:52 +0000)]
fix indent in previous
gkoehler [Sat, 21 Aug 2021 03:00:02 +0000 (03:00 +0000)]
Switch macppc to ld.lld
Add powerpc to LLD_ARCH. Remove -Wl,-relax flag; ld.bfd needed it,
but ld.lld can't take this flag.
To avoid linker errors on macppc, you need a snapshot where
/usr/bin/ld is LLD.
ok kettenis@ deraadt@
deraadt [Sat, 21 Aug 2021 02:43:35 +0000 (02:43 +0000)]
refactor to resolve unused variable on non-WSDISPLAY_COMPAT_RAWKBD arch
nicm [Fri, 20 Aug 2021 20:08:30 +0000 (20:08 +0000)]
A couple more spacing fixes.
nicm [Fri, 20 Aug 2021 20:04:22 +0000 (20:04 +0000)]
Spacing tweaks.
nicm [Fri, 20 Aug 2021 19:50:16 +0000 (19:50 +0000)]
Hide struct args behind a couple of accessor functions.
nicm [Fri, 20 Aug 2021 19:34:51 +0000 (19:34 +0000)]
Add a couple of const and fix some warnings.
nicm [Fri, 20 Aug 2021 19:08:36 +0000 (19:08 +0000)]
Remove some unnecessary blank lines.
nicm [Fri, 20 Aug 2021 18:59:53 +0000 (18:59 +0000)]
Expose args_value struct (will be needed soon) and add some missing frees.
nicm [Fri, 20 Aug 2021 17:53:54 +0000 (17:53 +0000)]
Add a way to create an empty arguments set.
nicm [Fri, 20 Aug 2021 17:50:42 +0000 (17:50 +0000)]
Remove stray spaces after function names.
nicm [Fri, 20 Aug 2021 17:36:03 +0000 (17:36 +0000)]
Fill colour palette correctly from option for new panes, GitHub issue
2831.
nicm [Fri, 20 Aug 2021 09:06:26 +0000 (09:06 +0000)]
Actually parse contents of {} as a command and then convert to a string
instead of just copying arguments around as strings.
nicm [Fri, 20 Aug 2021 06:30:57 +0000 (06:30 +0000)]
Add a helper function for actually parsing the command.
anton [Fri, 20 Aug 2021 05:26:25 +0000 (05:26 +0000)]
sync
anton [Fri, 20 Aug 2021 05:25:23 +0000 (05:25 +0000)]
add ucc(4) manual, looks good to jmc@