schwarze [Sun, 11 Jun 2017 19:36:31 +0000 (19:36 +0000)]
Style message about legacy man(7) date format in mdoc(7) documents
and operating system dependent messages about missing or unexpected
Mdocdate; inspired by mdoclint(1).
jmc [Sun, 11 Jun 2017 18:56:09 +0000 (18:56 +0000)]
request -> promises; from scott cheloha
awolk [Sun, 11 Jun 2017 17:32:19 +0000 (17:32 +0000)]
usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)
Brought to attention by BlackFrog on #openbsd-daily
OK deraadt@
schwarze [Sun, 11 Jun 2017 17:16:36 +0000 (17:16 +0000)]
style message about missing .Fn markup; inspired by mdoclint
schwarze [Sun, 11 Jun 2017 17:06:27 +0000 (17:06 +0000)]
missing .Fn macros; found with mandoc -Tlint
schwarze [Sun, 11 Jun 2017 16:58:49 +0000 (16:58 +0000)]
missing .Fn markup for main(); found with mandoc -Tlint
schwarze [Sun, 11 Jun 2017 16:43:18 +0000 (16:43 +0000)]
Add missing .Fn markup to in() and out(); found with mandoc -Tlint.
Delete useless \*(Gt and \*(Lt while here.
tb [Sun, 11 Jun 2017 14:38:52 +0000 (14:38 +0000)]
Continue the flattening of the pledge logic started in r1.184 and place
a blank space somewhere else.
suggested by and ok jsing
schwarze [Sun, 11 Jun 2017 14:10:24 +0000 (14:10 +0000)]
Do not issue the message "no blank before trailing delimiter" for .No.
In practice, that message only matters inside .Bf, and even there, it
can occasionally be a false positive. In all other cases, it usually
is a false positive, so it is better to drop it outright.
Suggested by jmc@.
schwarze [Sun, 11 Jun 2017 14:03:46 +0000 (14:03 +0000)]
make two macros more semantic
tb [Sun, 11 Jun 2017 10:53:07 +0000 (10:53 +0000)]
Simple style(9) fixes from Juuso Lapinlampi, mostly whitespace and
omitting parentheses in return statements. Binary change because of
return instead of exit(3) from main and because help() is now __dead.
ok awolk
visa [Sun, 11 Jun 2017 10:01:23 +0000 (10:01 +0000)]
Define register_splx_handler() in one place.
visa [Sun, 11 Jun 2017 03:35:30 +0000 (03:35 +0000)]
Fix TLB size computation on OCTEON II and III. The CPUs have utilized
the whole TLB space even before this. However, TLB initialization on
boot and TLB flush on ASID wraparound have been incomplete. These have
caused crashes of processes.
visa [Sun, 11 Jun 2017 03:03:05 +0000 (03:03 +0000)]
Add a memory barrier to ensure that stores become visible
in a proper order.
deraadt [Sun, 11 Jun 2017 02:06:36 +0000 (02:06 +0000)]
integer overflow for two range checks
fix from C Turt, ok miod
tb [Sat, 10 Jun 2017 18:14:10 +0000 (18:14 +0000)]
If -P and -c were given, a second pledge call tried to add "rpath" to the
first pledge promises, so nc exited with EPERM. To fix this, merge the
pledge of the Pflag && usetls case into the first pledge block. This
allows us to get rid of the second pledge block and thus to simplify the
logic a bit. While there, add a missing blank to an error string.
Joint effort by the #openbsd-daily code reading group, problem found and
initial patch by <rain1 openmailbox org>.
ok awolk
krw [Sat, 10 Jun 2017 18:03:50 +0000 (18:03 +0000)]
Nuke unused field bootp_policy and associated enum{}.
krw [Sat, 10 Jun 2017 17:56:29 +0000 (17:56 +0000)]
Nuke unused global warnings_occurred.
schwarze [Sat, 10 Jun 2017 16:53:58 +0000 (16:53 +0000)]
Reduce false positives for the "no blank before trailing delimiter" message.
This brings us down to one false positive for about every 18 pages.
schwarze [Sat, 10 Jun 2017 16:32:08 +0000 (16:32 +0000)]
minor markup simplifications
schwarze [Sat, 10 Jun 2017 16:00:27 +0000 (16:00 +0000)]
improve semantic markup for __attribute__
schwarze [Sat, 10 Jun 2017 15:39:43 +0000 (15:39 +0000)]
missing blank before full stop, found with mandoc -Tlint
schwarze [Sat, 10 Jun 2017 14:54:42 +0000 (14:54 +0000)]
add missing blanks before several delimiters; found with mandoc -Tlint
schwarze [Sat, 10 Jun 2017 14:38:29 +0000 (14:38 +0000)]
missing space before trailing punctuation; found with mandoc -Tlint
schwarze [Sat, 10 Jun 2017 14:31:59 +0000 (14:31 +0000)]
remove lots of bogus escaping, some of which even broke the output;
found with mandoc -Tlint
schwarze [Sat, 10 Jun 2017 14:15:52 +0000 (14:15 +0000)]
fix imprecise .Fa markup; found with mandoc -Tlint
schwarze [Sat, 10 Jun 2017 14:07:23 +0000 (14:07 +0000)]
Fix broken markup of function pointer invocations; found
with mandoc -Tlint. While here, delete .Tn macros.
schwarze [Sat, 10 Jun 2017 13:58:59 +0000 (13:58 +0000)]
fix broken markup of callback arguments; found with mandoc -Tlint
schwarze [Sat, 10 Jun 2017 13:31:45 +0000 (13:31 +0000)]
Fix broken escaping: "\." is almost never what you want; found with
mandoc -Tlint. While here, make macro usage more consistent.
schwarze [Sat, 10 Jun 2017 13:24:03 +0000 (13:24 +0000)]
fix a sentence that used unusual terminology, the wrong macro,
and broken delimiter syntax; found with mandoc -Tlint
schwarze [Sat, 10 Jun 2017 13:10:52 +0000 (13:10 +0000)]
repair broken markup of callback argument; found with mandoc -Tlint
kevlo [Sat, 10 Jun 2017 12:58:37 +0000 (12:58 +0000)]
Pass M_CANFAIL to malloc(9) calls which use M_WAITOK but are tested
for failure.
ok armani@
aoyama [Sat, 10 Jun 2017 12:23:00 +0000 (12:23 +0000)]
Use software interrupt to process TX/RX data between sio and tty(4)
layer.
This is a straightforwad port of current NetBSD/luna68k implementation
by Izumi Tsutsui. Tested on both LUNA-88K and LUNA-88K2.
bluhm [Sat, 10 Jun 2017 11:28:30 +0000 (11:28 +0000)]
Report processes that were killed due to pledge or memory access
violations in the daily mail.
OK millert@ jmc@
espie [Sat, 10 Jun 2017 10:13:10 +0000 (10:13 +0000)]
perl(1)'s ...
espie [Sat, 10 Jun 2017 10:12:06 +0000 (10:12 +0000)]
use mandoc annotations for flags and such
akfaew [Sat, 10 Jun 2017 06:52:28 +0000 (06:52 +0000)]
Don't describe AppleTalk's output format and bugs.
OK claudio@
jmc@ doesn't object
djm [Sat, 10 Jun 2017 06:36:46 +0000 (06:36 +0000)]
print '?' instead of incorrect link count (that the protocol doesn't
provide) for remote listings. bz#2710 ok dtucker@
djm [Sat, 10 Jun 2017 06:33:34 +0000 (06:33 +0000)]
implement sorting for globbed ls; bz#2649 ok dtucker@
schwarze [Sat, 10 Jun 2017 01:48:31 +0000 (01:48 +0000)]
style message about missing blank before trailing delimiter;
inspired by mdoclint(1), and jmc@ considers it useful
schwarze [Sat, 10 Jun 2017 01:27:44 +0000 (01:27 +0000)]
do not break the line between Bsx/Bx/Fx/Nx/Ox/Dx and its arguments
mikeb [Fri, 9 Jun 2017 20:38:48 +0000 (20:38 +0000)]
Fill RX ring during init and bail early on send if OACTIVE is set
or IFF_RUNNING is not.
sashan [Fri, 9 Jun 2017 17:43:06 +0000 (17:43 +0000)]
- pfsync_input() must grab PF_LOCK
reported and patch tested by Hrvoje Popovski
O.K. bluhm@
tedu [Fri, 9 Jun 2017 16:46:57 +0000 (16:46 +0000)]
mention that the config file is created at first run, since it doesn't
exist on a default install (thus making it impossible to read and study)
nicm [Fri, 9 Jun 2017 16:01:39 +0000 (16:01 +0000)]
Extend filters (f key) to buffer and client mode and add -f flag to
specify to command.
fcambus [Fri, 9 Jun 2017 15:32:40 +0000 (15:32 +0000)]
Correct number of players, the program enforces a range from 2 to 9.
OK tb@, jmc@
nicm [Fri, 9 Jun 2017 15:29:15 +0000 (15:29 +0000)]
Add -O option to choose-* to set initial sort order.
nicm [Fri, 9 Jun 2017 15:17:20 +0000 (15:17 +0000)]
Default sort for buffer mode should be time not name.
mikeb [Fri, 9 Jun 2017 14:36:43 +0000 (14:36 +0000)]
Remove a WAITOK that has sneaked in
mikeb [Fri, 9 Jun 2017 14:34:10 +0000 (14:34 +0000)]
Convert to ifq_dequeue and perform m_defrag if the mbuf doesn't fit
With suggestions from and OK dlg
nicm [Fri, 9 Jun 2017 14:00:46 +0000 (14:00 +0000)]
Use brackets around prompts which looks better and matches the other modes.
stsp [Fri, 9 Jun 2017 13:47:26 +0000 (13:47 +0000)]
Introduce iwm_nic_assert_locked() to verify that the driver has correctly
requested MAC access before accessing certain registers, as required
by the hardware.
Use it to assert that hardware is still in an accessible state before
reading or writing such a register. For now, panic if that check fails.
The long term goal is to make this a non-fatal error and handle it properly
in all code paths that end up reading or writing such a register.
Fix a missing NIC lock on 8000 hardware, found by this new assertion.
Also, grab the NIC lock early during hardware init and keep it until init
is done. The previous code relinquished and reacquired the NIC lock several
times during the init sequence. It seems this is what was causing some random
errors when the interface was brought up, such as "could not enable Tx queue",
"could not add aux station", and "could not add phy context".
For some reason, bsd.rd kernels were suffering particularly hard from such
problems, to the point where some machines could not be upgraded over iwm(4).
This change does not eliminate such problems entirely but is a step forward.
Prodded by deraadt@
This change has already been in snaps for a while.
stsp [Fri, 9 Jun 2017 13:46:15 +0000 (13:46 +0000)]
Fix the resume code path in iwm(4) to no longer call iwm_stop() before
initializing the hardware. Prevents "acquiring device failed" messages
during resume. Also, start the hardware up in DVACT_RESUME already and
verify that it has started by the time we reach DVACT_WAKEUP, before
scheduling the iwm_init_task which loads firmware etc.
With help from deraadt@
test & ok tb@
florian [Fri, 9 Jun 2017 13:31:03 +0000 (13:31 +0000)]
If we receive a router solicitation with a source link-layer address
option respond with a unicast advertisement. This improves air time on
wireless networks and reduces energy consumption on battery powered
devices. For details see RFC 7772 "Reducing Energy Consumption of
Router Advertisements" aka BCP 202.
Input & OK bluhm@
mpi [Fri, 9 Jun 2017 12:56:43 +0000 (12:56 +0000)]
Replace rtrequest(RTM_DELETE...) rtrequest_delete() and do not even
try to remove a route from the table if it is and invalid cache.
This is a step towards decoupling code dealing with userland and kernel
inserted routes.
ok bluhm@
nicm [Fri, 9 Jun 2017 09:21:24 +0000 (09:21 +0000)]
Add a hook when the clipboard is set.
ajacoutot [Fri, 9 Jun 2017 07:37:38 +0000 (07:37 +0000)]
Drop uneeded return from rollback_patch().
ajacoutot [Fri, 9 Jun 2017 07:32:26 +0000 (07:32 +0000)]
/etc/mtree/BSD.x11.dist is part of base, not X; so check for
/var/sysmerge/xetc.tgz to detect whether we have the x sets installed.
djm [Fri, 9 Jun 2017 06:47:13 +0000 (06:47 +0000)]
return failure rather than fatal() for more cases during mux
negotiations. Causes the session to fall back to a non-mux connection
if they occur. bz#2707 ok dtucker@
djm [Fri, 9 Jun 2017 06:43:01 +0000 (06:43 +0000)]
in description of public key authentication, mention that the server
will send debug messages to the client for some error conditions
after authentication has completed. bz#2709 ok dtucker
djm [Fri, 9 Jun 2017 06:40:24 +0000 (06:40 +0000)]
better translate libcrypto errors by looking deeper in the accursed
error stack for codes that indicate the wrong passphrase was supplied
for a PEM key. bz#2699 ok dtucker@
dtucker [Fri, 9 Jun 2017 04:40:04 +0000 (04:40 +0000)]
Add comments referring to the relevant RFC sections for rekeying
behaviour.
dlg [Fri, 9 Jun 2017 01:39:07 +0000 (01:39 +0000)]
turns out the case on 802.1 suffixes is significant. fix 802.1Q
pointed out by jsg@
dlg [Fri, 9 Jun 2017 01:36:05 +0000 (01:36 +0000)]
turns out the case of 802.1 suffixes is significant. fix up 802.1X and Q.
pointed out by jsg@
aoyama [Thu, 8 Jun 2017 21:30:26 +0000 (21:30 +0000)]
Add a missing header file.
ok deraadt@
patrick [Thu, 8 Jun 2017 19:40:49 +0000 (19:40 +0000)]
Remove esym (.data) patching. Thanks to Mark we stopped requiring this
and with the random-order kernel we shouldn't be doing that anyway.
ok kettenis@
schwarze [Thu, 8 Jun 2017 19:35:34 +0000 (19:35 +0000)]
Properly reinitialize roffce_node between parses,
or this may crash with use-after-free in makewhatis(8);
reported by jmc@, thanks!
tedu [Thu, 8 Jun 2017 19:23:39 +0000 (19:23 +0000)]
remove the timeslot code, it was only for now deleted T1 devices.
ok sthen
patrick [Thu, 8 Jun 2017 18:33:08 +0000 (18:33 +0000)]
Pass CC and CXX to make depend as well. As soon as we support
dependencies in the clang makefiles we need to make sure to use
a compiler that supports C++11.
schwarze [Thu, 8 Jun 2017 18:25:16 +0000 (18:25 +0000)]
delete -e and -l, now covered by mandoc; OK jmc@ wiz@
schwarze [Thu, 8 Jun 2017 18:11:15 +0000 (18:11 +0000)]
Implement w layout specifier (minimum column width).
Improve width calculation of text blocks.
Reduces the groff/mandoc diff in Base+Xenocara by about 800 lines.
bluhm [Thu, 8 Jun 2017 17:33:21 +0000 (17:33 +0000)]
Link lastcomm regress to build.
bluhm [Thu, 8 Jun 2017 17:29:33 +0000 (17:29 +0000)]
Start with a clean /var/account/acct accounting file and turn on
process accounting with accton(8). Each test executes a command
with a unique name and checks the flags in the lastcomm(1) output.
Run tests with fork, su, core, xsig, pledge, trap accounting.
bluhm [Thu, 8 Jun 2017 17:14:02 +0000 (17:14 +0000)]
ASLR, W^X, and guard pages trigger processor traps that result in
SIGILL, SIGBUS, SIGSEGV signals. Make such memory violations visible
in lastcomm(1). This also works if a programm tries to hide them
with a signal handler. Manual kill -SEGV does not generate false
positives.
OK deraadt@
millert [Thu, 8 Jun 2017 17:13:39 +0000 (17:13 +0000)]
update permissions info to match recent changes
millert [Thu, 8 Jun 2017 16:23:39 +0000 (16:23 +0000)]
Add logging for when we find a non-file in the at spool that was
a file when we scanned the at spool earlier.
henning [Thu, 8 Jun 2017 15:39:38 +0000 (15:39 +0000)]
clarify set prio: the second prio given applies to
1) TCP ACKs
2) packets with ToS=lowdelay
and not TCP ACKs that have ToS=lowdelay
confusion discovered during bsdcan pf tutorial
bluhm [Thu, 8 Jun 2017 14:38:35 +0000 (14:38 +0000)]
Start syslogd with -rr. With different timing the order of messages
changed. Then a "last message repeated" confused the test.
mpi [Thu, 8 Jun 2017 13:28:03 +0000 (13:28 +0000)]
Notify userland when a new ND is reachable.
The same notification is already present in ARP.
From Jan Klemkow, ok bluhm@
schwarze [Thu, 8 Jun 2017 12:54:40 +0000 (12:54 +0000)]
make the internal a2roffsu() interface more powerful by returning
a pointer to the end of the parsed data, making it easier to
parse subsequent bytes
tb [Thu, 8 Jun 2017 12:37:14 +0000 (12:37 +0000)]
wrec.org is dead. Use working links instead.
patch from jj, found by "Norrland" on icb. Thanks!
visa [Thu, 8 Jun 2017 12:11:46 +0000 (12:11 +0000)]
Wrap startup code with .ent and .end for proper disassembly.
visa [Thu, 8 Jun 2017 12:02:52 +0000 (12:02 +0000)]
Move loongson/octeon/sgi unmap_startup() under arch/mips64.
visa [Thu, 8 Jun 2017 11:47:24 +0000 (11:47 +0000)]
Split early startup code out of locore.S into locore0.S. Adjust link
run so that this locore0.o is always at the start of the executable.
But randomize the link order of all other .o files in the kernel, so
that their exec/rodata/data/bss segments land all over the place.
Late during kernel boot, smash the startup code with traps so that
it does not point to the other randomly placed code. It has be smashed,
because sgi runs in the kseg0 or xkphys space.
As a result, the internal layout of every newly build bsd kernel is
different from past kernels. Internal relative offsets are not known
to an outside attacker.
Ramdisk kernels cannot be compiled like this, because they are gzip'd.
When the internal pointer references change, the compression dictionary
bloats and results in poorer compression.
jsg [Thu, 8 Jun 2017 11:45:44 +0000 (11:45 +0000)]
Invoke openssl with -passin file rather than -key in ca_revoke().
From Andrei-Marius Radu via sthen@
visa [Thu, 8 Jun 2017 11:44:00 +0000 (11:44 +0000)]
Split early startup code out of locore.S into locore0.S. Adjust link
run so that this locore0.o is always at the start of the executable.
But randomize the link order of all other .o files in the kernel, so
that their exec/rodata/data/bss segments land all over the place.
Late during kernel boot, smash the startup code with traps so that
it does not point to the other randomly placed code. It has be smashed,
because loongson runs in the kseg0 space.
As a result, the internal layout of every newly build bsd kernel is
different from past kernels. Internal relative offsets are not known
to an outside attacker.
Ramdisk kernels cannot be compiled like this, because they are gzip'd.
When the internal pointer references change, the compression dictionary
bloats and results in poorer compression.
nicm [Thu, 8 Jun 2017 07:48:04 +0000 (07:48 +0000)]
Add size to client descriptions in list, suggested by Greg Hurrell.
deraadt [Thu, 8 Jun 2017 05:35:23 +0000 (05:35 +0000)]
Split early startup code out of locore.S into locore0.S. Adjust link
run so that this locore0.o is always at the start of the executable.
But randomize the link order of all other .o files in the kernel, so
that their exec/rodata/data/bss segments land all over the place.
I haven't worked on the unmap/smashing of the startup code yet.
dlg [Thu, 8 Jun 2017 03:37:25 +0000 (03:37 +0000)]
remove the _rb_color prototype in RBT, it's unused/unimplimented
dlg [Thu, 8 Jun 2017 03:30:52 +0000 (03:30 +0000)]
make rb_n2e return a struct rb_entry *, not void *
maybe this will help prevent misassignment in the future.
dlg [Thu, 8 Jun 2017 03:22:56 +0000 (03:22 +0000)]
use unsigned long instead of caddr_t to move between nodes and entries.
this removes the need for sys/param.h. this code can be built with
only sys/tree.h, which in turn only needs sys/_null.h.
dlg [Thu, 8 Jun 2017 03:12:53 +0000 (03:12 +0000)]
add RBT_SET_LEFT, RBT_SET_RIGHT, and RBT_SET_PARENT
this are provided so an RBT and it's topology can be copied without
having to reinsert the copied nodes into a new tree.
there are two reasons RBT_LEFT/RIGHT/PARENT macros cant be used like
RB_LEFT/RIGHT/PARENT for this. firstly, RBT_LEFT and co are functions that
return a pointer value, they dont provide access to the pointer
itself for use as an lvalue that you can assign to. secondly, RBT
entries dont store pointers to other nodes, they point to the
RBT_ENTRY structures inside other nodes. this means that RBT_SET_LEFT
and co have to get an offset from the node to the RBT_ENTRY and
store that.
dlg [Thu, 8 Jun 2017 01:34:00 +0000 (01:34 +0000)]
make the gem tx path MPSAFE.
this mostly follows the pattern in ifq.h
ok jmatthew@
dlg [Thu, 8 Jun 2017 01:17:01 +0000 (01:17 +0000)]
consistently use lowercase for the 802.1 suffixes.
dlg [Thu, 8 Jun 2017 00:46:42 +0000 (00:46 +0000)]
consistently use lowercase suffixes for 802.1 things.
eg, 802.1x, 802.1q, and 802.1ad
schwarze [Thu, 8 Jun 2017 00:21:23 +0000 (00:21 +0000)]
Portable mandoc just got a warning about unknown .Lb names
which we don't want in OpenBSD, but let's keep the message table
and the manual page in sync.
millert [Wed, 7 Jun 2017 23:36:43 +0000 (23:36 +0000)]
In cron(8), require that crontab and at files in the spool be owned
by group crontab. The at(1) command now creates files owned by
group crontab, the crontab(1) command already does this.
Files in the crontab spool with parse errors are now ignored;
crontab(1) will not install a crontab file with parse errors.
The system crontab file (/etc/crontab) is not affected by this.
The required permissions on crontab files have been tightened.
Files in the cron spool must be mode 0600 (as created by crontab(1)).
The system crontab file may be readable/writable by the owner,
readable by group and readable by other. The system crontab must
be readable by the owner.
schwarze [Wed, 7 Jun 2017 23:29:31 +0000 (23:29 +0000)]
style checks related to .Er; inspired by mdoclint(1)
mlarkin [Wed, 7 Jun 2017 23:15:49 +0000 (23:15 +0000)]
vmctl: change default "vmctl console" (cu) baud rate to 115200. Not
strictly needed but matches the previous baudrate diff committed earlier
to vmd.
ok deraadt, phessler
jmc [Wed, 7 Jun 2017 21:47:07 +0000 (21:47 +0000)]
use the same formatting for vlan as the rest of the page; ok dlg