jsg [Sun, 2 Jan 2022 23:05:15 +0000 (23:05 +0000)]
Mac -> MAC
jsg [Sun, 2 Jan 2022 22:36:03 +0000 (22:36 +0000)]
spelling
ok jmc@ reads ok tb@
tb [Sun, 2 Jan 2022 21:01:20 +0000 (21:01 +0000)]
immediatly -> immediately
tb [Sun, 2 Jan 2022 21:00:37 +0000 (21:00 +0000)]
fix strange indentation in code example
kettenis [Sun, 2 Jan 2022 20:10:24 +0000 (20:10 +0000)]
Grab kernel lock when required.
ok patrick@
kettenis [Sun, 2 Jan 2022 20:00:21 +0000 (20:00 +0000)]
Don't use != 0 to check whether a pointer is non-NULL.
krw [Sun, 2 Jan 2022 17:26:14 +0000 (17:26 +0000)]
Stop writing big-endian checksums into the little-endian GPT
header fields gh_csum and gh_part_csum.
Constrain kernel to accepting only correct little-endian
checksums.
Temporarily allow fdisk(8) to read either endian GPTs so that
big-endian GPTs can be made correct by a simple 'fdisk -e' &&
'w'.
Fixes inter-architecture, inter-OS GPT portability and GPT
fdisk(8) on big-endian architectures. Broken since initial GPT
implementation.
Suggestions and ok kettenis@
jsg [Sun, 2 Jan 2022 06:16:08 +0000 (06:16 +0000)]
priviledged -> privileged
jsg [Sun, 2 Jan 2022 05:59:53 +0000 (05:59 +0000)]
priveledged -> privileged
jsg [Sun, 2 Jan 2022 05:49:50 +0000 (05:49 +0000)]
convension -> convention
jsg [Sun, 2 Jan 2022 05:40:06 +0000 (05:40 +0000)]
Nummber -> Number
jsg [Sun, 2 Jan 2022 05:37:19 +0000 (05:37 +0000)]
numers -> numbers
jsg [Sun, 2 Jan 2022 05:32:00 +0000 (05:32 +0000)]
contoller -> controller
jsg [Sun, 2 Jan 2022 05:30:07 +0000 (05:30 +0000)]
phsyaddr -> physaddr
jsg [Sun, 2 Jan 2022 05:00:28 +0000 (05:00 +0000)]
spelling
jsg [Sun, 2 Jan 2022 03:41:08 +0000 (03:41 +0000)]
addres -> address
jsg [Sun, 2 Jan 2022 02:31:08 +0000 (02:31 +0000)]
unhandle -> unhandled
jsg [Sun, 2 Jan 2022 02:26:50 +0000 (02:26 +0000)]
slignment -> alignment
jsg [Sun, 2 Jan 2022 02:13:33 +0000 (02:13 +0000)]
preferense -> preference
jsg [Sun, 2 Jan 2022 01:59:42 +0000 (01:59 +0000)]
plaform -> platform
guenther [Sun, 2 Jan 2022 01:20:25 +0000 (01:20 +0000)]
Don't use *ENTRY_NB() with END_BUILTIN(), at least yet
Problem noted by naddy@
jsg [Sun, 2 Jan 2022 01:01:04 +0000 (01:01 +0000)]
establush -> establish
guenther [Sat, 1 Jan 2022 23:47:14 +0000 (23:47 +0000)]
Add ENTRY_NB() macro for doing an ASM function entry without setting
the binding to global (NB == "no binding"), as clang 13 is now
warning about changing the binding from global to weak.
This first pass does amd64 and sparc64 and pulls DEFS.h out of the
per-arch directory to a common directory; others to follow
ok kettenis@
kettenis [Sat, 1 Jan 2022 18:54:09 +0000 (18:54 +0000)]
Revert the hack for Apple M1 systems.
ok patrick@
kettenis [Sat, 1 Jan 2022 18:52:36 +0000 (18:52 +0000)]
Rewrite the kernel FPU handling code. The new code saves the FPU state
in cpu_switch() instead of at the kernel edge and gets rid of the FPU
state tracking in struct cpu_info and struct pcb. This fixes the random
crashes seen with SMP kernels on Apple M1.
ok patrick@
patrick [Sat, 1 Jan 2022 18:52:26 +0000 (18:52 +0000)]
Use correct defines for random seed magic/length.
Spotted by Andreas Schnebinger
cheloha [Sat, 1 Jan 2022 18:20:52 +0000 (18:20 +0000)]
uniq(1): miscellaneous style(9)-ish stuff
- Include what you use:
+ Add <strings.h> for strcasecmp(3).
+ Drop <errno.h>, unused.
- Pull the "errstr" declaration out of the getopt(3) loop
up to the top of main().
- Align the strtonum(3) error messages with the argument
names in the uniq.1 manpage and the usage string. They
are referred to as "chars" and "fields".
- Trim some whitespace.
- Return from main() instead of exit(3).
- De-(void) fprintf(3).
- Prefer getprogname(3) to __progname.
cheloha [Sat, 1 Jan 2022 17:44:18 +0000 (17:44 +0000)]
uniq(1): bump numchars, numfields from int to long long
Also bump repeats from int to unsigned long long.
While here, don't cast the result of strtonum() and unwrap some lines.
kettenis [Sat, 1 Jan 2022 14:18:39 +0000 (14:18 +0000)]
Remove unused function prototype.
kettenis [Sat, 1 Jan 2022 11:45:35 +0000 (11:45 +0000)]
Add missing locking to pmap_extract(9) and pmap_unwire(9).
ok patrick@, mpi@
jsg [Sat, 1 Jan 2022 08:10:29 +0000 (08:10 +0000)]
Multiprocol -> Multiprotocol
jsg [Sat, 1 Jan 2022 08:01:27 +0000 (08:01 +0000)]
Identifiier -> Identifier
jsg [Sat, 1 Jan 2022 07:00:57 +0000 (07:00 +0000)]
copyright++;
jsg [Sat, 1 Jan 2022 05:55:06 +0000 (05:55 +0000)]
spelling
djm [Sat, 1 Jan 2022 04:18:06 +0000 (04:18 +0000)]
fix memleak in process_extension(); oss-fuzz issue #42719
jsg [Sat, 1 Jan 2022 03:59:22 +0000 (03:59 +0000)]
eascape -> escape
jsg [Sat, 1 Jan 2022 03:57:20 +0000 (03:57 +0000)]
approciate -> appropriate
jsg [Sat, 1 Jan 2022 02:44:22 +0000 (02:44 +0000)]
failured -> failed
cheloha [Sat, 1 Jan 2022 02:20:38 +0000 (02:20 +0000)]
uniq(1): freopen(3) stdin, stdout
uniq(1) defaults to stdin and stdout, has exactly one input and one
output, and permits the user to replace the default input and/or the
default output with a given file.
freopen(3) is the right idiom in this context. Get rid of file() and
the extra FILE pointers. Switch from fprintf(3) to printf(3).
While here, const the "str" argument to show().
Thread: https://marc.info/?l=openbsd-tech&m=
164078603312936&w=2
ok millert@
jsg [Sat, 1 Jan 2022 02:18:28 +0000 (02:18 +0000)]
contibutions -> contributions
jsg [Sat, 1 Jan 2022 02:06:07 +0000 (02:06 +0000)]
identfier -> identifier
jsg [Sat, 1 Jan 2022 01:55:30 +0000 (01:55 +0000)]
spelling
ok dtucker@
jsg [Fri, 31 Dec 2021 23:19:50 +0000 (23:19 +0000)]
spelling
ok ratchov@
jsg [Fri, 31 Dec 2021 22:40:40 +0000 (22:40 +0000)]
excpetions -> exceptions
jsg [Fri, 31 Dec 2021 22:38:01 +0000 (22:38 +0000)]
deafult -> default
nicm [Fri, 31 Dec 2021 11:35:49 +0000 (11:35 +0000)]
Try to turn on less-capable mouse modes when turning on more-capable, to
increase the chances we get something even if the terminal doesn't support
the one we really want. GitHub issue 3020.
jsg [Fri, 31 Dec 2021 11:24:24 +0000 (11:24 +0000)]
Interrups -> Interrupts
kettenis [Fri, 31 Dec 2021 11:21:45 +0000 (11:21 +0000)]
Add missing locking to pmap_extract(9) and pmap_unwire(9).
ok patrick@, mpi@
jsg [Fri, 31 Dec 2021 10:44:05 +0000 (10:44 +0000)]
avaialble -> available
jsg [Fri, 31 Dec 2021 10:40:30 +0000 (10:40 +0000)]
specifed -> specified
patrick [Fri, 31 Dec 2021 09:24:18 +0000 (09:24 +0000)]
Newer Apple firmware on chipsets without a hardware RNG require the host to
provide a buffer of random bytes to the device on initialization.
jmatthew [Fri, 31 Dec 2021 08:15:47 +0000 (08:15 +0000)]
Fix up handling of IFF_ALLMULTI and call uaq_iff() from uaq_init().
from Brad
dv [Thu, 30 Dec 2021 20:51:34 +0000 (20:51 +0000)]
typo: p5-Socket-SSL -> p5-IO-Socket-SSL
ok kn@
dv [Thu, 30 Dec 2021 20:38:43 +0000 (20:38 +0000)]
relayd(8): don't create sockets between CAs and RELAYs.
CA and RELAY process types don't need to communicate with other CA
or RELAY processes respectively, so don't create and distribute ipc
socketpairs.
Tested by and ok denis@
kevlo [Thu, 30 Dec 2021 15:09:49 +0000 (15:09 +0000)]
Add Xiaomi MiniWif to list of devices supported by mtw(4).
Works for me on amd64.
ok hastings@
anton [Thu, 30 Dec 2021 14:25:39 +0000 (14:25 +0000)]
Use a distinct variable while iterating the list of existing devices.
ok mvs@
Reported-by: syzbot+e2d1df67f742a5a47938@syzkaller.appspotmail.com
Reported-by: syzbot+72298724beda82ec8e7f@syzkaller.appspotmail.com
guenther [Thu, 30 Dec 2021 08:39:19 +0000 (08:39 +0000)]
Sync from libc: Use _MAX_PAGE_SHIFT, rather than #ifdef mips64
ok otto@
ajacoutot [Thu, 30 Dec 2021 08:14:29 +0000 (08:14 +0000)]
Sync rcexec with reality.
claudio [Thu, 30 Dec 2021 08:12:23 +0000 (08:12 +0000)]
Add back support for -B net -b bsd.rd which emulates a PXE install and
results in an autoinstall. This can be used to quickly create new OpenBSD
installs.
OK dv@
anton [Thu, 30 Dec 2021 06:55:37 +0000 (06:55 +0000)]
minor tweak
anton [Thu, 30 Dec 2021 06:55:11 +0000 (06:55 +0000)]
Prevent a double free by assigning the new keymap and corresponding size
after the allocation and initialization is done. Otherwise, a race is
possible if malloc ends up sleeping.
ok sashan@
Reported-by: syzbot+7f8224e9f1a3487caf25@syzkaller.appspotmail.com
guenther [Thu, 30 Dec 2021 04:48:13 +0000 (04:48 +0000)]
Delete dead (duplicate) test
mvs [Thu, 30 Dec 2021 00:49:41 +0000 (00:49 +0000)]
Prevent concurrent access to incomplete or dying `sc' caused by sleep
points in pppacopen() and pppacclose() paths. Use the same "sc_ready"
logic we use for 'pppx_if' structure.
Reported-by: syzbot+a7ac144b48f7f471f689@syzkaller.appspotmail.com
ok anton@ dlg@
jsg [Thu, 30 Dec 2021 00:25:41 +0000 (00:25 +0000)]
combine ifdef blocks
from Ted Bullock
tb [Wed, 29 Dec 2021 23:04:12 +0000 (23:04 +0000)]
Plug memleaks
CID 345150
tb [Wed, 29 Dec 2021 23:02:52 +0000 (23:02 +0000)]
Plug memleak
CID 345156
tb [Wed, 29 Dec 2021 23:02:00 +0000 (23:02 +0000)]
More EVP_* return value checks
CID 345152
tb [Wed, 29 Dec 2021 23:00:32 +0000 (23:00 +0000)]
Remove redundant NULL checks
CID 345154
tb [Wed, 29 Dec 2021 22:58:40 +0000 (22:58 +0000)]
Minor cleanup after EC_POINT_get_affine_coordinates() unified the
_GFp and _GF2m variants.
CID 345155
tb [Wed, 29 Dec 2021 22:56:25 +0000 (22:56 +0000)]
More return value checks for EVP_* API
CID 345159
tb [Wed, 29 Dec 2021 22:54:41 +0000 (22:54 +0000)]
Check return values of EVP_* API
CID 345158
tb [Wed, 29 Dec 2021 22:53:04 +0000 (22:53 +0000)]
knfmt makes this slightly nicer.
tb [Wed, 29 Dec 2021 22:50:30 +0000 (22:50 +0000)]
One more leak of the same kind
tb [Wed, 29 Dec 2021 22:49:23 +0000 (22:49 +0000)]
Plug memleak
CID 345160
tb [Wed, 29 Dec 2021 22:48:09 +0000 (22:48 +0000)]
Set failed in test_random_points()
CID 345141
jmc [Wed, 29 Dec 2021 21:41:28 +0000 (21:41 +0000)]
make the argument name for veb's "child-iface" consistent;
from caspar schutijser
mpi [Wed, 29 Dec 2021 20:22:06 +0000 (20:22 +0000)]
Consistently name page argument `pg'.
Reduce differences with NetBSD, no functional changes.
sdk [Wed, 29 Dec 2021 19:31:01 +0000 (19:31 +0000)]
Add regress tests for grep -A, -B and -C flags
ok otto@
patrick [Wed, 29 Dec 2021 18:48:45 +0000 (18:48 +0000)]
PHYs that we want to talk to over SGMII need to be switched into SGMII
mode for the link to go up. This is relevant on RJ45 SFPs.
ok sthen@
patrick [Wed, 29 Dec 2021 18:44:52 +0000 (18:44 +0000)]
Mention attachment and reference to acpi(4).
patrick [Wed, 29 Dec 2021 18:40:48 +0000 (18:40 +0000)]
Enable ohci(4) and ehci(4) at acpi(4).
patrick [Wed, 29 Dec 2021 18:40:19 +0000 (18:40 +0000)]
Allow ohci(4) and ehci(4) to attach to acpi(4).
ok kettenis@
patrick [Wed, 29 Dec 2021 17:52:22 +0000 (17:52 +0000)]
acpi_intr_disestablish() is available on all our ACPI platforms which
support interrupts via ACPI, so there's need for an ifdef around it.
ok kettenis@
claudio [Wed, 29 Dec 2021 11:37:57 +0000 (11:37 +0000)]
Cleanup struct entity. Remove the unneeded has_data field, the same
information can be figured out by looking at the data pointer itself.
It is NULL when there is no data and not-NULL if there is data.
OK benno@
claudio [Wed, 29 Dec 2021 11:35:23 +0000 (11:35 +0000)]
Merge multiple similar code bits together into repo_done(). Which currently
finds all repos that point to the passed backend and flushes their queues.
Also make sure that REPO_FAILED is set in cases where no sync happened and
also fall back from rrdp to rsync in any case of failure (including errors
merging the rrdp repo itself).
OK tb@
anton [Wed, 29 Dec 2021 07:16:30 +0000 (07:16 +0000)]
Ensure file descriptor send/receive is not allowed.
anton [Wed, 29 Dec 2021 07:15:13 +0000 (07:15 +0000)]
Do not allow send/receive of kcov descriptors as the file descriptor can
be kept alive longer than expected causing syzkaller to no longer being
able to enable remote coverage.
ok visa@
Reported-by: syzbot+ab2016d729cda7b0d003@syzkaller.appspotmail.com
krw [Wed, 29 Dec 2021 00:04:45 +0000 (00:04 +0000)]
Tweak some DEBUG output.
Always put '0x' prefix in front of displayed hex values,
i.e. the checksums.
Add missing letoh32() so bad endian checksum is clear.
Be consistent when displaying 'expected' and 'got' checksums,
i.e. 'expected' == calculated checksum and 'got' == checksum
found in GPT.
mvs [Wed, 29 Dec 2021 00:04:35 +0000 (00:04 +0000)]
Add unp_dispose() threads to 'unsopassgc' test.
krw [Tue, 28 Dec 2021 23:44:02 +0000 (23:44 +0000)]
Tweak some DEBUG output.
'EFI PART' reads better than "TRAP IFE" and
checksums are easier to read/compare when shown
in hex rather than decimal.
Prompted by recent GPT vs disklabel misc@ thread
concerning Rob Whitlock's problematic GPT.
dlg [Tue, 28 Dec 2021 23:13:20 +0000 (23:13 +0000)]
whitespace tweak, no functional change.
dlg [Tue, 28 Dec 2021 23:10:58 +0000 (23:10 +0000)]
it doesnt make sense to configure a vport as a span port.
dlg [Tue, 28 Dec 2021 23:10:30 +0000 (23:10 +0000)]
move away from using the M_PROTO1 flag to prevent loops with vports
if a vlan interface is configured on a vport interface, vlan(4)
will take the packet away from ether_input before the veb bridge
input handler gets to clear M_PROTO1. this leaves the flag on the
mbuf as it goes through the l3 stacks. if it goes back out a vport
into a veb, the presence of M_PROTO1 means the packet ends up getting
dropped, which is unexpected.
this diff specialises vport handling by veb even more to avoid the
problem the flag was handling. vports get their own bridge input
handler that skips veb processing completely because a packet being
received on a vport can only occur if a veb has decided to forward
it there and has already processed it. when the stack sends a packet
out a vport interface, then we do actual veb bridge input handling.
bug reported on misc@ and the fix tested by Simon Baker
tb [Tue, 28 Dec 2021 21:23:40 +0000 (21:23 +0000)]
Fix typo in comment
naddy [Tue, 28 Dec 2021 21:14:24 +0000 (21:14 +0000)]
lld: restore upstream default for --[no-]allow-shlib-undefined
ok patrick@ kettenis@
naddy [Tue, 28 Dec 2021 21:13:20 +0000 (21:13 +0000)]
lld: do not report undefined weak references in shared libraries
https://github.com/llvm/llvm-project/commit/
52bfd2c1ccd86ff813ee6df5a6700690acdd912f
This fixes an issue introduced in
D101996.
A weak reference in a shared library could be incorrectly reported if
there is another library that has a strong reference to the same symbol.
Differential Revision: https://reviews.llvm.org/
D115041
ok patrick@ kettenis@
tb [Tue, 28 Dec 2021 21:06:01 +0000 (21:06 +0000)]
Use lowercase letters for hexadecimal constants, as both jsing and I
prefer this.
tb [Tue, 28 Dec 2021 21:00:27 +0000 (21:00 +0000)]
Rewrite X509v3_addr_canonize() with new accessors
This is again a straightforward conversion and leads to something which
matches our usual style more.
ok jsing
tb [Tue, 28 Dec 2021 20:58:05 +0000 (20:58 +0000)]
Validate AFIs before sorting in X509v3_adr_canonize()
Again, we're dealing with necessarily not fully validated data here,
so a check up front seems prudent.
ok jsing
tb [Tue, 28 Dec 2021 20:50:37 +0000 (20:50 +0000)]
Rewrite/simplify X509v3_addr_is_canonical()
This is a more or less straightforward conversion using the new
IPAddressFamily accessor API. As a result, some checks have become
a bit stricter, which is only desirable here.
ok jsing