djm [Fri, 24 Apr 2015 05:26:44 +0000 (05:26 +0000)]
add ssh-agent -D to leave ssh-agent in foreground without enabling
debug mode; bz#2381 ok dtucker@
jsg [Fri, 24 Apr 2015 02:22:08 +0000 (02:22 +0000)]
Use "softintr_pic0" instead of "softintr_fakepic" when faking a
struct device so there is enough space in the buffer for a NUL and
the unit is included in the string.
discussed with deraadt and millert
deraadt [Fri, 24 Apr 2015 01:36:24 +0000 (01:36 +0000)]
2*len -> use xreallocarray()
ok djm
deraadt [Fri, 24 Apr 2015 01:36:00 +0000 (01:36 +0000)]
rename xrealloc() to xreallocarray() since it follows that form.
ok djm
millert [Thu, 23 Apr 2015 17:11:42 +0000 (17:11 +0000)]
Replace atoi() usage with strtonum(). OK deraadt@
florian [Thu, 23 Apr 2015 17:03:01 +0000 (17:03 +0000)]
We cannot log errors with relay_close() before allocating
se_log evbuffer.
(Same problem as the one just fixed in httpd(8))
OK benno
florian [Thu, 23 Apr 2015 16:59:28 +0000 (16:59 +0000)]
We cannot log errors with server_close() before allocating
clt_log evbuffer.
server_close() calls server_log() which uses ctl_log.
Crash reported by Daniel Jakots <vigdis AT chown DOT me>, thanks!
OK benno
schwarze [Thu, 23 Apr 2015 16:17:04 +0000 (16:17 +0000)]
Unify mdoc_deroff() and man_deroff() into a common function deroff().
No functional change except that for mdoc(7), it now skips leading
escape sequences just like it already did for man(7).
Escape sequences rarely occur in mdoc(7) code and if they do,
skipping them is an improvement in this context.
Minus 30 lines of code.
schwarze [Thu, 23 Apr 2015 15:35:39 +0000 (15:35 +0000)]
Get rid of two empty wrapper functions. No functional change.
mpi [Thu, 23 Apr 2015 14:42:02 +0000 (14:42 +0000)]
Fix 13 years old typo that should be responsible for the unhappiness
of UVM on PowerPC architectures by breaking pmap_is_referenced() and
friends.
ok kettenis@
dlg [Thu, 23 Apr 2015 09:56:23 +0000 (09:56 +0000)]
tedu remnants of the previous attempt to implement page zeroing in
the idle thread.
ok deraadt@
dlg [Thu, 23 Apr 2015 09:45:24 +0000 (09:45 +0000)]
replace the use of struct ifqueue in pipex with mbuf_queues.
this has a slight semantic change. previously pipex would only
process up to 128 packets on the input and output queues at a time
and would reschedule the softint if there were any left. now it
mq_delists the current set of pending packets and only processes
them. if anything is added to the queues later they'll cause the
softint to run again.
this in turn lets us deprecate sysctl_ifq since nothing uses it
anymore. because niqueues are mostly wrappers around mbuf_queues,
we can provide sysctl_mq and just #define sysctl_niq to it.
pipex bits are ok yasuoka@
deraadt [Thu, 23 Apr 2015 07:45:50 +0000 (07:45 +0000)]
use reallocarray instead of calloc; avoid the zero before infill
ok nicm
deraadt [Thu, 23 Apr 2015 06:11:19 +0000 (06:11 +0000)]
Do not need to buf[0] = 0 before strlcpy(buf, ...
deraadt [Thu, 23 Apr 2015 05:58:14 +0000 (05:58 +0000)]
delete a NOTDEF of unused code
deraadt [Thu, 23 Apr 2015 05:26:33 +0000 (05:26 +0000)]
KNF and other style adjustments to make this more scrutible.
reviewed by millert
dtucker [Thu, 23 Apr 2015 05:01:19 +0000 (05:01 +0000)]
Add a simple regression test for sshd's configuration parser. Right now,
all it does is run the output of sshd -T back through itself and ensure
the output is valid and invariant.
dtucker [Thu, 23 Apr 2015 04:59:10 +0000 (04:59 +0000)]
Two small fixes for sshd -T: ListenAddress'es are added to a list head so
reverse the order when printing them to ensure the behaviour remains the same,
and print StreamLocalBindMask as octal with leading zero. ok deraadt@
dtucker [Thu, 23 Apr 2015 04:53:53 +0000 (04:53 +0000)]
Check for and reject missing arguments for VersionAddendum and ForceCommand.
bz#2281, patch from plautrba at redhat com, ok djm@
jsg [Thu, 23 Apr 2015 02:55:15 +0000 (02:55 +0000)]
avoid an uneeded deref
ok blambert@ guenther@
deraadt [Thu, 23 Apr 2015 02:13:18 +0000 (02:13 +0000)]
error in strtonum() conversion; found by Nathanael Rensen
dlg [Thu, 23 Apr 2015 00:49:37 +0000 (00:49 +0000)]
dont need \n on panic strings
ratchov [Wed, 22 Apr 2015 20:29:56 +0000 (20:29 +0000)]
Remove forgotten empty files, from miod, thanks
bluhm [Wed, 22 Apr 2015 18:07:32 +0000 (18:07 +0000)]
Expand SLIST macro of unix pcb members before printing the pointer.
Fixes a gcc warning. No binary change.
Found by and OK deraadt@
schwarze [Wed, 22 Apr 2015 16:25:31 +0000 (16:25 +0000)]
Use .Ar for placeholders and .Cm for arguments to be provided verbatim.
No text change.
Inconsistent markup noticed by Alex dot Greif at greifdesign dot net.
OK jmc@ ajacoutot@.
nicm [Wed, 22 Apr 2015 15:32:33 +0000 (15:32 +0000)]
Make session_has return a flag, returning the first winlink found is a
recipe for errors.
nicm [Wed, 22 Apr 2015 15:30:11 +0000 (15:30 +0000)]
Change the windows array into an RB tree and fix some places where we
were only looking at the first winlink for a window in a session.
nicm [Wed, 22 Apr 2015 15:05:03 +0000 (15:05 +0000)]
window_index is only used in one place (window_destroy) so inline it there.
nicm [Wed, 22 Apr 2015 12:50:12 +0000 (12:50 +0000)]
Update termtypes.master to terminfo.src from ncurses-5.9-
20150418.
jsg [Wed, 22 Apr 2015 11:39:04 +0000 (11:39 +0000)]
Init a variable to zero so values aren't or'd into uninitialised memory.
From jeundery at gmail dot com
mpi [Wed, 22 Apr 2015 06:44:17 +0000 (06:44 +0000)]
Add the necessary glue to keep carp(4) working while other pseudo-drivers
are converted to if_input(), this time without breaking parent-less setup.
ok sthen@, dlg@
mpi [Wed, 22 Apr 2015 06:42:11 +0000 (06:42 +0000)]
Add missing header for NBRIDGE chunk, found the hardway and diff from
Rafael Zalamena.
mpi [Wed, 22 Apr 2015 06:39:03 +0000 (06:39 +0000)]
Implement the MI atomic API for PowerPC to avoid using gcc builtins that
include extra sync operations.
ok kettenis@
mlarkin [Wed, 22 Apr 2015 06:26:23 +0000 (06:26 +0000)]
Reduce differences between pae and no-pae modes.
discussed with deraadt
deraadt [Wed, 22 Apr 2015 05:54:46 +0000 (05:54 +0000)]
sync
jsg [Wed, 22 Apr 2015 04:12:22 +0000 (04:12 +0000)]
Init rt to NULL in arpresolve(). Not a problem in practice
as la will be NULL when rt is uninitialised which should cause
the function to return, but makes the code easier to follow.
ok mpi@ miod@
jsg [Wed, 22 Apr 2015 04:02:06 +0000 (04:02 +0000)]
Init error to 0 for sdmmc_mem_single_{read,write}_block
otherwise the value would be uninitialised in the unlikely
case of being called with length 0.
dlg [Wed, 22 Apr 2015 03:48:52 +0000 (03:48 +0000)]
having macros provide semicolons is dangerous.
djm [Wed, 22 Apr 2015 01:38:36 +0000 (01:38 +0000)]
use correct key for nested certificate test
djm [Wed, 22 Apr 2015 01:24:01 +0000 (01:24 +0000)]
unknown certificate extensions are non-fatal, so don't fatal
when they are encountered; bz#2387 reported by Bob Van Zant;
ok dtucker@
nicm [Tue, 21 Apr 2015 22:42:27 +0000 (22:42 +0000)]
Look up indexes as number before name, makes more sense if windows are
named starting with numbers. From Thomas Adam.
nicm [Tue, 21 Apr 2015 22:38:49 +0000 (22:38 +0000)]
Always format real layout even when zoomed.
nicm [Tue, 21 Apr 2015 22:32:40 +0000 (22:32 +0000)]
Do not die on USR1 if any of the socket parent directories are
missing. Reported by Robin Powell.
nicm [Tue, 21 Apr 2015 22:21:41 +0000 (22:21 +0000)]
Simplify error messages when socket connect fails, suggested by "Karthik K".
nicm [Tue, 21 Apr 2015 21:31:02 +0000 (21:31 +0000)]
The free callback could end up being fired before the done callback
(happens on Cygwin), so use a reference count instead of a single
flag. SF bug 188 reported by "iceboy".
nicm [Tue, 21 Apr 2015 21:24:49 +0000 (21:24 +0000)]
Fix moving windows to nonexistent indexes when renumber-windows is
off. From Thomas Adam, reported by Daniel Levai and Theo Buehler.
mlarkin [Tue, 21 Apr 2015 18:47:57 +0000 (18:47 +0000)]
Remove an extra lcr3 that snuck into pmap_switch during yesterday's
cleanup, responsible for various reaper panics pointed out on bugs@ this
morning.
ok deraadt@
mikeb [Tue, 21 Apr 2015 16:34:59 +0000 (16:34 +0000)]
Improve divert-to specification parsing w.r.t. rule address family.
ok henning
florian [Tue, 21 Apr 2015 16:32:24 +0000 (16:32 +0000)]
According to RFC 4861 and the actuall implementation rltime may not
exceed 9000 seconds.
Reported by Alexander Lobodzinski on bugs@, thanks!
OK benno@
schwarze [Tue, 21 Apr 2015 16:13:54 +0000 (16:13 +0000)]
Avoid a use after free when the target node is deleted during validation.
Bug reported by jsg@.
nicm [Tue, 21 Apr 2015 15:34:32 +0000 (15:34 +0000)]
Bind mouse dragging so that it is passed through to applications if they
want it rather than entering copy mode.
nicm [Tue, 21 Apr 2015 15:21:41 +0000 (15:21 +0000)]
Don't eat the mouse event that triggers a drag end because we may want
to pass it on to application inside the pane.
nicm [Tue, 21 Apr 2015 15:18:38 +0000 (15:18 +0000)]
Put mouse_any_flag back, don't know where it went to (still in man page).
nicm [Tue, 21 Apr 2015 15:18:06 +0000 (15:18 +0000)]
Pass mouse events through to commands for if-shell.
nicm [Tue, 21 Apr 2015 15:16:06 +0000 (15:16 +0000)]
cmd_mouse_pane can return NULL, check for that.
schwarze [Tue, 21 Apr 2015 14:27:07 +0000 (14:27 +0000)]
Section 1, not section one: section numbers are always numerical.
For example, "man -s one" wouldn't work either.
Patch from Alex Greif <alex dot greif at greifdesign dot net>.
dlg [Tue, 21 Apr 2015 13:15:54 +0000 (13:15 +0000)]
disable *8 again for now. incoherent archs arent having much fun with it.
henning [Tue, 21 Apr 2015 10:58:28 +0000 (10:58 +0000)]
append the setdir ("5.7/amd64", "snapshots/vax") as get-parameter "path"
when fetching the autoinstall response file.
a webserver that serves static files doesn't give a damn. if I map that
to something that dynamically creates the response file, i can use that to
construct the sets path, or play other arch and/or version dependent
games.
ok krw uwe
schwarze [Tue, 21 Apr 2015 10:46:48 +0000 (10:46 +0000)]
Back in January, Kaspars at Bankovskis dot net reported that the wc(1)
manual claims that -m would count characters, while our version of the
command actually doesn't, lacking POSIX multibyte support. Since
nobody stood up to fix the code, sync the docs with reality for now.
OK jmc@
schwarze [Tue, 21 Apr 2015 10:24:22 +0000 (10:24 +0000)]
When diff(1) finds differences, it returns an exit status of 1.
In that particular case, refrain from printing "diff: exit code 1"
because that exit status doesn't indicate an error condition.
Issue noticed by and patch OK'ed by ajacoutot@.
"I agree with the goal, and I suspect the diff actually achieves it" guenther@.
mpi [Tue, 21 Apr 2015 09:35:32 +0000 (09:35 +0000)]
Revert previous. Packets going through carp_input() but not destinated
to the carp interface would end up enqueued without being decapsulated.
Found the hard way by shten@
jsg [Tue, 21 Apr 2015 07:01:00 +0000 (07:01 +0000)]
Add back a backslash removed in rev 1.42 so KEX_SERVER_ENCRYPT will
include aes again.
ok deraadt@
mlarkin [Tue, 21 Apr 2015 04:40:40 +0000 (04:40 +0000)]
Remove a duplicate variable and #define that snuck in, in a previous
commit.
ok deraadt@
jsg [Tue, 21 Apr 2015 01:49:19 +0000 (01:49 +0000)]
fix a memory leak if tls_read() fails. ok henning@
jsg [Tue, 21 Apr 2015 01:46:57 +0000 (01:46 +0000)]
fix a memory leak. ok blambert@
jsg [Tue, 21 Apr 2015 01:44:47 +0000 (01:44 +0000)]
No need to do "size = (size_t)sb.st_size" both before and after
a fstat() call.
ok mikeb@ markus@
jsg [Tue, 21 Apr 2015 01:41:42 +0000 (01:41 +0000)]
init both fds passed to pipe as -1 instead of initing one twice
ok deraadt@ guenther@ miod@ millert@
guenther [Tue, 21 Apr 2015 01:38:41 +0000 (01:38 +0000)]
The ELF psABI for PPC specifies that the stack shall always be 16-byte aligned.
ok mpi@ deraadt@
dlg [Tue, 21 Apr 2015 01:31:51 +0000 (01:31 +0000)]
rework sgi mutexes to use the owner pointer as the lock.
this is like src/sys/arch/alpha/alpha/mutex.c r1.14.
this changes sgi mutexes so they record which cpu owns the lock
rather than just if the lock is held or not. the diagnostics compare
the owner to the current cpus curcpu() address so they can actually
tell if the current cpu holds the lock instead of whether any cpu
holds the lock.
instead of using custom asm to implement a cas this uses atomic_cas_ptr.
while im here i also shuffled the code. on MULTIPROCESSOR systems
instead of duplicating code between mtx_enter and mtx_enter_try,
mtx_enter simply loops on mtx_enter_try until it succeeds.
this also provides an alternative implementation of mutexes on
!MULTIPROCESSOR systems that avoids interlocking opcodes. mutexes
wont contend on UP boxes, theyre basically wrappers around spls.
we can just do the splraise, stash the owner as a guard value for
DIAGNOSTIC and return. similarly, mtx_enter_try on UP will never
fail, so we can just call mtx_enter and return 1.
tested by and ok miod@
guenther [Tue, 21 Apr 2015 01:24:28 +0000 (01:24 +0000)]
Eliminate the last uses of *fork's second syscall return register; the pid
is zero in the child
ok deraadt@ miod@
mlarkin [Tue, 21 Apr 2015 00:07:51 +0000 (00:07 +0000)]
Reduce differences between i386 pmap modes.
ok kettenis@
miod [Mon, 20 Apr 2015 19:08:52 +0000 (19:08 +0000)]
Remove most static, gives us much better ddb tracebacks from secondary
processors.
mikeb [Mon, 20 Apr 2015 17:22:18 +0000 (17:22 +0000)]
Log if we refuse to continue the exchange when another one that corresponds
to the same policy is already active. OK markus, hshoexer
nicm [Mon, 20 Apr 2015 15:41:32 +0000 (15:41 +0000)]
Remove unused-but-set variables, from Thomas Adam.
nicm [Mon, 20 Apr 2015 15:34:56 +0000 (15:34 +0000)]
Support for multiple key tables to commands to be bound to sequences of
keys. The default key bindings become the "prefix" table and -n the
"root" table. Keys may be bound in new tables with bind -T and
switch-client -T used to specify the table in which the next key should
be looked up. Based on a diff from Keith Amling.
krw [Mon, 20 Apr 2015 15:31:15 +0000 (15:31 +0000)]
Fix asking for list of http servers via '?'. The 'more' now used
on the install media does not (currently) support '-e' or other
posix nifties, but does exit after displaying the last line.
Should fix scanning for wireless networks too.
Reported by Adam Wolk on misc@.
ok deraadt@
nicm [Mon, 20 Apr 2015 14:48:55 +0000 (14:48 +0000)]
Style nit - unnecessary brackets.
espie [Mon, 20 Apr 2015 13:10:54 +0000 (13:10 +0000)]
totally forgot about the !uid notation in newuser when adding the early
cache for pkg_create. Reminded by sthen@
schwarze [Mon, 20 Apr 2015 09:54:34 +0000 (09:54 +0000)]
Fix previous: Don't let man(1) warn twice about non-existant names.
Again noticed by deraadt@.
schwarze [Mon, 20 Apr 2015 09:48:19 +0000 (09:48 +0000)]
Avoid out-of-bounds read access before the beginning of the
mdoc_macros[] array. This sometimes prevented proper warnings
about text nodes preceding the first section header.
nicm [Mon, 20 Apr 2015 09:39:21 +0000 (09:39 +0000)]
Make jump-to-backward/jump-to-forward repeatable with
jump-reverse/jump-again, from Jacob Niehus.
mpi [Mon, 20 Apr 2015 09:12:57 +0000 (09:12 +0000)]
Remove a bad typo introduced in rev 1.185 and found by jsg@.
Because of this semicolon, a local route was *always* created. This
should have no impact except for IPv6 addresses on loopback interfaces
for which the IPv6 code was trying to create a route to "::1" twice.
This should now be fixed so we can fix the bug that was hidding a bug
who was hidding a bug... lalala...
ok henning@
mpi [Mon, 20 Apr 2015 09:07:42 +0000 (09:07 +0000)]
Do not treat loopback interfaces as p2p interfaces and create only
one route to "::1".
Due to a clever BSD trick, the `ifa_dstaddr` field of addresses on
IFF_LOOPBACK ifps is set to the same value that `ifa_addr`. That's
why filtering for broadcast addresses is so complicated, because
guess what, `ifa_broadaddr` is the same as `ifa_dstaddr`!
Sadly our IPv6 code was "only" checking for `ifa_dstaddr` without
looking if the ifa was attached to a IFF_POINTOTPOINT interface.
So it always tried to create two routes to "::1" and, with the
recent RTF_LOCAL work, succeed.
You should now have only one local route to "::1".
::1 ::1 UHl 14 0 32768 1 lo0
-::1 ::1 UH 0 0 32768 4 lo0
ok henning@
mpi [Mon, 20 Apr 2015 08:53:36 +0000 (08:53 +0000)]
Always call rt_ifa_dellocal(9) when removing an IPv6 address.
The routing layer already check for the correct ifa when asked
to delete a local route, so do not try to be clever here.
This change also prevent having a NULL ifp pointer in your routing
table when you delete loopback interfaces having the same address.
ok henning@
nicm [Mon, 20 Apr 2015 07:50:49 +0000 (07:50 +0000)]
Use a more sensible buffer size for flags string.
dlg [Mon, 20 Apr 2015 00:46:32 +0000 (00:46 +0000)]
port src/sbin/ping/ping.c r1.119 and r1.121 to ping6:
> add a mac to the timestamp payload and calculate it with siphash.
>
> this lets us have some confidence that the timestamp hasnt been
> damaged or tampered with in transit.
>
> discussed with jp aumasson
> ok florian@
dlg [Mon, 20 Apr 2015 00:36:51 +0000 (00:36 +0000)]
fold the icmp seq number into the mac.
i dont know why i missed this before.
jmc [Sun, 19 Apr 2015 22:10:30 +0000 (22:10 +0000)]
tweak previous;
nicm [Sun, 19 Apr 2015 21:46:52 +0000 (21:46 +0000)]
Honour renumber-windows when unlinking a window, from Thomas Adam.
nicm [Sun, 19 Apr 2015 21:34:21 +0000 (21:34 +0000)]
Rewrite of tmux mouse support which was a mess. Instead of having
options for "mouse-this" and "mouse-that", mouse events may be bound as
keys and there is one option "mouse" that turns on mouse support
entirely (set -g mouse on).
See the new MOUSE SUPPORT section of the man page for description of the
key names and new flags (-t= to specify the pane or window under mouse
as a target, and send-keys -M to pass through a mouse event).
The default builtin bindings for the mouse are:
bind -n MouseDown1Pane select-pane -t=; send-keys -M
bind -n MouseDown1Status select-window -t=
bind -n MouseDrag1Pane copy-mode -M
bind -n MouseDrag1Border resize-pane -M
To get the effect of turning mode-mouse off, do:
unbind -n MouseDrag1Pane
unbind -temacs-copy MouseDrag1Pane
The old mouse options are now gone, set-option -q may be used to
suppress warnings if mixing configuration files.
nicm [Sun, 19 Apr 2015 21:05:27 +0000 (21:05 +0000)]
Support setting the default window and pane background colours (window
and active pane via window-style and window-active-style options, an
individual pane by a new select-pane -P flag). From J Raynor.
schwarze [Sun, 19 Apr 2015 20:34:56 +0000 (20:34 +0000)]
More than one data field may follow T} on the same input line.
Issue found by Christian Neukirchen <chneukirchen at gmail dot com>
in the socket(2) manual on Linux.
Also fixes major rendering bugs (including partial loss of content)
in XkbChangeControls(3), XkbFreeClientMap(3), XkbGetMap(3),
XkbKeyNumGroups(3), and XkbSetMap(3).
gilles [Sun, 19 Apr 2015 20:29:12 +0000 (20:29 +0000)]
Incorrect logic in smtpd(8) can lead to unexpected client disconnect, invalid
certificate in SNI negotiation or server crash.
spotted by Edwin Torok
sf [Sun, 19 Apr 2015 19:45:21 +0000 (19:45 +0000)]
Add support for x2apic mode
This is currently only enabled on hypervisors because on real hardware, it
requires interrupt remapping which we don't support yet. But on virtualization
it reduces the number of vmexits required per IPI from 4 to 1, causing a
significant speed-up for MP guests.
ok kettenis@
schwarze [Sun, 19 Apr 2015 19:43:50 +0000 (19:43 +0000)]
If an explicit line break request (.br or .sp) occurs within an .HP block,
the next line doesn't hang, but is simply indented.
Issue found by Christian Neukirchen <chneukirchen at gmail dot com>
in the dmsetup(8) manual on Linux.
This patch also improves the indentation of XDGA(3) and XrmGetResource(3).
deraadt [Sun, 19 Apr 2015 15:55:10 +0000 (15:55 +0000)]
sync
schwarze [Sun, 19 Apr 2015 15:10:04 +0000 (15:10 +0000)]
If apropos(1) finds no match, print "nothing appropriate" to stderr
similar to what the old apropos did.
Requested by and OK deraadt@.
schwarze [Sun, 19 Apr 2015 14:57:16 +0000 (14:57 +0000)]
Unify trickier node handling functions.
* man_elem_alloc() -> roff_elem_alloc()
* man_block_alloc() -> roff_block_alloc()
The functions mdoc_elem_alloc() and mdoc_block_alloc() remain for
now because they need to do mdoc(7)-specific argument processing.
jturner [Sun, 19 Apr 2015 14:26:27 +0000 (14:26 +0000)]
Bump minor, regen .pc and header
jturner [Sun, 19 Apr 2015 14:25:05 +0000 (14:25 +0000)]
Merge conflicts