florian [Fri, 20 Jul 2018 20:34:18 +0000 (20:34 +0000)]
Fix mem leaks on config reload:
- always free struct ra_iface_conf with free_ra_iface_conf()
- free_ra_iface_conf() needs to free the recently added
nameserver and search list
florian [Fri, 20 Jul 2018 20:33:29 +0000 (20:33 +0000)]
fix mem leak: missing freeifaddrs
bket [Fri, 20 Jul 2018 17:55:09 +0000 (17:55 +0000)]
Introduce MTU option.
The MTU option is used in Router Advertisement messages to ensure that
all nodes on a link use the same MTU value in those cases where the link
MTU is not well known.
Feedback (thank you!) and OK from florian@
florian [Fri, 20 Jul 2018 17:48:58 +0000 (17:48 +0000)]
We need to track the auto prefix in ra_prefix_conf otherwise we can't
configure its options. Trying so lead to a crash.
Found the hard way by & OK sthen
millert [Fri, 20 Jul 2018 15:35:33 +0000 (15:35 +0000)]
Now that aliases in smtpd.conf default to plain text files and not
db files we don't want to tell people to run makemap instead of
newaliases. OK deraadt@ jmc@
claudio [Fri, 20 Jul 2018 14:58:20 +0000 (14:58 +0000)]
Move the nlri_get_prefix functions to util.c so that bgpctl can use them too.
claudio [Fri, 20 Jul 2018 14:49:15 +0000 (14:49 +0000)]
Rename rde_update_get_prefix and friends to nlri_get_prefix. Will be moved
to util.c shortly so that bgpctl can use those functions too.
claudio [Fri, 20 Jul 2018 14:14:43 +0000 (14:14 +0000)]
Rename rde_update_extract_prefix to extract_prefix and make it static.
This is just an internal of the the rde_update_get_prefix functions.
florian [Fri, 20 Jul 2018 13:17:02 +0000 (13:17 +0000)]
Rename "resolver" to "nameserver" in the configuration file.
resolv.conf(5) and dhclient(8) are using the term nameserver for many
years, there is no good reason to be different here.
Pointed out by deraadt
claudio [Fri, 20 Jul 2018 12:49:49 +0000 (12:49 +0000)]
Print the timestamp embedded in mrt files for update and status messages.
Also implemented the extended precision format so microseconds are printed
as well when available. The output is relative to the previous message and
follows what kdump does.
OK benno@
claudio [Fri, 20 Jul 2018 12:42:45 +0000 (12:42 +0000)]
There is no need to have bgpd running when running bgpctl show mrt.
The first thing the code actually does is closing the socket. Instead
move the code up to where currently the IRR filter code is.
Additionally change the late pledges to just stdio since nothing after
that needs rpath or wpath.
OK benno@
helg [Fri, 20 Jul 2018 12:05:08 +0000 (12:05 +0000)]
Add missing RCS Id.
kn [Fri, 20 Jul 2018 11:16:55 +0000 (11:16 +0000)]
Stop checking table commands for `create'
Tiny left over from 2003 when it was removed. Twist the logic by checking
for `show' and `test' to make it even simpler.
OK sashan henning
robert [Fri, 20 Jul 2018 10:47:37 +0000 (10:47 +0000)]
add regress test for "bypassunveil" where a path should be unveil'd by
specific pledge(2) calls
ok beck@
espie [Fri, 20 Jul 2018 10:02:03 +0000 (10:02 +0000)]
inform that diagnostics in functions won't work, but don't error out
flatly.
this will help sparc64 compile code without needing to patch away recent
pragma diagnostic use.
problem found by landry@
okay kettenis@, guenther@
beck [Fri, 20 Jul 2018 07:28:36 +0000 (07:28 +0000)]
Correctly copy across unveil's from parent to child process on fork().
jsg [Fri, 20 Jul 2018 05:37:06 +0000 (05:37 +0000)]
match on marvell,armada-38x-uart linux >= 4.18-rc1 changed the compat
string from snps,dw-apb-uart in
b7639b0b15ddd1a4686b0142e70dfb122eefc88f
ok patrick@
djm [Fri, 20 Jul 2018 05:01:10 +0000 (05:01 +0000)]
slightly-clearer description for AuthenticationMethods - the lists
have comma-separated elements; bz#2663 from Hans Meier
djm [Fri, 20 Jul 2018 03:46:34 +0000 (03:46 +0000)]
remove unused zlib.h
guenther [Fri, 20 Jul 2018 01:30:30 +0000 (01:30 +0000)]
Missed a 'ksi' -> '*ksip' change in previous commit
dtucker [Thu, 19 Jul 2018 23:03:16 +0000 (23:03 +0000)]
Fix typo in comment. From Alexandru Iacob via github.
jmc [Thu, 19 Jul 2018 19:16:36 +0000 (19:16 +0000)]
i found a nicer way to describe -join;
drahn [Thu, 19 Jul 2018 17:38:12 +0000 (17:38 +0000)]
Enable kernel profiling on arm64
sigcode() runs in user land context, so should not call mcount.
Without the symbol type on the exception entry functions, gprof
doesn't correctly identify the caller for exception entry symbols.
ok kettenis@
sthen [Thu, 19 Jul 2018 17:34:22 +0000 (17:34 +0000)]
attach RTL8188EU under AboCom's vendor id. From FreeBSD via Mikhail <mp39590 at gmail>
sthen [Thu, 19 Jul 2018 17:33:42 +0000 (17:33 +0000)]
sync
sthen [Thu, 19 Jul 2018 17:33:26 +0000 (17:33 +0000)]
Add RTL8188EU under AboCom's vendor id. From FreeBSD via Mikhail <mp39590 at gmail>
mpi [Thu, 19 Jul 2018 12:35:14 +0000 (12:35 +0000)]
Reuse implicit padding to export the port number of a USB device in
USB_DEVICEINFO.
devel/libusb1 requires this piece of information.
ok jcs@, mikeb@, jasper@, sthen@
dtucker [Thu, 19 Jul 2018 10:28:47 +0000 (10:28 +0000)]
Deprecate UsePrivilegedPort now that support for running ssh(1)
setuid has been removed, remove supporting code and clean up
references to it in the man pages
We have not shipped ssh(1) the setuid bit since 2002. If ayone
really needs to make connections from a low port number this can
be implemented via a small setuid ProxyCommand.
ok markus@ jmc@ djm@
sthen [Thu, 19 Jul 2018 10:20:09 +0000 (10:20 +0000)]
revert previous, something isn't quite right as clients see ntpd
as unsynced. reported by naddy, also seen by me (I noticed because
monitoring-plugins check_ntp complained). ok claudio henning
florian [Thu, 19 Jul 2018 09:16:17 +0000 (09:16 +0000)]
ieee80211_ess_is_better() returns 0 or 1, comparing > 1 is always
false so we always selected the first wifi available, not the best
one.
While here shuffle some deck chairs to make it clearer that anything is
better than nothing.
tweak & OK phessler
beck [Thu, 19 Jul 2018 06:40:22 +0000 (06:40 +0000)]
Add regress test for inheritance of unveil's across fork to children
naddy [Wed, 18 Jul 2018 20:21:12 +0000 (20:21 +0000)]
Remove the unused leftovers of the 4.4BSD libm, which was only used
on non-IEEE platforms. Since the VAX port was discontinued, all
our remaining architectures use IEEE floating point, as will any
future ones.
ok millert@ tb@
millert [Wed, 18 Jul 2018 17:20:54 +0000 (17:20 +0000)]
Convert from fgetln(3) to getline(3). Based on a diff from Lauri Tirkkonen.
With a tweak and OK from schwarze@
bluhm [Wed, 18 Jul 2018 16:55:17 +0000 (16:55 +0000)]
Revert the change that delivers process signals to any threads. As
side effect pending signals specifically sent to the main thread
were handled by other threads. This made gcj in textproc/pdftk
port build stall.
Noticed and tested by espie@.
tb [Wed, 18 Jul 2018 16:24:16 +0000 (16:24 +0000)]
Bob's license was missing, add it.
ok beck
florian [Wed, 18 Jul 2018 15:46:49 +0000 (15:46 +0000)]
replace manual zero initialization of various fields with memset;
makes the code shorter and easier to read.
suggested by & OK claudio
florian [Wed, 18 Jul 2018 14:43:34 +0000 (14:43 +0000)]
Stop our own router advertisements from looping back to us.
Pointed out by semarie@
jmc [Wed, 18 Jul 2018 14:06:30 +0000 (14:06 +0000)]
tidy up the flags section a little: supply a little more indent, and reduce
the amount of modal verbs going on;
florian [Wed, 18 Jul 2018 13:55:39 +0000 (13:55 +0000)]
When running flood ping with count packets (-c) set an alarm after
sending all packets otherwise ping will wait forever to see all
answers - which might not arrive on lossy links.
Problem pointed out by, input & OK claudio
espie [Wed, 18 Jul 2018 13:06:23 +0000 (13:06 +0000)]
make the logic for deleting first slightly more obvious
in particular, there's nothing to try if we don't have older packages
dtucker [Wed, 18 Jul 2018 11:34:04 +0000 (11:34 +0000)]
Remove support for running ssh(1) setuid and fatal if attempted.
Do not link uidwap.c into ssh any more. Neuters UsePrivilegedPort,
which will be marked as deprecated shortly. ok markus@ djm@
helg [Wed, 18 Jul 2018 10:47:02 +0000 (10:47 +0000)]
Replace VATTR_NULL() with memset(3) in fusefs_getattr(). VATTR_NULL()
sets all members of struct vattr to VNOVAL (-1) instead of 0, which is
what is appropriate here. The VATTR_NULL() macro is intended for
initialising struct vattr when setting attributes.
ok mpi@
florian [Wed, 18 Jul 2018 09:10:50 +0000 (09:10 +0000)]
Don't log_warn on normal conditions, it should be log_debug.
Pointed out by semarie@
kn [Tue, 17 Jul 2018 20:57:27 +0000 (20:57 +0000)]
stop assuming prefix lengths, remove inet6_makenetandmask()
This removes any logic that implies IPv6 destination host addresses to be
/64 subnets so they are taken as is.
RFC 3587 deprecated this in 2003 and our manual page actually states:
The route is assumed to be to a network if any of the following apply to
destination:
* [...]
* it is an IPv6 address with a “/XX” suffix (where XX is the number of
bits in the network portion of the address and is less than 128)
* [...]
If destination is a valid IP address or host name, it is presumed to be a
route to a host.
Stripping relevant code from `inet6_makenetandmask()' left the function as
dummy wrapper around `prefixlen()', so zap it completely.
Discussed with and positive feedback from many, OK benno henning
patrick [Tue, 17 Jul 2018 19:44:38 +0000 (19:44 +0000)]
TX packets, which can be either Ethernet or control packets, must be
sent in order. Otherwise it is possible that the key is set before
we send out the EAPOL packet, or that packets are sent out before
the key is set. Thus modify the SDIO backend to put both types into
the same internal TX queue, which will be sent asynchronously.
Discussed with bluhm@
nicm [Tue, 17 Jul 2018 18:02:40 +0000 (18:02 +0000)]
When a key isn't in the first table, we need to try the same key again
not the any key. Also rename some labels. Fixes GitHub issue 1406
reeported by Mark Kelly.
tb [Tue, 17 Jul 2018 17:10:04 +0000 (17:10 +0000)]
some more style fixes
tb [Tue, 17 Jul 2018 17:06:49 +0000 (17:06 +0000)]
Add missing $OpenBSD$ markers.
tb [Tue, 17 Jul 2018 16:55:21 +0000 (16:55 +0000)]
remove unused, empty file
inoguchi [Tue, 17 Jul 2018 14:27:22 +0000 (14:27 +0000)]
Replace getprogname() to argv[0] in bnaddsub
ok tb@
djm [Tue, 17 Jul 2018 13:51:47 +0000 (13:51 +0000)]
allow shell globs to match program and hostname selector tags via
fnmatch(3); ok sthen@ bluhm@
mlarkin [Tue, 17 Jul 2018 13:47:06 +0000 (13:47 +0000)]
vmd(8): fix vmctl -b option for i386 kernels.
ok pd@
helg [Tue, 17 Jul 2018 13:12:08 +0000 (13:12 +0000)]
Don't send FBT_DESTROY if the FUSE connection is still PENDING. Also
don't attempt to determine the size of the root inode. This is because
we don't need to know the size of directories and FBT_GETATTR will also
cause a deadlock if fuse_unmount(3) is called before the file system
has a chance to process fbufs.
Add corresponding regression test.
ok mpi@
helg [Tue, 17 Jul 2018 13:04:31 +0000 (13:04 +0000)]
libfuse now supports -f command line option; uncomment test.
krw [Tue, 17 Jul 2018 07:43:34 +0000 (07:43 +0000)]
unvname_new() is passed something that is always 64-bits so the
parameter should be declared uint64_t and not int.
From & for semarie@ who isn't committing at the moment and ok beck@
who is on the road.
claudio [Tue, 17 Jul 2018 07:02:11 +0000 (07:02 +0000)]
Switch to MSG_PROTOCOL_BGP4MP_ET formats for update and state mrt messages.
The _ET format adds an additional microsecond time field which makes those
message dumps more informative. The various table dumps are not modified
since there the time especially between entries plays a secondary role.
OK benno@
dlg [Tue, 17 Jul 2018 03:32:10 +0000 (03:32 +0000)]
we have splraise() now
previously the code would do a series of comparisons to IPL_FOO and
IPL_BAR, and use splfoo() and splbar() as needed, but for like a
dozen different IPl levels (i may be exaggerating). splraise() rolls
all of that up.
ok deraadt@ mpi@
dtucker [Mon, 16 Jul 2018 22:25:01 +0000 (22:25 +0000)]
Slot 0 in the hostbased key array was previously RSA1, but that is
now gone and the slot is unused so remove it. Remove two now-unused
macros, and add an array bounds check to the two remaining ones
(array is statically sized, so mostly a safety check on future changes).
ok markus@
tb [Mon, 16 Jul 2018 17:37:25 +0000 (17:37 +0000)]
Document behavior change of EC_POINTs_mul() again.
tb [Mon, 16 Jul 2018 17:32:39 +0000 (17:32 +0000)]
Recommit Billy Brumley's ECC constant time patch with a fix for sparc64
from Nicola Tuveri (who spotted the omission of ecp_nist.c from the PR).
discussed with jsing
tested by jsg
jasper [Mon, 16 Jul 2018 17:05:15 +0000 (17:05 +0000)]
use ANSI C function declaration; no binary change
jasper [Mon, 16 Jul 2018 16:54:30 +0000 (16:54 +0000)]
use 'switch' rathan than an if-else construct to match on the netflow version to in pflow_get_mbuf(),
to match the rest of the file
ok benno@ florian@
helg [Mon, 16 Jul 2018 16:44:09 +0000 (16:44 +0000)]
Insert the appropriate uvm_vnp_uncache(9) and uvm_vnp_setsize(9)
kernel calls to ensure that the UVM cache for memory mapped files is
up to date.
ok mpi@
patrick [Mon, 16 Jul 2018 13:46:17 +0000 (13:46 +0000)]
Add support for the BCM43455 SDIO chip to bwfm(4).
patrick [Mon, 16 Jul 2018 13:41:19 +0000 (13:41 +0000)]
In certain modes SDIO-connected bwfm(4) chips might expect us to read
another packet (even though nextlen is set to none) to issue more RX
interrupts.
espie [Mon, 16 Jul 2018 13:14:06 +0000 (13:14 +0000)]
Be more explicit in FETCH_TIMEOUT description.
It only happens on the command line.
If you want to put it in a config file, it's a DEFAULT or localhost
property called fetch_timeout instead.
helg [Mon, 16 Jul 2018 13:10:53 +0000 (13:10 +0000)]
Implement FBT_FSYNC, which is called on fsync(2) and fdatasync(2).
Currently ignores the a_waitfor argument and always invokes the file
system's fsync implementation synchronously.
ok mpi@
phessler [Mon, 16 Jul 2018 12:42:22 +0000 (12:42 +0000)]
the AP sends their crypto parameters as a mask, so let us still select it
in case we want WPA2 and they have WPA1 still enabled
phessler [Mon, 16 Jul 2018 12:34:14 +0000 (12:34 +0000)]
don't save or use auto-join when the card is not in station (aka client) mode
OK stsp@
espie [Mon, 16 Jul 2018 12:02:45 +0000 (12:02 +0000)]
fix thinko
okay mestre@
patrick [Mon, 16 Jul 2018 11:52:26 +0000 (11:52 +0000)]
Re-set the pointer to the bwfm event after the strict alignment
check.
dtucker [Mon, 16 Jul 2018 11:05:41 +0000 (11:05 +0000)]
Remove support for loading HostBasedAuthentication keys directly in
ssh(1) and always use ssh-keysign. This removes one of the few remaining
reasons why ssh(1) might be setuid. ok markus@
espie [Mon, 16 Jul 2018 09:13:29 +0000 (09:13 +0000)]
network.conf
espie [Mon, 16 Jul 2018 09:12:40 +0000 (09:12 +0000)]
byebye network.conf.template
claudio [Mon, 16 Jul 2018 09:09:20 +0000 (09:09 +0000)]
Use struct filterstate in rde_update_dispatch() and pass it down to
functions like rde_update_update and path_update. This will allow to
move more pointers from rde_aspath to the prefix.
Looks good benno@
jsg [Mon, 16 Jul 2018 08:53:44 +0000 (08:53 +0000)]
make this build again after changes made in rev 1.74
ok mpi@ phessler@
nicm [Mon, 16 Jul 2018 08:48:22 +0000 (08:48 +0000)]
Add an "Any" key to run a command if a key is pressed that is not bound
in the current key table. GitHub issue 1404.
kn [Mon, 16 Jul 2018 08:29:08 +0000 (08:29 +0000)]
reduce duplicate code, fix typo/free correct buffer
In filteropts_to_rule():
* Merge `once' handling from `anchorrule' and `pfrule'
* Remove/shorten duplicate code block
* Fix typo I introduced with r1.678 that frees the wrong buffer (twice)
OK sashan
claudio [Mon, 16 Jul 2018 07:56:04 +0000 (07:56 +0000)]
rtadvd is only interested in IPv6 so limit route socket to AF_INET6.
OK florian@
mpi [Mon, 16 Jul 2018 07:49:31 +0000 (07:49 +0000)]
Fix for uninitialized variables.
Found by and ok jsg@, ok markus@
mpi [Mon, 16 Jul 2018 07:48:17 +0000 (07:48 +0000)]
typos, from Michael W. Bombardieri.
djm [Mon, 16 Jul 2018 07:06:50 +0000 (07:06 +0000)]
keep options.identity_file_userprovided array in sync when we load
keys, fixing some spurious error messages; ok markus
djm [Mon, 16 Jul 2018 03:09:59 +0000 (03:09 +0000)]
memleak in unittest; found by valgrind
djm [Mon, 16 Jul 2018 03:09:13 +0000 (03:09 +0000)]
memleaks; found by valgrind
ccardenas [Sun, 15 Jul 2018 20:25:52 +0000 (20:25 +0000)]
vioscsi driver has been stable enough so we can move a good portion of these
log_debug messages to be DPRINTF (compile time).
Prompted by reyk@.
Ok reyk@.
tb [Sun, 15 Jul 2018 18:22:57 +0000 (18:22 +0000)]
re-commit the removal of the EC_POINTs_mul() regression tests with num > 1
fcambus [Sun, 15 Jul 2018 18:04:37 +0000 (18:04 +0000)]
Document xcrypt in the amd64 version of cpu.4.
Bits taken from the i386 version.
OK jmc@
tb [Sun, 15 Jul 2018 16:27:39 +0000 (16:27 +0000)]
recommit label indentation part of the backout; clearly unrelated to the
breakage.
reyk [Sun, 15 Jul 2018 14:42:04 +0000 (14:42 +0000)]
Revert unrelated change to vioscsi.c
(I had this in my tree to silence vioscsi.c log_debug, but Carlos
already has a better diff for that)
reyk [Sun, 15 Jul 2018 14:36:54 +0000 (14:36 +0000)]
Track resources and enforce cpu/memory/interface limits for non-root users.
The limits are currently hard-coded and undocumented (4 CPUs/VMs, 2G
memory, 8 interfaces) but will be configurable in an upcoming diff.
These limits are tracked in total usage; for example, a user will be
able to run up to 4 VMs with 512M of memory or a single VM with 2G.
OK ccardenas@ mlarkin@
beck [Sun, 15 Jul 2018 12:44:09 +0000 (12:44 +0000)]
Restore correct behaviour to pledge for access and stat, which was broken
by the unveil diff. Noticed at, and diff from semarie@
jmc [Sun, 15 Jul 2018 11:35:57 +0000 (11:35 +0000)]
tweak previous;
phessler [Sun, 15 Jul 2018 10:46:48 +0000 (10:46 +0000)]
adjust the example hostname.if to show "wpakey" on the same line as "nwid",
and provide an IPv6 autoconf example.
while here, split interface settings from IP assignment.
OK jmc@
phessler [Sun, 15 Jul 2018 10:44:49 +0000 (10:44 +0000)]
adjust hostname.if examples to show "wpakey" on the same line as "nwid"
OK jmc@
florian [Sun, 15 Jul 2018 09:28:21 +0000 (09:28 +0000)]
Implement RFC 8106: IPv6 Router Advertisement Options for DNS
Configuration.
florian [Sun, 15 Jul 2018 09:27:02 +0000 (09:27 +0000)]
mark up managed / other configuration
florian [Sun, 15 Jul 2018 09:26:26 +0000 (09:26 +0000)]
It's a packet, not package.
florian [Sun, 15 Jul 2018 09:25:41 +0000 (09:25 +0000)]
nuke newd leftover
gilles [Sun, 15 Jul 2018 08:49:12 +0000 (08:49 +0000)]
remove unused variable
nicm [Sun, 15 Jul 2018 06:57:13 +0000 (06:57 +0000)]
Fix new-window -k, GitHub issue 1403.