claudio [Thu, 15 Apr 2021 13:33:17 +0000 (13:33 +0000)]
Make rpki-client -V output nicer.
OK job@, kn@, deraadt@
claudio [Thu, 15 Apr 2021 13:31:30 +0000 (13:31 +0000)]
Call rrdp_data_handler() for any kind of poll event that has happened.
On OpenBSD closing a connection will result in a read even (POLLIN) while
on Linux POLLHUP is returned. rrdp_data_handler()'s read() call returns
in both cases 0 and finishes the XML parsing.
Found and fix tested by job@, OK deraadt@
claudio [Thu, 15 Apr 2021 08:58:46 +0000 (08:58 +0000)]
Do not only check the serial number but also the session_id before
adding a delta to the queue. If the session_id differs there is no
need for deltas since a snapshot must be fetched.
OK job@ benno@ deraadt@
kettenis [Thu, 15 Apr 2021 07:28:37 +0000 (07:28 +0000)]
The SSR1 register can have bits set that don't match to bits in the MSR
register. We would set the sc_ps member of struct sigcontext to SSR1
when entering a signal handler, and compare it to PSL_USER in sigreturn(2)
to make sure that the user code didn't set any bits it shouldn't set.
If non-MSR bits are set that comparison would fail and sigreturn(2) would
fail. Fix this by initializing sc_ps to PSL_USER instead of taking its
value from SSR1. On OpenBSD we always run processes with the same MSR
value.
ok deraadt@
nicm [Thu, 15 Apr 2021 05:38:11 +0000 (05:38 +0000)]
%begin now has three arguments, not two. GitHubs issue 2646.
kevlo [Thu, 15 Apr 2021 02:23:17 +0000 (02:23 +0000)]
Match Linux path in r8153_set_rx_early_size().
The rx early size is used to reduce the loading of CPU by letting a transfer
contain more data to reduce the number of transfers.
ok deraadt@
deraadt [Wed, 14 Apr 2021 23:35:24 +0000 (23:35 +0000)]
my fingers cannot avoid KNF'ing as I review code
bluhm [Wed, 14 Apr 2021 19:34:56 +0000 (19:34 +0000)]
On powerpc64 tcpdump(8) could not parse wireguard packets.
EXTRACT_LE_32BITS() converts the type from little endian to host
endian. So we need the constants in host endianess. This fixes
regress/sys/net/wg.
OK deraadt@ sthen@
stsp [Wed, 14 Apr 2021 18:38:54 +0000 (18:38 +0000)]
Make iwx(4) attach to AX201 devices with PCI ID 0x06f0.
Patch and testing by Ivo Sbalzarini
ok deraadt@
stsp [Wed, 14 Apr 2021 18:37:14 +0000 (18:37 +0000)]
regen
stsp [Wed, 14 Apr 2021 18:36:42 +0000 (18:36 +0000)]
Add PCI IDs of the Thunderbolt and WiFi devices in Thinkpad X1 Extreme Gen 3.
Patch by Ivo Sbalzarini
ok deraadt@
kettenis [Wed, 14 Apr 2021 18:35:14 +0000 (18:35 +0000)]
Properly restore FPSCR register.
ok deraadt@
deraadt [Wed, 14 Apr 2021 18:10:47 +0000 (18:10 +0000)]
handle obj dir
benno [Wed, 14 Apr 2021 18:05:47 +0000 (18:05 +0000)]
move the RPKI_VERSION define into its own version.h file, helps portable.
ok claudio@
kettenis [Wed, 14 Apr 2021 16:06:15 +0000 (16:06 +0000)]
Unify pivot.h; brings powerpc/powerpc64 support to the usr.bin/lastcomm
regress test.
ok bluhm@
tb [Wed, 14 Apr 2021 14:54:30 +0000 (14:54 +0000)]
revert previous. some of the keyupdate tests still fail occasionally
tb [Wed, 14 Apr 2021 14:29:16 +0000 (14:29 +0000)]
Enable test-tls13-keyupdate.py
tb [Wed, 14 Apr 2021 14:19:51 +0000 (14:19 +0000)]
move test-record-size-limit.py to unsupported
millert [Wed, 14 Apr 2021 13:59:59 +0000 (13:59 +0000)]
_PASSWORD_LEN is no longer the limit for an unencrypted password.
It is now used as the max length of the encrypted password hash.
From Benjamin Baier.
tb [Wed, 14 Apr 2021 13:37:59 +0000 (13:37 +0000)]
enable test-record-layer-fragmentation.py
tb [Wed, 14 Apr 2021 13:06:53 +0000 (13:06 +0000)]
factor argument to catch an alert mismatch into a helper function
bluhm [Wed, 14 Apr 2021 12:32:56 +0000 (12:32 +0000)]
Rename privacy to temporary in slaacd regress, then it passes.
OK florian@
deraadt [Tue, 13 Apr 2021 21:16:01 +0000 (21:16 +0000)]
spacing
deraadt [Tue, 13 Apr 2021 21:13:20 +0000 (21:13 +0000)]
construct an octeon installXX.img file
bluhm [Tue, 13 Apr 2021 18:50:46 +0000 (18:50 +0000)]
Automated regress cannot connect to servers in internet. Check
whether jigsaw.w3.org is reachable and skip rpki client http test
if not.
OK claudio@
tb [Tue, 13 Apr 2021 16:16:06 +0000 (16:16 +0000)]
enable test-tlsfuzzer-invalid-compression-methods.py
nicm [Tue, 13 Apr 2021 16:00:47 +0000 (16:00 +0000)]
Include modifiers when looking up an individual key.
tb [Tue, 13 Apr 2021 15:59:14 +0000 (15:59 +0000)]
enable test-large-hello.py as a slow test
tb [Tue, 13 Apr 2021 15:53:20 +0000 (15:53 +0000)]
with new defaults, test-fuzzed-plaintext.py is no longer slow
tb [Tue, 13 Apr 2021 15:45:22 +0000 (15:45 +0000)]
move a few tests to the unsupported group and fix two comments
millert [Tue, 13 Apr 2021 15:39:21 +0000 (15:39 +0000)]
Require that the argument to the window option be non-zero.
A zero-row window would not be usable (no room to edit) and the
code is full of assumptions that "sp->t_rows - 1" >= 0.
From Erik Ruotsalainen, fixes a bug reported by Paul de Weerd.
tb [Tue, 13 Apr 2021 15:35:20 +0000 (15:35 +0000)]
annotate test-ecdhe-rsa-key-exchange-with-bad-messages.py with expected
alerts and where to add them.
millert [Tue, 13 Apr 2021 15:34:41 +0000 (15:34 +0000)]
Ignore expandtab setting when in command mode.
Fixes things like searching for a literal tab character when
expandtab is enabled. From nvi2 (leres). OK martijn@
stsp [Tue, 13 Apr 2021 14:20:23 +0000 (14:20 +0000)]
Fix merging of files that lack a final \n at EOF after a block of common lines.
Problem reported by Josh Rickmar.
ok millert@
claudio [Tue, 13 Apr 2021 13:54:15 +0000 (13:54 +0000)]
Adjust http_done() the be more like http_fail() -- only do the message
delivery part but don't alter the http_connection anymore.
Also move common code in the connect case into a new function and call it
from connect and finish connect.
OK benno@
claudio [Tue, 13 Apr 2021 13:35:59 +0000 (13:35 +0000)]
Before adding a file to the temporary rrdp repo remove it from the
deleted filepath set. A file can only be in one set (deleted or added)
but not on both.
OK benno@
nicm [Tue, 13 Apr 2021 12:26:34 +0000 (12:26 +0000)]
Change how extended ctrl keys are processed to fix C-S-Tab and C-;.
claudio [Tue, 13 Apr 2021 08:21:12 +0000 (08:21 +0000)]
Unbreak rtable regress test. Define _KERNEL in some crucial spots so that
the include guard in rtsock.h is bypassed and critical defines like rtentry
show up. Also remove the old RADIX bits, rtable code is art only for a while.
claudio [Tue, 13 Apr 2021 07:43:23 +0000 (07:43 +0000)]
Fix rde_decide_test regress test
claudio [Tue, 13 Apr 2021 07:39:17 +0000 (07:39 +0000)]
Add a basic regress test to test the 'rde evaluate all' feature.
claudio [Tue, 13 Apr 2021 07:38:23 +0000 (07:38 +0000)]
Use tee(1) so that the bgpctl output is visible during the run.
nicm [Tue, 13 Apr 2021 05:25:05 +0000 (05:25 +0000)]
Move mode set/reset after sync so cursor doesn't flicker, from Avi
Halachmi.
nicm [Tue, 13 Apr 2021 05:23:34 +0000 (05:23 +0000)]
Handle C-Tab correctly with extended keys, GitHub issue 2642.
deraadt [Tue, 13 Apr 2021 04:55:28 +0000 (04:55 +0000)]
handle iso dir
claudio [Mon, 12 Apr 2021 17:23:30 +0000 (17:23 +0000)]
Cast XML_GetCurrentLineNumber() to unsigned long long in warnx since
expat my either use unsigned long or unsigened long long as return value
depending on compile options. This upcast is an easy way around this issue.
OK deraadt@
claudio [Mon, 12 Apr 2021 10:03:33 +0000 (10:03 +0000)]
Spaces, no functional change
nicm [Mon, 12 Apr 2021 09:36:12 +0000 (09:36 +0000)]
Add a flag to disable keys to close a message, GitHub issue 2625.
nicm [Mon, 12 Apr 2021 06:50:25 +0000 (06:50 +0000)]
Permit shortcut keys in buffer, client, tree modes to be configured with
a format; the default remains the line number. GitHub issue 2636.
kn [Mon, 12 Apr 2021 03:17:57 +0000 (03:17 +0000)]
Document bpe(4)
Diff from Marcus MERIGHI <mcmer-openbsd at tor dot at>, thanks.
Feedback OK jmc
OK dlg
tobhe [Sun, 11 Apr 2021 23:27:06 +0000 (23:27 +0000)]
Document 'request' option to request additional configuration payloads.
ok patrick@
dv [Sun, 11 Apr 2021 21:02:40 +0000 (21:02 +0000)]
KNF, capitalization, whitespace
dv [Sun, 11 Apr 2021 18:53:23 +0000 (18:53 +0000)]
Remove dead code for unused IMSG_CTL_NOTIFY messages.
Some vestigial code left over from when priv-sep was implemented.
ok mlarkin@
deraadt [Sun, 11 Apr 2021 17:18:15 +0000 (17:18 +0000)]
Create a sparc64 install*.img file also
tested by kettenis
deraadt [Sun, 11 Apr 2021 16:11:59 +0000 (16:11 +0000)]
vnconfig is run without a label-type (install360), because in-Makefile
scripting calculates msdos+ffs layout, so FSTYPE= is not neccessary.
kettenis [Sun, 11 Apr 2021 15:30:51 +0000 (15:30 +0000)]
On systems that hide the PCI bridge device corresponding to a PCIe RC port
we may end up passing a NULL pointer to pcie_get_speed_cap(). Handle this
by returning PCI_SPEED_UNKNOWN instead of dereferencing a null-pointer.
ok jsg@
dv [Sun, 11 Apr 2021 14:12:42 +0000 (14:12 +0000)]
Correct a comment: reference the correct file
kn [Sun, 11 Apr 2021 14:07:03 +0000 (14:07 +0000)]
bwfm(4) needs firmload
Otherwise compiling a kernel witout any other wifi drivers fails.
OK patrick deraadt
eric [Sun, 11 Apr 2021 07:18:08 +0000 (07:18 +0000)]
do not build unused code and remove uneeded dependency on libm.
ok tb@
tb [Sun, 11 Apr 2021 07:06:01 +0000 (07:06 +0000)]
Update a stale comment and fix a typo.
deraadt [Sun, 11 Apr 2021 02:30:03 +0000 (02:30 +0000)]
sync
job [Sun, 11 Apr 2021 01:20:03 +0000 (01:20 +0000)]
Fix two typos in comments
sure deraadt@
deraadt [Sat, 10 Apr 2021 21:02:36 +0000 (21:02 +0000)]
build arm64 install*.img
requested by kettenis, first testing by kn
florian [Sat, 10 Apr 2021 17:22:34 +0000 (17:22 +0000)]
Make sure the ip header lands on a 4 byte alignment by adding 2 bytes
padding because the ethernet header in front is only 14 bytes.
Found the hard way by me while testing on sparc64.
Solution suggested by & OK deraadt
gnezdo [Sat, 10 Apr 2021 15:26:47 +0000 (15:26 +0000)]
Add cabal-module(5) man page
OK kn
eric [Sat, 10 Apr 2021 10:19:19 +0000 (10:19 +0000)]
remove dead code and unused dependencies
ok tb@
claudio [Sat, 10 Apr 2021 10:10:07 +0000 (10:10 +0000)]
Do not compare TLS config params for non-TLS servers. This allows to
mix 'listen * port 80' and 'listen * tls port 443' in one server block.
Also the last argument of server_tls_cmp - match_keypair - is always 0
so remove this code.
OK florian@ tb@ some long time ago
eric [Sat, 10 Apr 2021 06:44:18 +0000 (06:44 +0000)]
bump smtpd version
mlarkin [Fri, 9 Apr 2021 20:59:03 +0000 (20:59 +0000)]
regen
mlarkin [Fri, 9 Apr 2021 20:58:20 +0000 (20:58 +0000)]
add pcidevs entries for Aquantia ethernet devices
kn [Fri, 9 Apr 2021 20:05:50 +0000 (20:05 +0000)]
It is macobio0; hit with the cluestick from jsg
eric [Fri, 9 Apr 2021 16:43:43 +0000 (16:43 +0000)]
allow to specify tls ciphers and protocols on listeners
ok tb@
martijn [Fri, 9 Apr 2021 14:46:39 +0000 (14:46 +0000)]
When a DHCP server sends an invalid T1 or T2 default back to the default
values as specified in RFC2131 section 4.4.5. Allows my Comtrend VI-3223u
to work.
OK florian@
kn [Fri, 9 Apr 2021 11:36:28 +0000 (11:36 +0000)]
synopsis: macobio0* -> macobio*
claudio [Fri, 9 Apr 2021 10:14:36 +0000 (10:14 +0000)]
Add a minimal regress test for the http client code.
This currently uses some external website to do redirect test and
to check both regular and chunked downloads.
Only for libressl because you can't mix openssl 1.1 and libtls on OpenBSD.
tobhe [Fri, 9 Apr 2021 09:15:04 +0000 (09:15 +0000)]
Only modify routes if SA has a valid address lease. On IKE SA rekey
sa_cp_addr and sa_cp_addr6 are moved to the new SA before the old
SA is deleted.
Fixes a bug where host routes were deleted on IKE SA rekey.
ok patrick@
nicm [Fri, 9 Apr 2021 07:02:00 +0000 (07:02 +0000)]
Change a type to fix a warning with some compilers.
claudio [Fri, 9 Apr 2021 06:52:50 +0000 (06:52 +0000)]
Tidy up the http state machine a bit. Make sure that http_nextstate() runs
until an error or an IO opperation is needed. In other words it should not
return 0. Because of this adjust the http_tls_connect() call a bit. Also
call http_connect() in http_redirect() instead of needing an extra step
in the state machine. Last but not least make sure that http_handle() does
only one IO operation and check for possible POLLHUP event.
OK tb@
otto [Fri, 9 Apr 2021 06:05:21 +0000 (06:05 +0000)]
An extra internal consistency check and a missing stats adjustment. ok tb@
otto [Fri, 9 Apr 2021 06:04:15 +0000 (06:04 +0000)]
Cache implementation has changed, we do not hold on to an exact number
of pages anymore, but also cache larger regions; ok tb@
tb [Fri, 9 Apr 2021 05:54:00 +0000 (05:54 +0000)]
Fix release time
ok deraadt
job [Thu, 8 Apr 2021 19:49:27 +0000 (19:49 +0000)]
Expose two extra metrics via JSON
This removes some of the needs of rpki-client affiniadios who
screen-scrape rpki-client's STDOUT.
OK deraadt@
deraadt [Thu, 8 Apr 2021 19:14:26 +0000 (19:14 +0000)]
sync
claudio [Thu, 8 Apr 2021 18:35:02 +0000 (18:35 +0000)]
Increase buffer size for http_info a bit. 64 chars is a bit short for
RRDP URLs.
claudio [Thu, 8 Apr 2021 18:32:55 +0000 (18:32 +0000)]
Refactor the regular and chunked data write so that one function can
handle both cases. Simplifies the code a fair bit.
OK tb@
kn [Thu, 8 Apr 2021 17:29:17 +0000 (17:29 +0000)]
Do not request unused "classless-static-routes" dhcp-options(5)
Doing so implies support for it, but dhcpleased(8) currently ingores it
entirely and does not configure any route from it.
As per RFC 3442 servers SHOULD NOT respond with a "routers" option when
"classless-static-routes" is set.
dhcpd(8)/dhcpd.conf(5) follows that, hence requesting but not using static
routes results in not installing any routes at all.
Stop signaling support for this option and only request "routers" such that
dhcpleased continues to install a default route and properly ignores the
unsupported option if used by the server.
Report from Uwe Werler <uwe @ werler dot is> about a default route not
being set when requesting the "classless-static-routes" dhcp-options(5)
from dhcpd(8), thanks!
OK florian
tb [Thu, 8 Apr 2021 17:11:43 +0000 (17:11 +0000)]
Enable test-cve-2016-6309.py
claudio [Thu, 8 Apr 2021 17:07:55 +0000 (17:07 +0000)]
Switch logic from != to ==. Makes the code easier to read.
claudio [Thu, 8 Apr 2021 16:56:34 +0000 (16:56 +0000)]
Change the order of the poll loop to first process active http connections
and then accept new ones. This way there is no risk of processing a new
connection before poll() was called.
OK tb@ as part of a larger diff
claudio [Thu, 8 Apr 2021 16:46:59 +0000 (16:46 +0000)]
Shuffle deck chairs so that the order is more logical (at least for me).
No functional change.
claudio [Thu, 8 Apr 2021 16:43:08 +0000 (16:43 +0000)]
Prevent a use-after-free access in case of a http redirect by also clearing
the conn->res pointer after calling freeaddrinfo().
OK tb@ (as part of a bigger diff)
claudio [Thu, 8 Apr 2021 16:32:42 +0000 (16:32 +0000)]
More cleanup of the main function. Use a loop to collect all childs with
waitpid() and print if they exited non-zero or by a signal. Also adjust
the poll hangup case to exit the poll loop instead of erroring out. This
way a crashed child should be reported before exit.
OK job@ tb@
claudio [Thu, 8 Apr 2021 15:31:14 +0000 (15:31 +0000)]
Missing setproctitle("rrdp") noticed by deraadt@
nicm [Thu, 8 Apr 2021 14:16:12 +0000 (14:16 +0000)]
Log the key written to the terminal as well as tmux's idea of what it
is.
job [Thu, 8 Apr 2021 14:03:32 +0000 (14:03 +0000)]
reword manpage on -n
OK claudio@
danj [Thu, 8 Apr 2021 11:56:30 +0000 (11:56 +0000)]
The path with the *highest* local weight is selected
ok kn
jmc [Thu, 8 Apr 2021 11:53:16 +0000 (11:53 +0000)]
fix SEE ALSO, and tidy up the text a little;
jmc [Thu, 8 Apr 2021 11:52:27 +0000 (11:52 +0000)]
tidy up AUTHORS with -nosplit;
tb [Wed, 7 Apr 2021 21:48:23 +0000 (21:48 +0000)]
Avoid clobbering the error code when sending an alert
In order to fail gracefully on encountering a self-signed cert, curl looks
at the top-most error on the stack and needs specific SSL_R_ error codes.
This mechanism was broken when the tls13_alert_sent_cb() was added after
people complained about unhelpful unknown errors. Fix this by only setting
the error code from a fatal alert if no error has been set previously.
Issue reported by Christopher Reid
ok jsing
tb [Wed, 7 Apr 2021 17:21:40 +0000 (17:21 +0000)]
Use ERR_print_error_fp() to avoid leaking a BIO in fatal()
kettenis [Wed, 7 Apr 2021 17:13:38 +0000 (17:13 +0000)]
graphaudio(4)