bluhm [Fri, 19 Jul 2024 15:41:58 +0000 (15:41 +0000)]
Relax socket lock assertion in UDP input and send.
OK mvs@
bluhm [Fri, 19 Jul 2024 15:28:51 +0000 (15:28 +0000)]
unveil(2) /etc/gettytab.db in getty(8) to avoid possible violation.
OK deraadt@
deraadt [Fri, 19 Jul 2024 14:32:56 +0000 (14:32 +0000)]
sync
jsing [Fri, 19 Jul 2024 08:56:17 +0000 (08:56 +0000)]
Annotate issues with tls_session_secret_cb() related code.
jsing [Fri, 19 Jul 2024 08:54:31 +0000 (08:54 +0000)]
Move client ciphers from SSL_SESSION to SSL_HANDSHAKE.
SSL_SESSION has a 'ciphers' member which contains a list of ciphers
that were advertised by the client. Move this from SSL_SESSION to
SSL_HANDSHAKE and rename it to match reality.
ok tb@
djm [Fri, 19 Jul 2024 04:33:36 +0000 (04:33 +0000)]
test transfers in mux proxy mode too
chrisz [Fri, 19 Jul 2024 04:26:23 +0000 (04:26 +0000)]
Keep Content-length header in HEAD responses.
ok millert@
yasuoka [Thu, 18 Jul 2024 22:40:09 +0000 (22:40 +0000)]
Send Access-Reject when the authentication is not handled or the user
is not found.
yasuoka [Thu, 18 Jul 2024 22:18:00 +0000 (22:18 +0000)]
unveil .db is needed. Also move pledge() earlier.
kettenis [Thu, 18 Jul 2024 17:18:01 +0000 (17:18 +0000)]
Fix typos in previous commit spotted by naddy@
millert [Thu, 18 Jul 2024 15:38:57 +0000 (15:38 +0000)]
The source of a link (name1) may not be a directory.
POSIX says this is implementation-dependent; OpenBSD does not allow
it. OK guenther@
bluhm [Thu, 18 Jul 2024 14:46:28 +0000 (14:46 +0000)]
In pfattach() pass malloc type instead of flags to cpumem_malloc().
from markus@
deraadt [Thu, 18 Jul 2024 11:21:10 +0000 (11:21 +0000)]
sync
yasuoka [Thu, 18 Jul 2024 08:58:59 +0000 (08:58 +0000)]
Fix memory leaks and improve id handling of iked_radserver_req.
original diff from markus
ok tobhe
jmc [Thu, 18 Jul 2024 05:44:46 +0000 (05:44 +0000)]
remove extra punctuation; from alexander arch
yasuoka [Thu, 18 Jul 2024 02:45:31 +0000 (02:45 +0000)]
Since libcrypto is used to calc message authenticator, use libcrypto
md5 also in other places instead libc md5.
ok millert
djm [Thu, 18 Jul 2024 01:47:27 +0000 (01:47 +0000)]
mention mux proxy mode
yasuoka [Thu, 18 Jul 2024 00:28:53 +0000 (00:28 +0000)]
Add a link to radiud_file(8)
millert [Wed, 17 Jul 2024 20:57:15 +0000 (20:57 +0000)]
sed: use warn()/err() where appropriate
Use warn()/err() instead of sed's homegrown warning()/error() for
things other than parser problems. The warning()/error() functions
display the file and line number in addition to the error message.
This also removes of the COMPILE/FATAL argument to error() since
now all calls to error() are for compilation/parsing issues.
OK op@ espie@
yasuoka [Wed, 17 Jul 2024 20:50:28 +0000 (20:50 +0000)]
Add Message-Authenticator attriubte when sending Access-Request.
ok millert
tb [Wed, 17 Jul 2024 15:22:56 +0000 (15:22 +0000)]
Add RCS id
kettenis [Wed, 17 Jul 2024 15:21:59 +0000 (15:21 +0000)]
Clean up the cpi_id_aa64xxx variables at the end of autoconf such that
sysclt(2) and ID register access emulation can share the variables.
ok jca@
jsing [Wed, 17 Jul 2024 15:01:22 +0000 (15:01 +0000)]
Enable regress for SSL_CIPHER_get_handshake_digest()
Turns out this is already linked statically.
deraadt [Wed, 17 Jul 2024 14:57:59 +0000 (14:57 +0000)]
sync
jsing [Wed, 17 Jul 2024 14:51:54 +0000 (14:51 +0000)]
Rework cipher find test to also provide coverage for SSL_CIPHER_*()
claudio [Wed, 17 Jul 2024 13:29:05 +0000 (13:29 +0000)]
Be clear that RUSAGE_CHILDREN only works for terminated children that have
been waited for. If you SIG_IGN SIGCHLD or don't call any of the wait
functions then RUSAGE_CHILDREN wont report anything.
OK deraadt@ millert@
yasuoka [Wed, 17 Jul 2024 11:31:46 +0000 (11:31 +0000)]
Fix some gcc warnings
deraadt [Wed, 17 Jul 2024 11:20:24 +0000 (11:20 +0000)]
minor repairs
yasuoka [Wed, 17 Jul 2024 11:19:27 +0000 (11:19 +0000)]
Error if config parameter is unknown. This also fixes a gcc warning.
spotted by deraadt
yasuoka [Wed, 17 Jul 2024 11:13:22 +0000 (11:13 +0000)]
Document "authentication-filter".
yasuoka [Wed, 17 Jul 2024 11:05:11 +0000 (11:05 +0000)]
Decrypt "Password" attribute always before passing the packet to
modules. Also, don't assume the authenticator of the packet from the
module that has no secret is valid.
yasuoka [Wed, 17 Jul 2024 10:15:39 +0000 (10:15 +0000)]
Delete log_info() line for debug.
claudio [Wed, 17 Jul 2024 09:54:14 +0000 (09:54 +0000)]
Sync struct proc P_BITS with reality.
Remove "\027XX" (old systrace flag) and "\035SOFTDEP".
OK jsg@
yasuoka [Wed, 17 Jul 2024 08:26:19 +0000 (08:26 +0000)]
Fix indent
millert [Wed, 17 Jul 2024 03:05:19 +0000 (03:05 +0000)]
Display an error message for "sed -i" if the file is unwritable
Previously, sed would fail silently if it was unable to move the
temporary file into place. Also allow "sed -i" on symbolic link--the
link will be broken but this matches GNU sed behavior. From espie@
OK op@
jsing [Tue, 16 Jul 2024 14:38:59 +0000 (14:38 +0000)]
Update regress for removal of SSL_HANDSHAKE_MAC_DEFAULT.
jsing [Tue, 16 Jul 2024 14:38:04 +0000 (14:38 +0000)]
Clean up SSL_HANDSHAKE_MAC_DEFAULT.
The handshake MAC needs to be upgraded when TLSv1.0 and TLSv1.1
ciphersuites are used with TLSv1.2. Since we no longer support TLSv1.0
and TLSv1.1, we can simply upgrade the handshake MAC in the ciphersuite
table and remove the various defines/macros/code that existed to handle
the upgrade.
ok tb@
tb [Tue, 16 Jul 2024 10:19:38 +0000 (10:19 +0000)]
Fix .Ox for SSL_CIPHER_get_handshake_digest()
deraadt [Tue, 16 Jul 2024 08:25:47 +0000 (08:25 +0000)]
sync
miod [Tue, 16 Jul 2024 06:18:20 +0000 (06:18 +0000)]
Only perform the static_assert checks in C>=11 environment; unbreaks build
on platforms using gcc.
deraadt [Tue, 16 Jul 2024 05:01:10 +0000 (05:01 +0000)]
Fix the SIGHUP signal race. ed's "event loop" operates a getchar(); check
the hup flag before and after that call, when the buffer structures are stable
for write_file() to work. Remove the hup handling from the SPL0() macro,
because this is run in at least one place during structure instability.
The SIGINT handler, which uses siglongjmp(), is also trusting the SPL1/SPL0
dance more than it should.
ok millert
jsg [Tue, 16 Jul 2024 01:14:23 +0000 (01:14 +0000)]
match on Atom C3000
from and tested by Brendan Shanks
tb [Mon, 15 Jul 2024 18:50:42 +0000 (18:50 +0000)]
Switch the EVP_PKEY_*attr* API to LCRYPTO_UNUSED()
This would have prevented the PKCS12 oopsie.
tb [Mon, 15 Jul 2024 15:43:25 +0000 (15:43 +0000)]
Fix PKCS12_create()
This tries to copy some microsoft attributes which are not usually present
and chokes on the now disabled EVP_PKEY_*attr* API. Instead of reviving
about four layers of traps and indirection, just inline the two functions
in a way that should be more obvious.
found by anton via the ruby-openssl tests
ok jsing
mglocker [Mon, 15 Jul 2024 15:33:54 +0000 (15:33 +0000)]
Make the touchpad on the Samsung Galaxy Book4 Edge work.
ok patrick@
jsing [Mon, 15 Jul 2024 14:45:15 +0000 (14:45 +0000)]
Mop up TLS1_PRF* defines.
These have not been used for a long time, however SSL_CIPHER was not opaque
at the time, hence they had to stick around. Now that SSL_CIPHER is opaque
we can simply mop them up.
ok tb@
martijn [Mon, 15 Jul 2024 13:32:50 +0000 (13:32 +0000)]
Add e2fs_fsmnt, and the newly defined e2fs_kbytes_written to the list of
fields that can differ between the primary and 1st backup superblock.
This fixes fsck issues I've encountered on my system with a shared home
partition.
OK miod@
martijn [Mon, 15 Jul 2024 13:27:36 +0000 (13:27 +0000)]
Add ext4 field definitions. Taken from NetBSD, with some cosmetic
changes to keep it in line with our style.
OK miod@
anton [Mon, 15 Jul 2024 10:11:56 +0000 (10:11 +0000)]
fix signature of main()
patrick [Mon, 15 Jul 2024 09:56:30 +0000 (09:56 +0000)]
Add support for the RK3588 eMMC controller. This is mostly the same, with
some HS400 bits that we don't support yet. While there, fix some constants
that weren't applied to the correct registers.
ok dlg@
patrick [Mon, 15 Jul 2024 09:54:38 +0000 (09:54 +0000)]
Add RK3588 eMMC clocks and resets.
ok dlg@
jsg [Mon, 15 Jul 2024 07:24:03 +0000 (07:24 +0000)]
sync PS_BITS with flags; ok claudio@
jmc [Mon, 15 Jul 2024 05:36:08 +0000 (05:36 +0000)]
bioctl.8:
- tweak bioctl text
- don;t repeat the device examples
- reinstate softraid device being always softraid0
usage():
- add vertical blank between two formats
- rewrap to match 80col (shorter and matches man)
feedback/ok krw kn
anton [Mon, 15 Jul 2024 05:24:02 +0000 (05:24 +0000)]
enable warnings and apply a dash of knfmt
jsg [Mon, 15 Jul 2024 00:11:59 +0000 (00:11 +0000)]
ocurred -> occurred
sashan [Sun, 14 Jul 2024 19:51:08 +0000 (19:51 +0000)]
This change allows user to define table inside the anchor like that:
anchor foo {
table <bar> { 192.168.1.1 }
pass in from <bar> to <self>
}
Without this diff one must either create table <bar> in main
ruleset (root) or use 'pfctl -a foo -t bar -T add 192.168.1.1'
This glitch is hard to notice. Not many human admins try to attach
tables to non-global anchors. Deamons which configure pf(4) automatically
at run time such as relayd(8) and spamd(8) create tables attached to
thair anchors (for example 'relayd/*') but the deamons use way similar
to pfctl(8) to add and manage those tables.
The reason why I'd like to seal this gap is that my long term goal
is to turn global `pfr_ktable` in pf(4) into member of pf_anchor.
So each ruleset will get its own tree of tables.
feedback and OK bluhm@
miod [Sun, 14 Jul 2024 19:33:59 +0000 (19:33 +0000)]
Add missing <machine/elf.h> for compound arches.
The spice^Wkernel must flow^Wbuild.
bluhm [Sun, 14 Jul 2024 18:53:39 +0000 (18:53 +0000)]
Unlock IPv6 sysctl net.inet6.ip6.forwarding from net lock.
Use atomic operations to read ip6_forwarding while processing packets
in the network stack.
To make clear where actually the router property is needed, use the
i_am_router variable based on ip6_forwarding. It already existed
in nd6_nbr. Move i_am_router setting up the call stack until all
users are independent.
The forwarding decisions in pf_test, pf_refragment6, ip6_input do
also not interfere.
Use a new array ipv6ctl_vars_unlocked to make transition of all the
integer sysctls easier. Adapt IPv4 to the new style.
OK mvs@
anton [Sun, 14 Jul 2024 18:49:32 +0000 (18:49 +0000)]
enable warnings and fix complaints
jmc [Sun, 14 Jul 2024 18:11:18 +0000 (18:11 +0000)]
fix SEE ALSO and a word tweak;
jmc [Sun, 14 Jul 2024 18:09:05 +0000 (18:09 +0000)]
grammar and macro tweaks;
jmc [Sun, 14 Jul 2024 18:03:59 +0000 (18:03 +0000)]
zap a stray Nd line;
yasuoka [Sun, 14 Jul 2024 16:22:59 +0000 (16:22 +0000)]
Add radiusd_file(5) and link it from radiusd.conf(5).
yasuoka [Sun, 14 Jul 2024 16:09:23 +0000 (16:09 +0000)]
Add new radiusd_eap2mschap module. It provides conversions from EAP
to MSCHAPv2.
krw [Sun, 14 Jul 2024 16:09:06 +0000 (16:09 +0000)]
Shuffle verbiage to make page more general. e.g. by mentioning
nvme(4).
Feedback jmc@ jmatthew@ deraadt@ kn@
ok jmc@ kn@
tb [Sun, 14 Jul 2024 16:06:31 +0000 (16:06 +0000)]
Rewrite EVP_PKEY_add1_attr_by_NID()
Instead of jumping through many layers that cause headache, we can achieve
the same in an entirely straightforward way without losing clarity.
ok jsing
tb [Sun, 14 Jul 2024 16:04:10 +0000 (16:04 +0000)]
Disable most EVP_PKEY_*attr* API
There is a single consumer of this entire family of function, namely
the openssl(1) pkcs12 command uses EVP_PKEY_add1_attr_by_NID, so leave
that one intact for now.
ok jsing
tb [Sun, 14 Jul 2024 15:56:08 +0000 (15:56 +0000)]
Forgot to annotate the TMP UGLY CAST[S] as requested by jsing
h/t to levitte
tb [Sun, 14 Jul 2024 15:48:24 +0000 (15:48 +0000)]
Document SSL_CIPHER_get_handshake_digest(3)
bluhm [Sun, 14 Jul 2024 15:42:23 +0000 (15:42 +0000)]
Fix source and drain confusion in socket splicing somove().
If a large mbuf in the source socket buffer does not fit into the
drain buffer, split the mbuf. But if the drain buffer still has
some data in it, stop moving data and try again later. This skips
a potentially expensive mbuf operation.
When looking which socket buffer has to be locked, I found that the
length of the source send buffer was checked. Change it to drain.
As this is a performance optimization for a special corner case,
noone noticed the bug.
OK sashan@
tb [Sun, 14 Jul 2024 15:39:36 +0000 (15:39 +0000)]
Prepare to provide SSL_CIPHER_get_handshake_digest()
Needed by newer freeradius. This is a straightforward implementation that
essentially duplicates tls13_cipher_hash().
ok jsing
yasuoka [Sun, 14 Jul 2024 15:31:49 +0000 (15:31 +0000)]
Move radius_attr_{,un}hide() to radius_subr.c.
yasuoka [Sun, 14 Jul 2024 15:27:57 +0000 (15:27 +0000)]
Add "authentication-filter". Add new 2 imsg types so that
authentication modules can request the next authentication and the
next authentication can receive the result of the previous and modify
the result.
yasuoka [Sun, 14 Jul 2024 15:13:41 +0000 (15:13 +0000)]
Set length of MPPE send/recv key.
jsing [Sun, 14 Jul 2024 14:32:45 +0000 (14:32 +0000)]
Remove lhash_local.h.
lhash_local.h was previously needed since conf/conf_api.c and
objects/obj_dat.c were fiddling with lhash internals when deleting via a
callback. Since we no longer need to do that, inline the structs in
lhash.c and remove the header.
ok tb@
jca [Sun, 14 Jul 2024 14:32:02 +0000 (14:32 +0000)]
Zap trailing whitespace
Dummy commit to trigger the git exporter.
jmatthew [Sun, 14 Jul 2024 14:04:16 +0000 (14:04 +0000)]
Only match if we can find a corresponding cpu device. This means the
many extra ACPI0007 instances found in current generation servers no
longer fill up dmesg with noise.
ok kettenis@
jmatthew [Sun, 14 Jul 2024 13:58:57 +0000 (13:58 +0000)]
For specific hids (currently only ACPI0007, acpicpu(4)), use a print
function that always returns QUIET so instances that don't get matched
are not reported.
ok kettenis@
yasuoka [Sun, 14 Jul 2024 13:44:30 +0000 (13:44 +0000)]
Add radiusd_file(8) module. It provides authencation by a local file.
yasuoka [Sun, 14 Jul 2024 13:36:44 +0000 (13:36 +0000)]
Add "radiusd" field to struct radius_query.
millert [Sun, 14 Jul 2024 13:31:50 +0000 (13:31 +0000)]
Fix printf(3) signal safety for wide character strings.
The %ls (wide char string) support in printf(3) currently uses
malloc(3), which violates the promise in in sigaction(2). This
makes it use mmap(2) instead. OK deraadt@
tobhe [Sun, 14 Jul 2024 13:13:33 +0000 (13:13 +0000)]
Fail explicitly on unexptected imsg->hdr_type. Otherwise the following
comparison is undefined.
jca [Sun, 14 Jul 2024 11:36:54 +0000 (11:36 +0000)]
Actually provide *definitions* for hwcap & hwcap2
Double checked by kettenis@
Sorry for the time window with breakage visible on arm64 and riscv64. :-/
jca [Sun, 14 Jul 2024 11:14:29 +0000 (11:14 +0000)]
Actually set up hwcap AUX_* entries when available
Erroneously dropped from the last elf_aux_info(3) diff I sent on tech@.
Lack of this chunk would affect arm64 and riscv64 as they're the two
architectures providing hwcap*.
Should have been ok kettenis@
yasuoka [Sun, 14 Jul 2024 11:12:32 +0000 (11:12 +0000)]
Mistakenly the same challenge is used for testing CHAP.
yasuoka [Sun, 14 Jul 2024 10:52:50 +0000 (10:52 +0000)]
Make the lines of md5chap understandable.
kettenis [Sun, 14 Jul 2024 10:50:39 +0000 (10:50 +0000)]
In addition to setting the PCI power state, also run the appropriate _PSx
method that matches the target state.
ok deraadt@
kettenis [Sun, 14 Jul 2024 10:48:55 +0000 (10:48 +0000)]
Upon first suspend, turn off all power resources that haven't been
referenced.
ok deraadt@
jsg [Sun, 14 Jul 2024 10:19:23 +0000 (10:19 +0000)]
fix double word; ok dtucker@
jca [Sun, 14 Jul 2024 10:04:17 +0000 (10:04 +0000)]
Add wcsnlen(3) declaration, missed in previous.
jca [Sun, 14 Jul 2024 09:57:11 +0000 (09:57 +0000)]
Sync sets after elf_aux_info(3) and wcsnlen(3) additions + libc bump
jca [Sun, 14 Jul 2024 09:54:56 +0000 (09:54 +0000)]
Bump minor after elf_aux_info(3) and wcsnlen(3) additions
jca [Sun, 14 Jul 2024 09:51:18 +0000 (09:51 +0000)]
Add wcsnlen(3), wcslen(3) with a max len argument
Missing function hit by fcambus@ some time ago. ok millert@
jca [Sun, 14 Jul 2024 09:48:48 +0000 (09:48 +0000)]
Add elf_aux_info(3)
Designed to let userland peek at AT_HWCAP and AT_HWCAP2 using an already
existing interface coming from FreeBSD. Headers bits were snatched from
there. Input & ok kettenis@
libc bump and sets sync will follow soon
deraadt [Sun, 14 Jul 2024 09:41:43 +0000 (09:41 +0000)]
sync
matthieu [Sun, 14 Jul 2024 09:39:15 +0000 (09:39 +0000)]
Add /usr/X11R6/include/va. ok tb@
florian [Sun, 14 Jul 2024 08:57:32 +0000 (08:57 +0000)]
sync slaacd(8) log.c to dhcpleased(8)'s version.
We don't built log.c on the ramdisk so no need for ifndef small.
florian [Sun, 14 Jul 2024 08:45:05 +0000 (08:45 +0000)]
log_getverbose() is a void function
pointed out by tb
florian [Sun, 14 Jul 2024 08:41:54 +0000 (08:41 +0000)]
sync slaacd(8) log.h to dhcpleased(8) log.h
- include stdlib.h for exit(3)
- knf fixes
- define log_getverbose as (0) instead of 0
input & OK tb
dv [Sun, 14 Jul 2024 07:57:42 +0000 (07:57 +0000)]
vmm(4)/vmx: update host cr3, invept on cpu migration.
Since vmm handles nested page faults in the vcpu run loop, trying
to avoid trips back to userland, it's possible for the thread to
move host cpus. vmm(4) already updates some local cpu state when
this happens, but also needs to update the host cr3 in the vmcs to
allow vmx to restore the proper cr3 value on the next vm exit.
Additionally, we should be flushing the ept cache on the new cpu.
If the single context flush is available, use that instead of the
global flush.
ok mlarkin@