beck [Sat, 26 Apr 2014 18:56:37 +0000 (18:56 +0000)]
Replace all use of ERR_add_error_data with ERR_asprintf_error_data.
This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@
todd [Sat, 26 Apr 2014 15:45:53 +0000 (15:45 +0000)]
sync
mpi [Sat, 26 Apr 2014 14:26:48 +0000 (14:26 +0000)]
Do not pass a NULL argument to OF_getprop(), even if it's fine for the
moment since we use an intermediate buffer and we specify a length of 0,
there's no need for an exception here.
Noticied while playing with the virtual-mode client interface of firmware.
mpi [Sat, 26 Apr 2014 14:19:04 +0000 (14:19 +0000)]
Allow to compile with DEBUG_PMAP defined.
jsing [Sat, 26 Apr 2014 13:07:16 +0000 (13:07 +0000)]
More KNF.
jsing [Sat, 26 Apr 2014 13:04:24 +0000 (13:04 +0000)]
KNF.
millert [Sat, 26 Apr 2014 11:53:05 +0000 (11:53 +0000)]
Kill the link to /usr/bin/page. OK henning@ jmc@ miod@ schwarze@
sthen [Sat, 26 Apr 2014 11:28:49 +0000 (11:28 +0000)]
fix whitespace
sthen [Sat, 26 Apr 2014 11:27:23 +0000 (11:27 +0000)]
Only remove queues from the TAILQ when the ticket changes; fixes PPS/BPS
displays for queues in "systat q". From Arto Jonsson.
jsing [Sat, 26 Apr 2014 11:08:59 +0000 (11:08 +0000)]
This is not FreeBSD.
ok miod@
jsing [Sat, 26 Apr 2014 11:08:10 +0000 (11:08 +0000)]
Do you really want to build OpenSSL for 16-bit Windows? Well, we don't.
ok miod@
florian [Sat, 26 Apr 2014 11:02:45 +0000 (11:02 +0000)]
Link traceroute6 to traceroute, thus completing the merge.
I was originally sent on this little errand by deraadt@.
OK sthen@, benno@
(Committing from a bus somewhere in germany on its way to berlin.)
jsg [Sat, 26 Apr 2014 06:17:26 +0000 (06:17 +0000)]
remove a duplicate break statement
shadchin [Sat, 26 Apr 2014 05:58:43 +0000 (05:58 +0000)]
Revert 1.11. That patch is not only not necessary, it is quite harmful now.
ok schwarze@
mlarkin [Sat, 26 Apr 2014 05:43:00 +0000 (05:43 +0000)]
Perform MAXPHYS-sized reads for the chunktable instead of PAGE_SIZE-sized
reads.
Also fix a VA leak in the chunktable read error path.
jmc [Fri, 25 Apr 2014 22:28:42 +0000 (22:28 +0000)]
discussing terminfo is not needed; ok schwarze
schwarze [Fri, 25 Apr 2014 20:33:05 +0000 (20:33 +0000)]
This manual was lacking it's most important section, HISTORY.
While here, add .An (author name) macros.
schwarze [Fri, 25 Apr 2014 20:23:37 +0000 (20:23 +0000)]
Security is square, gaming is hip,
so extend the Valhalla Rampage to where it really matters.
Tedu 118 lines of dead code containing 77 dead magic numbers,
rotting in the tree since June 24, 2001.
Spotted by and ok jsg@, ok sthen@.
halex [Fri, 25 Apr 2014 19:34:24 +0000 (19:34 +0000)]
filter excess data from autoinstall output *before* it ends up in the
log file on the ramdisk, in order not to run out of its precious space
reported by, tested and ok sebastia@
schwarze [Fri, 25 Apr 2014 18:07:41 +0000 (18:07 +0000)]
Make more(1) POSIX compliant with respect to the -e option.
By default, "more" now works like "less -e", and "more -e" now
works like "less -E", and more never exits just because the file
fits on the first screen, like "less -F" would.
While documenting this, add some text to the DESCRIPTION explaining
how paging works. That allows a very concise description of -e.
code change ok millert@
manual page joint work with and ok jmc@
bluhm [Fri, 25 Apr 2014 17:59:53 +0000 (17:59 +0000)]
Redirecting stderr to /dev/null suppresses all errors. Instead use
the new status=none feature to make dd quiet.
OK halex@
jmc [Fri, 25 Apr 2014 15:09:56 +0000 (15:09 +0000)]
add traceroute6 to NAME, and knock out some unneeded Bk/Ek;
jmc [Fri, 25 Apr 2014 14:54:45 +0000 (14:54 +0000)]
sort; ok blambert
jsing [Fri, 25 Apr 2014 14:53:22 +0000 (14:53 +0000)]
KNF.
mlarkin [Fri, 25 Apr 2014 14:37:06 +0000 (14:37 +0000)]
Defer the free of the hibernate structures until later, when it is safe to
do so.
Freeing the hibernate structures too early leads to inadvertent calls into
splx when we aren't ready for them yet. Found when trapping splx calls in
the resume path.
discussed with deraadt@ at m2k14
schwarze [Fri, 25 Apr 2014 14:10:59 +0000 (14:10 +0000)]
Fix a minor optimization i broke in bsd.lv rev. 1.163 on August 20, 2010:
Do not bother looking into the hash table when the length of the macro
already tells us it's invalid. No functional change.
Noticed by jsg@, thanks!
jsing [Fri, 25 Apr 2014 14:08:32 +0000 (14:08 +0000)]
Fold in the zlib_cleanup macro.
jsing [Fri, 25 Apr 2014 14:00:15 +0000 (14:00 +0000)]
do_pipe_sig is now only used in openssl.c - just call signal() directly
from there instead and ditch the macro.
jsing [Fri, 25 Apr 2014 13:56:39 +0000 (13:56 +0000)]
NON_MAIN no longer means anything so remove it, along with APP_INIT.
ok miod@
jsing [Fri, 25 Apr 2014 13:55:25 +0000 (13:55 +0000)]
The apps_{startup,shutdown} macro mess is now only used in openssl.c -
reduce the macro to two functions and just call them instead.
ok miod@
shadchin [Fri, 25 Apr 2014 13:38:21 +0000 (13:38 +0000)]
Merge Less 458 plus local patches
ok guenther@, ok jmc@ for man bits
shadchin [Fri, 25 Apr 2014 13:33:39 +0000 (13:33 +0000)]
Import of Less 458
ok guenther@
jsing [Fri, 25 Apr 2014 13:22:38 +0000 (13:22 +0000)]
Clean up the remaining TTY related remnants.
ok miod@
jsg [Fri, 25 Apr 2014 12:45:16 +0000 (12:45 +0000)]
specifying ECHOCTL once is enough
ok nicm@
mpi [Fri, 25 Apr 2014 12:24:31 +0000 (12:24 +0000)]
regen
mpi [Fri, 25 Apr 2014 12:22:15 +0000 (12:22 +0000)]
Add a bunch of GeForce GT{,X} chips listed in nvidia's 334.21 driver.
This includes the GeForce GT 740M submitted by Rafael Neves on tech@,
thanks!
mikeb [Fri, 25 Apr 2014 12:20:17 +0000 (12:20 +0000)]
kill dugsong's debugging leftover; ok sthen, jsg
schwarze [Fri, 25 Apr 2014 12:12:35 +0000 (12:12 +0000)]
Reduce the verbosity of makewhatis -t:
In the past, it always showed the title lines of the files processed.
Now, it only shows them when called with -D.
That is better because pkg_create calls makewhatis -t.
It is also more consistent with -D behaviour in non- -t modes.
Issue reported by ajacoutot@; ok espie@ ajacoutot@ jasper@.
florian [Fri, 25 Apr 2014 12:10:45 +0000 (12:10 +0000)]
MLINKS traceroute.8 traceroute6.8
"sure" jmc@
florian [Fri, 25 Apr 2014 12:10:14 +0000 (12:10 +0000)]
Merge traceroute6 man page with traceroute.
"sure" jmc@
mpi [Fri, 25 Apr 2014 11:49:47 +0000 (11:49 +0000)]
Sync "struct rt_addrinfo" definition after removal of rti_ifp and kill
a trailing whitespace pointed by jmc@.
blambert [Fri, 25 Apr 2014 11:12:14 +0000 (11:12 +0000)]
Remove NULL pointer dereference, which jsg insists I not
call a use-after free, from error path.
found by and ok jsg@
mpi [Fri, 25 Apr 2014 10:41:09 +0000 (10:41 +0000)]
Remove rti_ifp from rt_addrinfo, one less ifp pointer, say yay!
This pointer was only needed by rt_getifa() to find an address, so
turn it into a local variable.
ok henning@, bluhm@
mpi [Fri, 25 Apr 2014 10:33:36 +0000 (10:33 +0000)]
Do no reprobe for a supported protocol when enabling a pointing
device of type PMS_STANDARD, probing during autoconf(9) is enough!.
In such case, the device can be a simple PS/2 mouse, a unsupported
touchpad or a downgraded touchpad if something bad happened. But
it is very unlikely that reprobing will improve the situation and
transform a standard mouse into a multitouch-aware touchpad ;)
This fixes the 12 seconds delay seen on various Dell laptops (E4310
and Latitude D630) when starting Xorg, reported by Kārlis Miķelsons
on bugs@.
ok stsp@, dcoppa@, shadchin@
jsg [Fri, 25 Apr 2014 09:49:33 +0000 (09:49 +0000)]
test dt_min for invalid minute values instead of testing dt_sec twice
ok bmercer@
mpi [Fri, 25 Apr 2014 09:44:38 +0000 (09:44 +0000)]
Kill in_localaddr(), one less usage of the global list of IPv4 addresses.
This function is used only once in our tree to optimize the size of the
MSS if the forward address correspond to a host on one of our subnets,
but only if ip.mutdisc is disable, which is not the default!
While here get rid of the "#ifdef RTV_MTU", it is here.
ok henning@, mikeb@, bluhm@
jsg [Fri, 25 Apr 2014 09:41:21 +0000 (09:41 +0000)]
don't access a pointer till after the null check
ok mikeb@
blambert [Fri, 25 Apr 2014 06:57:11 +0000 (06:57 +0000)]
Support running user-defined actions on receipt of snmp traps.
testing sthen@
much man page guidance jmc@
ok reyk@
jmc [Fri, 25 Apr 2014 06:31:48 +0000 (06:31 +0000)]
be a bit clearer about what this page is; ok millert schwarze
jsing [Fri, 25 Apr 2014 04:10:26 +0000 (04:10 +0000)]
Remove defined varibles that no longer do anything.
ok miod@
jsing [Fri, 25 Apr 2014 04:02:04 +0000 (04:02 +0000)]
Use const char *.
Suggested by miod@
lteo [Fri, 25 Apr 2014 03:38:59 +0000 (03:38 +0000)]
KNF fixes
miod [Thu, 24 Apr 2014 21:31:00 +0000 (21:31 +0000)]
Try to clean the maze of <openssl/bn.h> defines regarding the BN internals.
The intent of this change is to only keep support for two kind of architectures:
- those with 32-bit int and long, and 64-bit long long, where
``long * long -> long long'' multiplication routines are available.
- those with 64-bit int and long, and no 128-bit long long type.
This gets rid of the SIXTY_FOUR_BIT_LONG, SIXTY_FOUR_BIT (not the same!),
THIRTY_TWO_BIT, SIXTEEN_BIT and EIGHT_BIT defines.
After this change, the types and defines are as follows:
arch: 64bit 32bit rationale
BN_LLONG undefined defined defined if l * l -> ll
BN_ULLONG undefined u long long result of BN_LONG * BN_LONG
BN_ULONG u long u int native register size
BN_LONG long int the same, signed
BN_BITS 128 64 size of 2*BN_ULONG in bits
BN_BYTES 8 4 size of 2*BN_ULONG in bytes
BN_BITS2 64 32 BN_BITS / 2
Tested on various 32-bit and 64-bit OpenBSD systems of various endianness.
sthen [Thu, 24 Apr 2014 21:22:05 +0000 (21:22 +0000)]
Re-add rcsid, and switch back to our previous descriptions for -iDsym[=value]
and -iUsym which jmc and I find a bit easier to understand. ok jmc
miod [Thu, 24 Apr 2014 21:07:37 +0000 (21:07 +0000)]
sync
millert [Thu, 24 Apr 2014 20:56:02 +0000 (20:56 +0000)]
Install separate more.1 instead of using a link from less.1.
Requested by jmc@
mcbride [Thu, 24 Apr 2014 20:44:49 +0000 (20:44 +0000)]
Fix indentation.
miod [Thu, 24 Apr 2014 19:54:04 +0000 (19:54 +0000)]
Bring back the SSL_OP_PKCS1_CHECK_* defines (defined to zero, as they already
were), after stumbling upon code (mis)using them in the wild.
tedu [Thu, 24 Apr 2014 19:38:22 +0000 (19:38 +0000)]
rearrange a bit of code/comments
jmc [Thu, 24 Apr 2014 19:19:28 +0000 (19:19 +0000)]
combine some notes in STANDARDS for consistency;
schwarze [Thu, 24 Apr 2014 19:08:01 +0000 (19:08 +0000)]
document the new makewhatis(8)/apropos(1) database format;
original idea to have some documentation about this by espie@;
ok jmc@
jmc [Thu, 24 Apr 2014 19:07:54 +0000 (19:07 +0000)]
no more kinit(1);
tedu [Thu, 24 Apr 2014 19:04:54 +0000 (19:04 +0000)]
jmc spotted more ruptime tentacles
jmc [Thu, 24 Apr 2014 18:56:24 +0000 (18:56 +0000)]
uses ssh these days, not rsh; ok tedu
jmc [Thu, 24 Apr 2014 18:52:11 +0000 (18:52 +0000)]
no more rwho/ruptime;
giovanni [Thu, 24 Apr 2014 18:35:25 +0000 (18:35 +0000)]
unifdef MSDOS
ok miod@
tedu [Thu, 24 Apr 2014 17:13:11 +0000 (17:13 +0000)]
obvious use after free was less obviously not a use after free.
who uses '\0' as a null pointer constant? fix my mistake and restore
original semantics.
millert [Thu, 24 Apr 2014 16:29:48 +0000 (16:29 +0000)]
Fix logic inversion when checking environment variables on the
command line against the blacklist. This is only a problem when
env_reset is disabled. CVE 2014-0106
jsing [Thu, 24 Apr 2014 15:50:02 +0000 (15:50 +0000)]
More KNF.
jsg [Thu, 24 Apr 2014 15:38:25 +0000 (15:38 +0000)]
no need to check for default_chip_map twice in one if statement
jsing [Thu, 24 Apr 2014 15:38:13 +0000 (15:38 +0000)]
Make it compile again.
jsing [Thu, 24 Apr 2014 15:12:20 +0000 (15:12 +0000)]
Remove some malloc/strlcpy/strlcat horror. Just use asprintf and avoid an
unchecked malloc at the same time.
ok beck@
aoyama [Thu, 24 Apr 2014 15:09:35 +0000 (15:09 +0000)]
regen
beck [Thu, 24 Apr 2014 15:07:20 +0000 (15:07 +0000)]
add ERR_asprintf_error_data, A tool to be used to get rid of the far too
frequent construct of 30 lines of pointer and strlcat insanity followed
by an ERR_add_error_data. I will sweep through here like a chubby mongol
horde in the next few days pillaging crappy ERR_add_error_data's.
Oh and while we're at it fix the nasty vdata function to use something less
hard on the eyes.
ok jsing@
tedu [Thu, 24 Apr 2014 15:05:10 +0000 (15:05 +0000)]
rm rwhod tentacles
tedu [Thu, 24 Apr 2014 15:03:04 +0000 (15:03 +0000)]
rm rwho xr
tedu [Thu, 24 Apr 2014 15:01:27 +0000 (15:01 +0000)]
I have not eaten for days.
And who says you will?
aoyama [Thu, 24 Apr 2014 15:01:12 +0000 (15:01 +0000)]
regen
tedu [Thu, 24 Apr 2014 14:59:06 +0000 (14:59 +0000)]
That is strength, boy! That is power! What is steel compared to the hand
that wields it? Look at the strength in your body, the desire in your
heart, I gave you this! Such a waste. Contemplate this on the tree of woe.
tedu [Thu, 24 Apr 2014 14:55:39 +0000 (14:55 +0000)]
days since rwhod was useful: 5475
aoyama [Thu, 24 Apr 2014 14:52:09 +0000 (14:52 +0000)]
Add pcex{mem,io} entries to MAKEDEV.
ok miod@
jmc [Thu, 24 Apr 2014 14:14:08 +0000 (14:14 +0000)]
remove kerberos reference, and knock some fairly useless Xr out;
jsing [Thu, 24 Apr 2014 14:03:38 +0000 (14:03 +0000)]
You want signals?!? I'll give you signals!!! Oh, and we have termios as
well...
ok beck@
jmc [Thu, 24 Apr 2014 14:00:35 +0000 (14:00 +0000)]
simpler description for -P, avoiding the need to discuss rsh;
jmc [Thu, 24 Apr 2014 13:48:38 +0000 (13:48 +0000)]
no more asn1 or comm_err;
jmc [Thu, 24 Apr 2014 13:41:39 +0000 (13:41 +0000)]
adjust some list widths;
jsing [Thu, 24 Apr 2014 13:12:18 +0000 (13:12 +0000)]
More KNF.
mcbride [Thu, 24 Apr 2014 13:06:52 +0000 (13:06 +0000)]
More KNF, things that couldn't be verified with md5(1), and some whitespace
I missed on the first go around.
jsing [Thu, 24 Apr 2014 12:39:02 +0000 (12:39 +0000)]
unifdef -U LINT
jsing [Thu, 24 Apr 2014 12:22:22 +0000 (12:22 +0000)]
When OPENSSL_C is not defined, apps_startup becomes a
signal(SIGPIPE, SIG_IGN) and apps_shutdown is a no-op. So just do that
instead.
ok beck@
mcbride [Thu, 24 Apr 2014 12:21:26 +0000 (12:21 +0000)]
KNF
jsing [Thu, 24 Apr 2014 12:19:59 +0000 (12:19 +0000)]
Remove more FIPS tenticles.
ok beck@
jsing [Thu, 24 Apr 2014 12:04:31 +0000 (12:04 +0000)]
Rip a bunch of ifdefs from speed. We know we can fork, have SIGALRM and
do not use lint.
ok miod@
henning [Thu, 24 Apr 2014 11:55:12 +0000 (11:55 +0000)]
ewps... repair qid assignment
mpi [Thu, 24 Apr 2014 09:40:28 +0000 (09:40 +0000)]
Change the usbd_*_report() family of functions to take a usbd_device
and a infaceno argument instead of an iface pointer. While here,
remove some unused functions and inlined usbd_read_report_desc since
it is used only once.
This is part of plumbing required to convert the various USB HID devices
to handle multiples report IDs.
ok andre@
nicm [Thu, 24 Apr 2014 09:14:43 +0000 (09:14 +0000)]
There is no longer a need for a paste_stack struct or for global_buffers
to be global. Move to paste.c.
bluhm [Thu, 24 Apr 2014 09:05:10 +0000 (09:05 +0000)]
The switch statement given/when was introduced in Perl 5.10 and got
experimental in Perl 5.18. So we see warnings in the tests.
given is experimental at funcs.pl line 62.
when is experimental at funcs.pl line 63.
Just suppress this type of warnings for now. If Perl will disable
smart match, the simple regression code still works. If they will
choose to remove given/when, we can fix it later.
Discussed with and OK andre@ afresh1@
blambert [Thu, 24 Apr 2014 08:51:08 +0000 (08:51 +0000)]
fix copied text in error string
ok reyk@
beck [Thu, 24 Apr 2014 06:02:58 +0000 (06:02 +0000)]
A fantastic way to make a large unsigned number is to assign
a small signed one to it.. Some people on OpenSSL's list
noticed - http://marc.info/?l=openssl-dev&m=
139809485525663&w=2
This should fix that, and make sure we don't try to write out insane
amounts of stuff.
ok miod@ tedu@
tedu [Thu, 24 Apr 2014 04:45:43 +0000 (04:45 +0000)]
remove redundant asign. from David Hill