claudio [Mon, 12 Apr 2021 17:23:30 +0000 (17:23 +0000)]
Cast XML_GetCurrentLineNumber() to unsigned long long in warnx since
expat my either use unsigned long or unsigened long long as return value
depending on compile options. This upcast is an easy way around this issue.
OK deraadt@
claudio [Mon, 12 Apr 2021 10:03:33 +0000 (10:03 +0000)]
Spaces, no functional change
nicm [Mon, 12 Apr 2021 09:36:12 +0000 (09:36 +0000)]
Add a flag to disable keys to close a message, GitHub issue 2625.
nicm [Mon, 12 Apr 2021 06:50:25 +0000 (06:50 +0000)]
Permit shortcut keys in buffer, client, tree modes to be configured with
a format; the default remains the line number. GitHub issue 2636.
kn [Mon, 12 Apr 2021 03:17:57 +0000 (03:17 +0000)]
Document bpe(4)
Diff from Marcus MERIGHI <mcmer-openbsd at tor dot at>, thanks.
Feedback OK jmc
OK dlg
tobhe [Sun, 11 Apr 2021 23:27:06 +0000 (23:27 +0000)]
Document 'request' option to request additional configuration payloads.
ok patrick@
dv [Sun, 11 Apr 2021 21:02:40 +0000 (21:02 +0000)]
KNF, capitalization, whitespace
dv [Sun, 11 Apr 2021 18:53:23 +0000 (18:53 +0000)]
Remove dead code for unused IMSG_CTL_NOTIFY messages.
Some vestigial code left over from when priv-sep was implemented.
ok mlarkin@
deraadt [Sun, 11 Apr 2021 17:18:15 +0000 (17:18 +0000)]
Create a sparc64 install*.img file also
tested by kettenis
deraadt [Sun, 11 Apr 2021 16:11:59 +0000 (16:11 +0000)]
vnconfig is run without a label-type (install360), because in-Makefile
scripting calculates msdos+ffs layout, so FSTYPE= is not neccessary.
kettenis [Sun, 11 Apr 2021 15:30:51 +0000 (15:30 +0000)]
On systems that hide the PCI bridge device corresponding to a PCIe RC port
we may end up passing a NULL pointer to pcie_get_speed_cap(). Handle this
by returning PCI_SPEED_UNKNOWN instead of dereferencing a null-pointer.
ok jsg@
dv [Sun, 11 Apr 2021 14:12:42 +0000 (14:12 +0000)]
Correct a comment: reference the correct file
kn [Sun, 11 Apr 2021 14:07:03 +0000 (14:07 +0000)]
bwfm(4) needs firmload
Otherwise compiling a kernel witout any other wifi drivers fails.
OK patrick deraadt
eric [Sun, 11 Apr 2021 07:18:08 +0000 (07:18 +0000)]
do not build unused code and remove uneeded dependency on libm.
ok tb@
tb [Sun, 11 Apr 2021 07:06:01 +0000 (07:06 +0000)]
Update a stale comment and fix a typo.
deraadt [Sun, 11 Apr 2021 02:30:03 +0000 (02:30 +0000)]
sync
job [Sun, 11 Apr 2021 01:20:03 +0000 (01:20 +0000)]
Fix two typos in comments
sure deraadt@
deraadt [Sat, 10 Apr 2021 21:02:36 +0000 (21:02 +0000)]
build arm64 install*.img
requested by kettenis, first testing by kn
florian [Sat, 10 Apr 2021 17:22:34 +0000 (17:22 +0000)]
Make sure the ip header lands on a 4 byte alignment by adding 2 bytes
padding because the ethernet header in front is only 14 bytes.
Found the hard way by me while testing on sparc64.
Solution suggested by & OK deraadt
gnezdo [Sat, 10 Apr 2021 15:26:47 +0000 (15:26 +0000)]
Add cabal-module(5) man page
OK kn
eric [Sat, 10 Apr 2021 10:19:19 +0000 (10:19 +0000)]
remove dead code and unused dependencies
ok tb@
claudio [Sat, 10 Apr 2021 10:10:07 +0000 (10:10 +0000)]
Do not compare TLS config params for non-TLS servers. This allows to
mix 'listen * port 80' and 'listen * tls port 443' in one server block.
Also the last argument of server_tls_cmp - match_keypair - is always 0
so remove this code.
OK florian@ tb@ some long time ago
eric [Sat, 10 Apr 2021 06:44:18 +0000 (06:44 +0000)]
bump smtpd version
mlarkin [Fri, 9 Apr 2021 20:59:03 +0000 (20:59 +0000)]
regen
mlarkin [Fri, 9 Apr 2021 20:58:20 +0000 (20:58 +0000)]
add pcidevs entries for Aquantia ethernet devices
kn [Fri, 9 Apr 2021 20:05:50 +0000 (20:05 +0000)]
It is macobio0; hit with the cluestick from jsg
eric [Fri, 9 Apr 2021 16:43:43 +0000 (16:43 +0000)]
allow to specify tls ciphers and protocols on listeners
ok tb@
martijn [Fri, 9 Apr 2021 14:46:39 +0000 (14:46 +0000)]
When a DHCP server sends an invalid T1 or T2 default back to the default
values as specified in RFC2131 section 4.4.5. Allows my Comtrend VI-3223u
to work.
OK florian@
kn [Fri, 9 Apr 2021 11:36:28 +0000 (11:36 +0000)]
synopsis: macobio0* -> macobio*
claudio [Fri, 9 Apr 2021 10:14:36 +0000 (10:14 +0000)]
Add a minimal regress test for the http client code.
This currently uses some external website to do redirect test and
to check both regular and chunked downloads.
Only for libressl because you can't mix openssl 1.1 and libtls on OpenBSD.
tobhe [Fri, 9 Apr 2021 09:15:04 +0000 (09:15 +0000)]
Only modify routes if SA has a valid address lease. On IKE SA rekey
sa_cp_addr and sa_cp_addr6 are moved to the new SA before the old
SA is deleted.
Fixes a bug where host routes were deleted on IKE SA rekey.
ok patrick@
nicm [Fri, 9 Apr 2021 07:02:00 +0000 (07:02 +0000)]
Change a type to fix a warning with some compilers.
claudio [Fri, 9 Apr 2021 06:52:50 +0000 (06:52 +0000)]
Tidy up the http state machine a bit. Make sure that http_nextstate() runs
until an error or an IO opperation is needed. In other words it should not
return 0. Because of this adjust the http_tls_connect() call a bit. Also
call http_connect() in http_redirect() instead of needing an extra step
in the state machine. Last but not least make sure that http_handle() does
only one IO operation and check for possible POLLHUP event.
OK tb@
otto [Fri, 9 Apr 2021 06:05:21 +0000 (06:05 +0000)]
An extra internal consistency check and a missing stats adjustment. ok tb@
otto [Fri, 9 Apr 2021 06:04:15 +0000 (06:04 +0000)]
Cache implementation has changed, we do not hold on to an exact number
of pages anymore, but also cache larger regions; ok tb@
tb [Fri, 9 Apr 2021 05:54:00 +0000 (05:54 +0000)]
Fix release time
ok deraadt
job [Thu, 8 Apr 2021 19:49:27 +0000 (19:49 +0000)]
Expose two extra metrics via JSON
This removes some of the needs of rpki-client affiniadios who
screen-scrape rpki-client's STDOUT.
OK deraadt@
deraadt [Thu, 8 Apr 2021 19:14:26 +0000 (19:14 +0000)]
sync
claudio [Thu, 8 Apr 2021 18:35:02 +0000 (18:35 +0000)]
Increase buffer size for http_info a bit. 64 chars is a bit short for
RRDP URLs.
claudio [Thu, 8 Apr 2021 18:32:55 +0000 (18:32 +0000)]
Refactor the regular and chunked data write so that one function can
handle both cases. Simplifies the code a fair bit.
OK tb@
kn [Thu, 8 Apr 2021 17:29:17 +0000 (17:29 +0000)]
Do not request unused "classless-static-routes" dhcp-options(5)
Doing so implies support for it, but dhcpleased(8) currently ingores it
entirely and does not configure any route from it.
As per RFC 3442 servers SHOULD NOT respond with a "routers" option when
"classless-static-routes" is set.
dhcpd(8)/dhcpd.conf(5) follows that, hence requesting but not using static
routes results in not installing any routes at all.
Stop signaling support for this option and only request "routers" such that
dhcpleased continues to install a default route and properly ignores the
unsupported option if used by the server.
Report from Uwe Werler <uwe @ werler dot is> about a default route not
being set when requesting the "classless-static-routes" dhcp-options(5)
from dhcpd(8), thanks!
OK florian
tb [Thu, 8 Apr 2021 17:11:43 +0000 (17:11 +0000)]
Enable test-cve-2016-6309.py
claudio [Thu, 8 Apr 2021 17:07:55 +0000 (17:07 +0000)]
Switch logic from != to ==. Makes the code easier to read.
claudio [Thu, 8 Apr 2021 16:56:34 +0000 (16:56 +0000)]
Change the order of the poll loop to first process active http connections
and then accept new ones. This way there is no risk of processing a new
connection before poll() was called.
OK tb@ as part of a larger diff
claudio [Thu, 8 Apr 2021 16:46:59 +0000 (16:46 +0000)]
Shuffle deck chairs so that the order is more logical (at least for me).
No functional change.
claudio [Thu, 8 Apr 2021 16:43:08 +0000 (16:43 +0000)]
Prevent a use-after-free access in case of a http redirect by also clearing
the conn->res pointer after calling freeaddrinfo().
OK tb@ (as part of a bigger diff)
claudio [Thu, 8 Apr 2021 16:32:42 +0000 (16:32 +0000)]
More cleanup of the main function. Use a loop to collect all childs with
waitpid() and print if they exited non-zero or by a signal. Also adjust
the poll hangup case to exit the poll loop instead of erroring out. This
way a crashed child should be reported before exit.
OK job@ tb@
claudio [Thu, 8 Apr 2021 15:31:14 +0000 (15:31 +0000)]
Missing setproctitle("rrdp") noticed by deraadt@
nicm [Thu, 8 Apr 2021 14:16:12 +0000 (14:16 +0000)]
Log the key written to the terminal as well as tmux's idea of what it
is.
job [Thu, 8 Apr 2021 14:03:32 +0000 (14:03 +0000)]
reword manpage on -n
OK claudio@
danj [Thu, 8 Apr 2021 11:56:30 +0000 (11:56 +0000)]
The path with the *highest* local weight is selected
ok kn
jmc [Thu, 8 Apr 2021 11:53:16 +0000 (11:53 +0000)]
fix SEE ALSO, and tidy up the text a little;
jmc [Thu, 8 Apr 2021 11:52:27 +0000 (11:52 +0000)]
tidy up AUTHORS with -nosplit;
tb [Wed, 7 Apr 2021 21:48:23 +0000 (21:48 +0000)]
Avoid clobbering the error code when sending an alert
In order to fail gracefully on encountering a self-signed cert, curl looks
at the top-most error on the stack and needs specific SSL_R_ error codes.
This mechanism was broken when the tls13_alert_sent_cb() was added after
people complained about unhelpful unknown errors. Fix this by only setting
the error code from a fatal alert if no error has been set previously.
Issue reported by Christopher Reid
ok jsing
tb [Wed, 7 Apr 2021 17:21:40 +0000 (17:21 +0000)]
Use ERR_print_error_fp() to avoid leaking a BIO in fatal()
kettenis [Wed, 7 Apr 2021 17:13:38 +0000 (17:13 +0000)]
graphaudio(4)
kettenis [Wed, 7 Apr 2021 17:12:22 +0000 (17:12 +0000)]
Add graphaudio(4), a driver to support linking together audio components
based on the audio graph description that uses ports and endpoints in
the device tree.
ok patrick@
claudio [Wed, 7 Apr 2021 16:40:38 +0000 (16:40 +0000)]
In some cases the http process terminates and Theo's and my theory is that
this is caused by a SIGPIPE. So add a handler that will abort the process
and dump core.
OK deraadt@
kettenis [Wed, 7 Apr 2021 16:35:02 +0000 (16:35 +0000)]
Add support for the fractional dividers for the i2s clocks.
Fixes audio on the pinebook pro.
ok kn@, patrick@
claudio [Wed, 7 Apr 2021 16:29:14 +0000 (16:29 +0000)]
Free the parser then close the file. Seems like the better order.
krw [Wed, 7 Apr 2021 16:09:40 +0000 (16:09 +0000)]
"oldlladddr" -> "oldlladdr" in fatal() verbiage.
deraadt [Wed, 7 Apr 2021 16:06:37 +0000 (16:06 +0000)]
minor KNF found while hunting for a bug
nicm [Wed, 7 Apr 2021 15:46:12 +0000 (15:46 +0000)]
Restore previous behaviour so that C-X remains the same as C-x. Instead,
translate incoming extended keys so that they are consistent.
claudio [Wed, 7 Apr 2021 14:26:21 +0000 (14:26 +0000)]
Handle bind() failure like connect() or socket() failure and try next
address if available. No other tools consider bind() errors as non-fatal
warnings so rpki-client should not behave different.
OK tb@
claudio [Wed, 7 Apr 2021 14:19:31 +0000 (14:19 +0000)]
When merging a repo even files to delete can be part of the temporary
work dir. So unlink can return an ENOENT error for the main repo. In
which case the temp dir should be tried.
Refactor this code a bit since there is no way rrdp_filename() should
fail in this part of the code.
OK tb@
nicm [Wed, 7 Apr 2021 12:50:12 +0000 (12:50 +0000)]
Add a current_file format for the config file being parsed. Originally
suggested by kn@, also GitHub issue 2638.
nicm [Wed, 7 Apr 2021 12:49:33 +0000 (12:49 +0000)]
When display-message used in config file, show the message after the
config file finishes. GitHub issue 2637.
inoguchi [Wed, 7 Apr 2021 10:44:03 +0000 (10:44 +0000)]
Check function return value in openssl(1) x509.c
input from bcook@, ok and comments from tb@
inoguchi [Wed, 7 Apr 2021 10:29:58 +0000 (10:29 +0000)]
Avoid leak in error path
ok and input from tb@
nicm [Wed, 7 Apr 2021 07:30:02 +0000 (07:30 +0000)]
Fixes for extended keys: 1) allow C-x and C-X to be bound separately
since some terminals report them differently 2) use the "backspace"
option to translate backspace 3) map ctrl which are have the ctrl
implied (such as C-x) properly when the terminal reports both the key
and the modifier.
Note that any key bindings for C-X where C-x is meant must now be
changed.
dlg [Wed, 7 Apr 2021 06:52:22 +0000 (06:52 +0000)]
back out r1.22, ie, don't blindly trim the FCS on rxed packets.
there's been multiple reports of severely reduced throughput using
ure(4) since 1.22 was committed, but all the gear we have to play
with is fine with it. i'm backing the diff out until we can get a
better handle on the problem
discussed with and ok kevlo@ jmatthew@
jsg [Wed, 7 Apr 2021 00:16:00 +0000 (00:16 +0000)]
disable POOL_DEBUG for release
ok deraadt@
dtucker [Tue, 6 Apr 2021 23:57:56 +0000 (23:57 +0000)]
Add TEST_SSH_ELAPSED_TIMES environment variable to print the elapsed
time in seconds of each test. This depends on "date +%s" which is not
specified by POSIX but is commonly implemented.
djm [Tue, 6 Apr 2021 23:24:30 +0000 (23:24 +0000)]
include "ssherr.h" not <ssherr.h>; from Balu Gajjala via bz#3292
jca [Tue, 6 Apr 2021 22:12:48 +0000 (22:12 +0000)]
handle_client() doesn't need to return a value
Its caller doesn't use the return value so zap it. Also zap tentative
error handling in the caller. ok kn@
jca [Tue, 6 Apr 2021 22:10:12 +0000 (22:10 +0000)]
Missing indentation, ok kn@
jca [Tue, 6 Apr 2021 22:09:56 +0000 (22:09 +0000)]
Bump APMD_VNO, for the size of struct apm_reply has changed
ok kn@
kn [Tue, 6 Apr 2021 20:30:32 +0000 (20:30 +0000)]
Make apm(8) report apmd(8) failure
apm(8) never got the result of the requested power action carried out by
apmd(8), so apm(4) errors got silently discarded; for example, zzz(8)
would merely print "Suspending system..." and exit zero on platforms
lacking suspend/resume support.
Enrich reply messages from apmd to apm with an error field containing the
failed ioctl(2)'s errno if need be.
Hoist apmd's power action dispatch into handle_client() so it can write the
error in the first place before replying.
OK dv
kn [Tue, 6 Apr 2021 19:59:32 +0000 (19:59 +0000)]
Shared semaphores are not supported
Shared semaphores were reverted with lib/librthread/rthread_sem.c r1.18
in 2013 but corresponding manual bits were not; revert sem_init.3 r1.6
(modulo the unrelated "named semaphores" hunk).
Reported by Rubén Llorente, thanks.
Prodding OK jmc
sthen [Tue, 6 Apr 2021 19:10:42 +0000 (19:10 +0000)]
convert UTF-8 to plain ascii, spotted by florian
sthen [Tue, 6 Apr 2021 18:57:55 +0000 (18:57 +0000)]
merge NSD 4.3.6
sthen [Tue, 6 Apr 2021 18:51:46 +0000 (18:51 +0000)]
merge NSD 4.3.6
claudio [Tue, 6 Apr 2021 18:35:46 +0000 (18:35 +0000)]
Do not return when a hash check failed in rrdp_data_handler() instead
let the code progress to set the state to RRDP_STATE_PARSE_DONE and
call rrdp_finished() since this transfer is over.
Should fix a hang seen by deraadt@
OK tb@
jmc [Tue, 6 Apr 2021 18:29:43 +0000 (18:29 +0000)]
uppercase "HTTP";
tb [Tue, 6 Apr 2021 16:40:34 +0000 (16:40 +0000)]
use errx() instead of err()
tb [Tue, 6 Apr 2021 16:30:27 +0000 (16:30 +0000)]
spaces -> tabs
tb [Tue, 6 Apr 2021 15:22:30 +0000 (15:22 +0000)]
Mention the http client in two places.
ok claudio
tb [Tue, 6 Apr 2021 15:00:19 +0000 (15:00 +0000)]
minor style tweaks
kn [Tue, 6 Apr 2021 14:17:35 +0000 (14:17 +0000)]
Print all mount(2) flags in ddb's "show all mounts"
Quite a few flags were never accounted for in MNT_BITS, resulting in bogus
debug output such as "flags
4205800<WXALLOWED,LOCAL,ROOTFS>" (integer value
does not match string interpretation, i.e. "SOFTDEP,SWAPPABLE" is missing).
Spotted while instrumenting "show all mounts" to report a softdep panic.
Feedback OK visa
claudio [Tue, 6 Apr 2021 12:35:24 +0000 (12:35 +0000)]
Cleanup http_connect() and make it look more like the example in
getaddrinfo(3). Most notable change is the error reporting.
Do not warn if cause is not set. In this case the last connect attempt
failed but there is no alternate address to use. Since that error was
already logged there is no need for an extra warning here.
OK job@
claudio [Tue, 6 Apr 2021 12:30:43 +0000 (12:30 +0000)]
Move the http_fail() call out of http_free(). Doing the error reporting
there is not quite right.
OK job@
claudio [Tue, 6 Apr 2021 12:28:56 +0000 (12:28 +0000)]
Kill unused globals and swap the POLLIN and POLLOUT handler for the
pipe to the main process.
OK job@
dtucker [Tue, 6 Apr 2021 09:07:33 +0000 (09:07 +0000)]
Don't check return value of unsetenv(). It's part of the environment
setup and not part of the actual test, and some platforms -portable runs
on declare it as returning void, which prevents the test from compiling.
jmc [Tue, 6 Apr 2021 06:28:38 +0000 (06:28 +0000)]
use "braces" consistenly; fastcgi can take multiple options;
original issue and text from laurence tratt, with updates from raf czlonka
dv [Tue, 6 Apr 2021 00:19:58 +0000 (00:19 +0000)]
Restore EPT protection checks on VMX when using VMM_IOC_MPROTECT_EPT
A prior fix related to lack of TLB flushing accidentally removed the
fault type checks related to the access protection features available
via the VMM_IOC_MPROTECT_EPT ioctl. This restores the same logic for
checking the fault type and the exit to userland if the fault is due
to EPT access protections.
While here, update the comment for vmx_fault_page to accurately
reflect the various potential return values.
Reported by Adam Steen.
OK mlarkin@
mglocker [Mon, 5 Apr 2021 20:46:06 +0000 (20:46 +0000)]
regen
mglocker [Mon, 5 Apr 2021 20:45:49 +0000 (20:45 +0000)]
Add a new quirk flag to not attach video devices which aren't supported by
uvideo(4) currently, like the Chicony Integrated IR Camera. This is
especially helpful when you have two video devices of which the unsupported
one is attached first as reported by martijn@.
OK gnezdo@
dv [Mon, 5 Apr 2021 18:26:45 +0000 (18:26 +0000)]
Improve rdmsr/wrmsr exit handling for both AMD SVM and Intel VMX.
At some point, the logic for handling vmexits related to msr access
changed and the handling for SVM diverged from VMX. While booting the
newest 9front release, abieber@ noticed boot loops on an AMD host.
This commit changes the behavior to be the same between SVM and VMX hosts,
with the exception of a single MSR, and enforces that any rdmsr
instruction must be explicitly handled otherwise a #GP is injected into
the guest. Any wrmsr instructions that are not explicitly handled are
ignored (%rax, %rdx set to 0).
The PAT msr is now shadowed, allowing guests to read a copy of the host
PAT. Their writes are stored in guest vcpu state and not passed through to
the host cpu. (PAT writes are validated, however, and invalid values
inject #GP.)
tested by brynet@, abieber@
ok brynet@, mlarkin@
deraadt [Mon, 5 Apr 2021 18:17:37 +0000 (18:17 +0000)]
minor KNF
dv [Mon, 5 Apr 2021 18:09:48 +0000 (18:09 +0000)]
Support booting from compressed kernel images.
The bsd.rd ramdisk now ships gzip'd on amd64. Use libz in base to
transparently handle decompression of any compressed kernel images.
Patch from Josh Rickmar.
ok kn@