From: miod <miod@openbsd.org>
Date: Sun, 13 Jul 2014 15:41:33 +0000 (+0000)
Subject: Warn about the use of BUF_strdup.
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=ff50e14776abaed3227d8462cae113462e2e50be;p=openbsd

Warn about the use of BUF_strdup.
---

diff --git a/lib/libssl/src/doc/crypto/BUF_MEM_new.pod b/lib/libssl/src/doc/crypto/BUF_MEM_new.pod
index a83f46f8968..28057558692 100644
--- a/lib/libssl/src/doc/crypto/BUF_MEM_new.pod
+++ b/lib/libssl/src/doc/crypto/BUF_MEM_new.pod
@@ -45,10 +45,12 @@ B<len>. Any data already in the buffer is preserved if it increases in
 size.
 
 BUF_strdup() copies a null terminated string into a block of allocated memory
-and returns a pointer to the allocated block.
+and returns a pointer to the allocated block. Unlike the system strdup()
+function, BUF_strdup() will accept a NULL argument and will return NULL in
+that case. Its use in new programes is discouraged.
 
 The memory allocated from BUF_strdup() should be freed up using the
-OPENSSL_free() function.
+free() function.
 
 =head1 RETURN VALUES