From: stsp <stsp@openbsd.org>
Date: Thu, 7 Jul 2022 07:48:45 +0000 (+0000)
Subject: remove a DPRINTF() from iwm(4) which no longer makes any sense
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=f5dc705adc986a663e1e0a5db3458de48ed583d2;p=openbsd

remove a DPRINTF() from iwm(4) which no longer makes any sense

The conditions under which this debug message should trigger were
changed in r1.330 (cvs commit RcatFKLXoHUopLvW), which removed a
txd_done() call located before txq_advance(). The mbuf for the
most recently completed frame will no longer be NULL on entry.

Prompted by a question from waddlesplash at haiku-os.
---

diff --git a/sys/dev/pci/if_iwm.c b/sys/dev/pci/if_iwm.c
index b23951e5c69..b85d626482e 100644
--- a/sys/dev/pci/if_iwm.c
+++ b/sys/dev/pci/if_iwm.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: if_iwm.c,v 1.401 2022/06/04 11:32:11 stsp Exp $	*/
+/*	$OpenBSD: if_iwm.c,v 1.402 2022/07/07 07:48:45 stsp Exp $	*/
 
 /*
  * Copyright (c) 2014, 2016 genua gmbh <info@genua.de>
@@ -5698,9 +5698,6 @@ iwm_txq_advance(struct iwm_softc *sc, struct iwm_tx_ring *ring, int idx)
 	while (ring->tail != idx) {
 		txd = &ring->data[ring->tail];
 		if (txd->m != NULL) {
-			if (ring->qid < IWM_FIRST_AGG_TX_QUEUE)
-				DPRINTF(("%s: missed Tx completion: tail=%d "
-				    "idx=%d\n", __func__, ring->tail, idx));
 			iwm_reset_sched(sc, ring->qid, ring->tail, IWM_STATION_ID);
 			iwm_txd_done(sc, txd);
 			ring->queued--;