From: deraadt <deraadt@openbsd.org>
Date: Thu, 23 Apr 2015 06:11:19 +0000 (+0000)
Subject: Do not need to buf[0] = 0 before strlcpy(buf, ...
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=f317e6d04ef72dca2b25363afb2c6e1c3b5ff3f4;p=openbsd

Do not need to buf[0] = 0 before strlcpy(buf, ...
---

diff --git a/lib/libcrypto/bio/b_dump.c b/lib/libcrypto/bio/b_dump.c
index 0943e9006df..0214addc8be 100644
--- a/lib/libcrypto/bio/b_dump.c
+++ b/lib/libcrypto/bio/b_dump.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: b_dump.c,v 1.20 2014/11/11 19:26:12 miod Exp $ */
+/* $OpenBSD: b_dump.c,v 1.21 2015/04/23 06:11:19 deraadt Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -107,7 +107,6 @@ BIO_dump_indent_cb(int (*cb)(const void *data, size_t len, void *u),
 	if ((rows * dump_width) < len)
 		rows++;
 	for (i = 0; i < rows; i++) {
-		buf[0] = '\0';	/* start with empty string */
 		strlcpy(buf, str, sizeof buf);
 		snprintf(tmp, sizeof tmp, "%04x - ", i*dump_width);
 		strlcat(buf, tmp, sizeof buf);
diff --git a/lib/libssl/src/crypto/bio/b_dump.c b/lib/libssl/src/crypto/bio/b_dump.c
index 0943e9006df..0214addc8be 100644
--- a/lib/libssl/src/crypto/bio/b_dump.c
+++ b/lib/libssl/src/crypto/bio/b_dump.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: b_dump.c,v 1.20 2014/11/11 19:26:12 miod Exp $ */
+/* $OpenBSD: b_dump.c,v 1.21 2015/04/23 06:11:19 deraadt Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -107,7 +107,6 @@ BIO_dump_indent_cb(int (*cb)(const void *data, size_t len, void *u),
 	if ((rows * dump_width) < len)
 		rows++;
 	for (i = 0; i < rows; i++) {
-		buf[0] = '\0';	/* start with empty string */
 		strlcpy(buf, str, sizeof buf);
 		snprintf(tmp, sizeof tmp, "%04x - ", i*dump_width);
 		strlcat(buf, tmp, sizeof buf);