From: jsg <jsg@openbsd.org>
Date: Tue, 27 Jun 2017 12:04:26 +0000 (+0000)
Subject: Avoid testing an uninitialised variable in the SCSI_BUSY/SCSI_QUEUE_FULL
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=f2643dce67392003f9c3da4d04d35b2954ecb0b6;p=openbsd

Avoid testing an uninitialised variable in the SCSI_BUSY/SCSI_QUEUE_FULL
paths of hvs_scsi_cmd_done().

ok mikeb@
---

diff --git a/sys/dev/pv/hvs.c b/sys/dev/pv/hvs.c
index ca5ff1abf07..48b7a59a574 100644
--- a/sys/dev/pv/hvs.c
+++ b/sys/dev/pv/hvs.c
@@ -639,7 +639,7 @@ hvs_scsi_cmd_done(struct hvs_ccb *ccb)
 		printf("%s: status %#x iostatus %#x (busy)\n",
 		    sc->sc_dev.dv_xname, srb->srb_scsistatus,
 		    srb->srb_iostatus);
-		xs->error = XS_BUSY;
+		error = XS_BUSY;
 		break;
 	case SCSI_CHECK:
 		if (srb->srb_iostatus & SRB_STATUS_AUTOSENSE_VALID) {