From: deraadt <deraadt@openbsd.org>
Date: Fri, 2 Apr 2021 16:41:36 +0000 (+0000)
Subject: info gotten via getnameinfo in http_connect() is not used anymore, it is
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=e41cf75db8b1e9033f14dd2ee040e24021c82ecd;p=openbsd

info gotten via getnameinfo in http_connect() is not used anymore, it is
old debugging gunk
ok claudio
---

diff --git a/usr.sbin/rpki-client/http.c b/usr.sbin/rpki-client/http.c
index 0aad880b52b..5ac8d61351a 100644
--- a/usr.sbin/rpki-client/http.c
+++ b/usr.sbin/rpki-client/http.c
@@ -1,4 +1,4 @@
-/*      $OpenBSD: http.c,v 1.13 2021/04/02 11:35:05 claudio Exp $  */
+/*      $OpenBSD: http.c,v 1.14 2021/04/02 16:41:36 deraadt Exp $  */
 /*
  * Copyright (c) 2020 Nils Fisher <nils_fisher@hotmail.com>
  * Copyright (c) 2020 Claudio Jeker <claudio@openbsd.org>
@@ -473,7 +473,6 @@ http_redirect(struct http_connection *conn, char *uri)
 static int
 http_connect(struct http_connection *conn)
 {
-	char pbuf[NI_MAXSERV], hbuf[NI_MAXHOST];
 	char *cause = "unknown";
 
 	if (conn->fd != -1) {
@@ -490,11 +489,6 @@ http_connect(struct http_connection *conn)
 		struct addrinfo *res = conn->res;
 		int fd, error, save_errno;
 
-		if (getnameinfo(res->ai_addr, res->ai_addrlen, hbuf,
-		    sizeof(hbuf), pbuf, sizeof(pbuf),
-		    NI_NUMERICHOST | NI_NUMERICSERV) != 0)
-			strlcpy(hbuf, "(unknown)", sizeof(hbuf));
-
 		fd = socket(res->ai_family,
 		    res->ai_socktype | SOCK_NONBLOCK, res->ai_protocol);
 		if (fd == -1) {