From: jsing <jsing@openbsd.org>
Date: Sun, 24 Aug 2014 14:55:23 +0000 (+0000)
Subject: Let SSL_CIPHER_description() allocate the buffer for the description,
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=db52929fe5c309c2b114763509171f6a1b956079;p=openbsd

Let SSL_CIPHER_description() allocate the buffer for the description,
rather than passing in a fixed size buffer.

This is yet another example of a horribly designed API - if the given
buffer is NULL then SSL_CIPHER_description() allocates one for us (great!),
which we then need to free (no problem). However, if this allocation fails
it returns a pointer to a static string "OPENSSL_malloc Error" - obviously
bad things happen if we call free() with this pointer.

Unfortunately, there is no way of knowing that the function failed, other
than comparing the returned string against the string literal - so do that
before calling free()...

Joint work with beck@ during g2k14.
---

diff --git a/lib/libssl/src/apps/ciphers.c b/lib/libssl/src/apps/ciphers.c
index 4d594fbaf4d..7eddf2faba5 100644
--- a/lib/libssl/src/apps/ciphers.c
+++ b/lib/libssl/src/apps/ciphers.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ciphers.c,v 1.26 2014/07/14 00:35:10 deraadt Exp $ */
+/* $OpenBSD: ciphers.c,v 1.27 2014/08/24 14:55:23 jsing Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -89,8 +89,8 @@ ciphers_main(int argc, char **argv)
 	char *ciphers = NULL;
 	const SSL_METHOD *meth = NULL;
 	STACK_OF(SSL_CIPHER) * sk;
-	char buf[512];
 	BIO *STDout = NULL;
+	char *desc;
 
 	meth = SSLv3_server_method();
 
@@ -169,8 +169,10 @@ ciphers_main(int argc, char **argv)
 				else
 					BIO_printf(STDout, "0x%02X,0x%02X,0x%02X,0x%02X - ", id0, id1, id2, id3);	/* whatever */
 			}
-			BIO_puts(STDout,
-			    SSL_CIPHER_description(c, buf, sizeof buf));
+			desc = SSL_CIPHER_description(c, NULL, 0);
+			BIO_puts(STDout, desc);
+			if (strcmp(desc, "OPENSSL_malloc Error") != 0)
+				free(desc);
 		}
 	}