From: mlarkin <mlarkin@openbsd.org>
Date: Sun, 18 May 2014 20:16:29 +0000 (+0000)
Subject: _PIC is an optional method, so we shouldn't be aborting the rest of the
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=d75e4e4052211c4a255b97968e2fc322767194d1;p=openbsd

_PIC is an optional method, so we shouldn't be aborting the rest of the
MADT processing if it is missing. This, combined with an earlier diff
from kettenis@ to fix MADT interrupt polarity processing, should resolve
the issues reported with QEMU/KVM ACPI power button presses when using
OpenBSD guests.

ok kettenis@, pirofti@
tested by myself and kettenis for the past few weeks
---

diff --git a/sys/dev/acpi/acpimadt.c b/sys/dev/acpi/acpimadt.c
index f012cf37365..1fc2e64aebf 100644
--- a/sys/dev/acpi/acpimadt.c
+++ b/sys/dev/acpi/acpimadt.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: acpimadt.c,v 1.26 2012/01/07 20:13:16 kettenis Exp $ */
+/* $OpenBSD: acpimadt.c,v 1.27 2014/05/18 20:16:29 mlarkin Exp $ */
 /*
  * Copyright (c) 2006 Mark Kettenis <kettenis@openbsd.org>
  *
@@ -216,8 +216,7 @@ acpimadt_attach(struct device *parent, struct device *self, void *aux)
 	arg.type = AML_OBJTYPE_INTEGER;
 	arg.v_integer = 1;
 
-	if (aml_evalname(acpi_sc, NULL, "\\_PIC", 1, &arg, NULL) != 0)
-		return;
+	aml_evalname(acpi_sc, NULL, "\\_PIC", 1, &arg, NULL);
 
 	mp_busses = acpimadt_busses;
 	mp_nbusses = nitems(acpimadt_busses);