From: tb <tb@openbsd.org>
Date: Tue, 26 Mar 2024 23:45:05 +0000 (+0000)
Subject: Remove superfluous parentheses in X509_REQ setters
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=cfbd033be1f3f11ae784cef0fd2a8a65e546fd44;p=openbsd

Remove superfluous parentheses in X509_REQ setters

No change in generated assembly
---

diff --git a/lib/libcrypto/x509/x509rset.c b/lib/libcrypto/x509/x509rset.c
index 6ac64f199dc..2e2d4abd08d 100644
--- a/lib/libcrypto/x509/x509rset.c
+++ b/lib/libcrypto/x509/x509rset.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: x509rset.c,v 1.15 2024/03/26 11:09:37 tb Exp $ */
+/* $OpenBSD: x509rset.c,v 1.16 2024/03/26 23:45:05 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -69,12 +69,12 @@ int
 X509_REQ_set_version(X509_REQ *x, long version)
 {
 	if (x == NULL)
-		return (0);
+		return 0;
 	/* RFC 2986 section 4.1 only specifies version 1, encoded as a 0. */
 	if (version != 0)
-		return (0);
+		return 0;
 	x->req_info->enc.modified = 1;
-	return (ASN1_INTEGER_set(x->req_info->version, version));
+	return ASN1_INTEGER_set(x->req_info->version, version);
 }
 LCRYPTO_ALIAS(X509_REQ_set_version);
 
@@ -88,10 +88,10 @@ LCRYPTO_ALIAS(X509_REQ_get_version);
 int
 X509_REQ_set_subject_name(X509_REQ *x, X509_NAME *name)
 {
-	if ((x == NULL) || (x->req_info == NULL))
-		return (0);
+	if (x == NULL || x->req_info == NULL)
+		return 0;
 	x->req_info->enc.modified = 1;
-	return (X509_NAME_set(&x->req_info->subject, name));
+	return X509_NAME_set(&x->req_info->subject, name);
 }
 LCRYPTO_ALIAS(X509_REQ_set_subject_name);
 
@@ -105,9 +105,9 @@ LCRYPTO_ALIAS(X509_REQ_get_subject_name);
 int
 X509_REQ_set_pubkey(X509_REQ *x, EVP_PKEY *pkey)
 {
-	if ((x == NULL) || (x->req_info == NULL))
-		return (0);
+	if (x == NULL || x->req_info == NULL)
+		return 0;
 	x->req_info->enc.modified = 1;
-	return (X509_PUBKEY_set(&x->req_info->pubkey, pkey));
+	return X509_PUBKEY_set(&x->req_info->pubkey, pkey);
 }
 LCRYPTO_ALIAS(X509_REQ_set_pubkey);