From: tb <tb@openbsd.org>
Date: Wed, 16 Oct 2024 23:58:25 +0000 (+0000)
Subject: EC ASN.1: add reminder that the simple method might also want testing
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=c33e213a4bc3b87528aa27963799585396728b3f;p=openbsd

EC ASN.1: add reminder that the simple method might also want testing
---

diff --git a/regress/lib/libcrypto/ec/ec_asn1_test.c b/regress/lib/libcrypto/ec/ec_asn1_test.c
index cc0f0f46f4e..171014bda7e 100644
--- a/regress/lib/libcrypto/ec/ec_asn1_test.c
+++ b/regress/lib/libcrypto/ec/ec_asn1_test.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ec_asn1_test.c,v 1.5 2024/10/16 23:49:49 tb Exp $ */
+/* $OpenBSD: ec_asn1_test.c,v 1.6 2024/10/16 23:58:25 tb Exp $ */
 /*
  * Copyright (c) 2017, 2021 Joel Sing <jsing@openbsd.org>
  * Copyright (c) 2024 Theo Buehler <tb@openbsd.org>
@@ -458,6 +458,10 @@ ec_weierstrass25519(void)
 	if (BN_hex2bn(&b, wei25519.b) == 0)
 		errx(1, "BN_hex2bn(b)");
 
+	/*
+	 * XXX - this uses the Montgomery method. Consider exercising the
+	 * simple method as well.
+	 */
 	if ((group = EC_GROUP_new_curve_GFp(p, a, b, ctx)) == NULL) {
 		fprintf(stderr, "FAIL: %s EC_GROUP_new_curve_GFp", __func__);
 		goto err;