From: djm <djm@openbsd.org>
Date: Tue, 11 Jun 2024 01:21:41 +0000 (+0000)
Subject: move tree init before possible early return
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=c01d1bf6ffd8949afee28a4e15a14c7a201821e7;p=openbsd

move tree init before possible early return
---

diff --git a/usr.bin/ssh/srclimit.c b/usr.bin/ssh/srclimit.c
index ffea6a3973e..011b83a4d3a 100644
--- a/usr.bin/ssh/srclimit.c
+++ b/usr.bin/ssh/srclimit.c
@@ -106,6 +106,8 @@ srclimit_init(int max, int persource, int ipv4len, int ipv6len,
 	penalty_cfg = *penalty_conf;
 	penalty_exempt = penalty_exempt_conf == NULL ?
 	    NULL : xstrdup(penalty_exempt_conf);
+	RB_INIT(&penalties_by_addr);
+	RB_INIT(&penalties_by_expiry);
 	if (max_persource == INT_MAX)	/* no limit */
 		return;
 	debug("%s: max connections %d, per source %d, masks %d,%d", __func__,
@@ -115,8 +117,6 @@ srclimit_init(int max, int persource, int ipv4len, int ipv6len,
 	children = xcalloc(max_children, sizeof(*children));
 	for (i = 0; i < max_children; i++)
 		children[i].id = -1;
-	RB_INIT(&penalties_by_addr);
-	RB_INIT(&penalties_by_expiry);
 }
 
 /* returns 1 if connection allowed, 0 if not allowed. */