From: ratchov <ratchov@openbsd.org>
Date: Sat, 25 Dec 2021 16:25:07 +0000 (+0000)
Subject: Don't accept an empty string as selector value
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=bd9152030089a1b7b17a69381832f5aefbf11fa7;p=openbsd

Don't accept an empty string as selector value

"looks good" edd@
---

diff --git a/usr.bin/sndioctl/sndioctl.c b/usr.bin/sndioctl/sndioctl.c
index aa174e77249..ffe0654fa94 100644
--- a/usr.bin/sndioctl/sndioctl.c
+++ b/usr.bin/sndioctl/sndioctl.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: sndioctl.c,v 1.16 2021/03/03 09:40:43 ratchov Exp $	*/
+/*	$OpenBSD: sndioctl.c,v 1.17 2021/12/25 16:25:07 ratchov Exp $	*/
 /*
  * Copyright (c) 2014-2020 Alexandre Ratchov <alex@caoua.org>
  *
@@ -706,6 +706,11 @@ cmd(char *line)
 		}
 		break;
 	case SIOCTL_SEL:
+		if (*pos == '\0') {
+			fprintf(stderr, "%s.%s: expects value\n", astr, func);
+			exit(1);
+		}
+		/* FALLTROUGH */
 	case SIOCTL_VEC:
 	case SIOCTL_LIST:
 		for (i = g; i != NULL; i = nextpar(i)) {