From: djm <djm@openbsd.org>
Date: Tue, 7 Mar 2023 05:37:26 +0000 (+0000)
Subject: fix memory leak in process_read() path; Spotted by James Robinson
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=b4b98f925a4530f30641b108e6c353fa6577c674;p=openbsd

fix memory leak in process_read() path; Spotted by James Robinson
in GHPR363; ok markus@
---

diff --git a/usr.bin/ssh/sftp-server.c b/usr.bin/ssh/sftp-server.c
index be2c3e7a0d3..ce966bcb980 100644
--- a/usr.bin/ssh/sftp-server.c
+++ b/usr.bin/ssh/sftp-server.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp-server.c,v 1.145 2022/11/09 09:04:12 dtucker Exp $ */
+/* $OpenBSD: sftp-server.c,v 1.146 2023/03/07 05:37:26 djm Exp $ */
 /*
  * Copyright (c) 2000-2004 Markus Friedl.  All rights reserved.
  *
@@ -809,7 +809,7 @@ process_read(u_int32_t id)
 	}
 	if (len > buflen) {
 		debug3_f("allocate %zu => %u", buflen, len);
-		if ((buf = realloc(NULL, len)) == NULL)
+		if ((buf = realloc(buf, len)) == NULL)
 			fatal_f("realloc failed");
 		buflen = len;
 	}