From: benno <benno@openbsd.org>
Date: Sat, 10 Feb 2018 04:23:48 +0000 (+0000)
Subject: claudio noted that this is an else case because we have either a
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=b02ef208184faef662e31c318c3dfdbf8792557d;p=openbsd

claudio noted that this is an else case because we have either a
prefix or a prefix-set.
---

diff --git a/usr.sbin/bgpd/rde_filter.c b/usr.sbin/bgpd/rde_filter.c
index 7b1a52e5022..a963162b093 100644
--- a/usr.sbin/bgpd/rde_filter.c
+++ b/usr.sbin/bgpd/rde_filter.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: rde_filter.c,v 1.85 2018/02/10 01:24:28 benno Exp $ */
+/*	$OpenBSD: rde_filter.c,v 1.86 2018/02/10 04:23:48 benno Exp $ */
 
 /*
  * Copyright (c) 2004 Claudio Jeker <claudio@openbsd.org>
@@ -490,10 +490,7 @@ rde_filter_match(struct filter_rule *f, struct rde_aspath *asp,
 			}
 		}
 		return (0);
-	}
-
-	/* XXX must be last because we unconditionally return here */
-	if (f->match.prefix.addr.aid != 0)
+	} else if (f->match.prefix.addr.aid != 0)
 		return (rde_test_prefix(&f->match.prefix, prefix, plen));
 
 	/* matched somewhen or is anymatch rule  */