From: job <job@openbsd.org>
Date: Thu, 2 Sep 2021 15:59:05 +0000 (+0000)
Subject: OPENSSL_assert() is not appropriate in this context
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=afcad173709c36882e35cfa96050312e2530d43b;p=openbsd

OPENSSL_assert() is not appropriate in this context

Feedback from tb@

OK tb@
---

diff --git a/lib/libcrypto/x509/x509_asid.c b/lib/libcrypto/x509/x509_asid.c
index 56283cbe2b2..bcb6e4ea1d5 100644
--- a/lib/libcrypto/x509/x509_asid.c
+++ b/lib/libcrypto/x509/x509_asid.c
@@ -218,11 +218,12 @@ static int ASIdOrRange_cmp(const ASIdOrRange *const *a_,
 {
     const ASIdOrRange *a = *a_, *b = *b_;
 
-    OPENSSL_assert((a->type == ASIdOrRange_id && a->u.id != NULL) ||
+    /* XXX: these asserts need to be replaced */
+    assert((a->type == ASIdOrRange_id && a->u.id != NULL) ||
            (a->type == ASIdOrRange_range && a->u.range != NULL &&
             a->u.range->min != NULL && a->u.range->max != NULL));
 
-    OPENSSL_assert((b->type == ASIdOrRange_id && b->u.id != NULL) ||
+    assert((b->type == ASIdOrRange_id && b->u.id != NULL) ||
            (b->type == ASIdOrRange_range && b->u.range != NULL &&
             b->u.range->min != NULL && b->u.range->max != NULL));