From: tb <tb@openbsd.org>
Date: Sun, 26 Dec 2021 15:23:37 +0000 (+0000)
Subject: Plug memleak
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=a52e2aabf0e7bd93ddc688cd8ead80b9d382293d;p=openbsd

Plug memleak

CID 345119
---

diff --git a/usr.bin/openssl/cms.c b/usr.bin/openssl/cms.c
index cad85567302..db485cd2901 100644
--- a/usr.bin/openssl/cms.c
+++ b/usr.bin/openssl/cms.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: cms.c,v 1.17 2020/01/04 14:17:55 inoguchi Exp $ */
+/* $OpenBSD: cms.c,v 1.18 2021/12/26 15:23:37 tb Exp $ */
 /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
  * project.
  */
@@ -444,8 +444,10 @@ cms_main(int argc, char **argv)
 				if ((nparam = malloc(sizeof(struct cms_key_param))) == NULL)
 					goto end;
 				nparam->idx = keyidx;
-				if ((nparam->param = sk_OPENSSL_STRING_new_null()) == NULL)
+				if ((nparam->param = sk_OPENSSL_STRING_new_null()) == NULL) {
+					free(nparam);
 					goto end;
+				}
 				nparam->next = NULL;
 				if (key_first == NULL)
 					key_first = nparam;