From: deraadt <deraadt@openbsd.org>
Date: Fri, 17 Feb 2023 18:08:32 +0000 (+0000)
Subject: Validate execve() libc stub location if kernel knows it. (due to ld.so
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=a2c764f6fb7a2a06df769555b041baf5e612c4de;p=openbsd

Validate execve() libc stub location if kernel knows it. (due to ld.so
telling the kernel with pinsyscall(2)
---

diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c
index 4c30e5a45b9..01f92235e3b 100644
--- a/sys/kern/kern_exec.c
+++ b/sys/kern/kern_exec.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: kern_exec.c,v 1.244 2023/02/10 14:34:17 visa Exp $	*/
+/*	$OpenBSD: kern_exec.c,v 1.245 2023/02/17 18:08:32 deraadt Exp $	*/
 /*	$NetBSD: kern_exec.c,v 1.75 1996/02/09 18:59:28 christos Exp $	*/
 
 /*-
@@ -37,6 +37,7 @@
 #include <sys/systm.h>
 #include <sys/filedesc.h>
 #include <sys/proc.h>
+#include <sys/user.h>
 #include <sys/mount.h>
 #include <sys/malloc.h>
 #include <sys/pool.h>
@@ -267,11 +268,20 @@ sys_execve(struct proc *p, void *v, register_t *retval)
 #ifdef MACHINE_STACK_GROWS_UP
 	size_t slen;
 #endif
+	vaddr_t pc = PROC_PC(p);
 	char *stack;
 	struct ps_strings arginfo;
-	struct vmspace *vm;
+	struct vmspace *vm = p->p_vmspace;
 	struct vnode *otvp;
 
+	if (vm->vm_execve &&
+	    (pc >= vm->vm_execve_end || pc < vm->vm_execve)) {
+		printf("%s(%d): execve %lx outside %lx-%lx\n", pr->ps_comm,
+		    pr->ps_pid, pc, vm->vm_execve, vm->vm_execve_end);
+		sigabort(p);
+		return (0);
+	}
+
 	/* get other threads to stop */
 	if ((error = single_thread_set(p, SINGLE_UNWIND, 1)))
 		return (error);