From: dtucker Date: Tue, 14 Mar 2023 07:26:25 +0000 (+0000) Subject: Check pointer for NULL before attempting to deref. None of the existing X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=9e5b4079882f48fabe3ef8956aad2d39301f87ae;p=openbsd Check pointer for NULL before attempting to deref. None of the existing callers seem to do that, but it's worth checking. From Coverity CID 291834, ok djm@ --- diff --git a/usr.bin/ssh/authfile.c b/usr.bin/ssh/authfile.c index 418e405bfc5..eb0bdeda2a0 100644 --- a/usr.bin/ssh/authfile.c +++ b/usr.bin/ssh/authfile.c @@ -1,4 +1,4 @@ -/* $OpenBSD: authfile.c,v 1.143 2022/06/21 14:52:13 tobhe Exp $ */ +/* $OpenBSD: authfile.c,v 1.144 2023/03/14 07:26:25 dtucker Exp $ */ /* * Copyright (c) 2000, 2013 Markus Friedl. All rights reserved. * @@ -206,6 +206,8 @@ sshkey_try_load_public(struct sshkey **kp, const char *filename, int r; struct sshkey *k = NULL; + if (kp == NULL) + return SSH_ERR_INVALID_ARGUMENT; *kp = NULL; if (commentp != NULL) *commentp = NULL;