From: bluhm <bluhm@openbsd.org>
Date: Sun, 19 Dec 2021 23:30:08 +0000 (+0000)
Subject: There are occasions where the walker function in tdb_walk() might
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=9cb0c5826f3cb096fd9cf9db5270d23c4940a11c;p=openbsd

There are occasions where the walker function in tdb_walk() might
sleep.  So holding the tdb_sadb_mtx() when calling walker() is not
allowed.  Move the TDB from the TDB-Hash to a temporary list that
is protected by netlock.  Then unlock tdb_sadb_mtx and traverse the
list to call the walker.
OK mvs@
---

diff --git a/sys/net/pfkeyv2.c b/sys/net/pfkeyv2.c
index 289243bfdf3..b848dab990a 100644
--- a/sys/net/pfkeyv2.c
+++ b/sys/net/pfkeyv2.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: pfkeyv2.c,v 1.228 2021/12/14 17:50:37 bluhm Exp $ */
+/* $OpenBSD: pfkeyv2.c,v 1.229 2021/12/19 23:30:08 bluhm Exp $ */
 
 /*
  *	@(#)COPYRIGHT	1.1 (NRL) 17 January 1995
@@ -1045,7 +1045,7 @@ pfkeyv2_sa_flush(struct tdb *tdb, void *satype_vp, int last)
 {
 	if (!(*((u_int8_t *) satype_vp)) ||
 	    tdb->tdb_satype == *((u_int8_t *) satype_vp))
-		tdb_delete_locked(tdb);
+		tdb_delete(tdb);
 	return (0);
 }
 
diff --git a/sys/netinet/ip_ipsp.c b/sys/netinet/ip_ipsp.c
index f13566b2d87..f7b4a9c5742 100644
--- a/sys/netinet/ip_ipsp.c
+++ b/sys/netinet/ip_ipsp.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: ip_ipsp.c,v 1.265 2021/12/14 17:50:37 bluhm Exp $	*/
+/*	$OpenBSD: ip_ipsp.c,v 1.266 2021/12/19 23:30:08 bluhm Exp $	*/
 /*
  * The authors of this code are John Ioannidis (ji@tla.org),
  * Angelos D. Keromytis (kermit@csd.uch.gr),
@@ -90,7 +90,6 @@ void		tdb_firstuse(void *);
 void		tdb_soft_timeout(void *);
 void		tdb_soft_firstuse(void *);
 int		tdb_hash(u_int32_t, union sockaddr_union *, u_int8_t);
-void		tdb_dodelete(struct tdb *, int locked);
 
 int ipsec_in_use = 0;
 u_int64_t ipsec_last_added = 0;
@@ -627,30 +626,36 @@ tdb_printit(void *addr, int full, int (*pr)(const char *, ...))
 int
 tdb_walk(u_int rdomain, int (*walker)(struct tdb *, void *, int), void *arg)
 {
-	int i, rval = 0;
-	struct tdb *tdbp, *next;
+	SIMPLEQ_HEAD(, tdb) tdblist;
+	struct tdb *tdbp;
+	int i, rval;
 
 	/*
-	 * The walker may aquire the kernel lock.  Grab it here to keep
-	 * the lock order.
+	 * The walker may sleep.  So we cannot hold the tdb_sadb_mtx while
+	 * traversing the tdb_hnext list.  Create a new tdb_walk list with
+	 * exclusive netlock protection.
 	 */
-	KERNEL_LOCK();
+	NET_ASSERT_WLOCKED();
+	SIMPLEQ_INIT(&tdblist);
+
 	mtx_enter(&tdb_sadb_mtx);
 	for (i = 0; i <= tdb_hashmask; i++) {
-		for (tdbp = tdbh[i]; rval == 0 && tdbp != NULL; tdbp = next) {
-			next = tdbp->tdb_hnext;
-
+		for (tdbp = tdbh[i]; tdbp != NULL; tdbp = tdbp->tdb_hnext) {
 			if (rdomain != tdbp->tdb_rdomain)
 				continue;
-
-			if (i == tdb_hashmask && next == NULL)
-				rval = walker(tdbp, (void *)arg, 1);
-			else
-				rval = walker(tdbp, (void *)arg, 0);
+			tdb_ref(tdbp);
+			SIMPLEQ_INSERT_TAIL(&tdblist, tdbp, tdb_walk);
 		}
 	}
 	mtx_leave(&tdb_sadb_mtx);
-	KERNEL_UNLOCK();
+
+	rval = 0;
+	while ((tdbp = SIMPLEQ_FIRST(&tdblist)) != NULL) {
+		SIMPLEQ_REMOVE_HEAD(&tdblist, tdb_walk);
+		if (rval == 0)
+			rval = walker(tdbp, arg, SIMPLEQ_EMPTY(&tdblist));
+		tdb_unref(tdbp);
+	}
 
 	return rval;
 }
@@ -764,7 +769,6 @@ tdb_rehash(void)
 		return (ENOMEM);
 	}
 
-
 	for (i = 0; i <= old_hashmask; i++) {
 		for (tdbp = tdbh[i]; tdbp != NULL; tdbp = tdbnp) {
 			tdbnp = tdbp->tdb_hnext;
@@ -1003,19 +1007,6 @@ tdb_unref(struct tdb *tdb)
 
 void
 tdb_delete(struct tdb *tdbp)
-{
-	tdb_dodelete(tdbp, 0);
-}
-
-void
-tdb_delete_locked(struct tdb *tdbp)
-{
-	MUTEX_ASSERT_LOCKED(&tdb_sadb_mtx);
-	tdb_dodelete(tdbp, 1);
-}
-
-void
-tdb_dodelete(struct tdb *tdbp, int locked)
 {
 	NET_ASSERT_LOCKED();
 
@@ -1026,10 +1017,7 @@ tdb_dodelete(struct tdb *tdbp, int locked)
 	}
 	tdbp->tdb_flags |= TDBF_DELETED;
 	mtx_leave(&tdbp->tdb_mtx);
-	if (locked)
-		tdb_unlink_locked(tdbp);
-	else
-		tdb_unlink(tdbp);
+	tdb_unlink(tdbp);
 
 	/* cleanup SPD references */
 	tdb_cleanspd(tdbp);
diff --git a/sys/netinet/ip_ipsp.h b/sys/netinet/ip_ipsp.h
index b04b8dd9d73..d4d3c955975 100644
--- a/sys/netinet/ip_ipsp.h
+++ b/sys/netinet/ip_ipsp.h
@@ -1,4 +1,4 @@
-/*	$OpenBSD: ip_ipsp.h,v 1.231 2021/12/14 17:50:37 bluhm Exp $	*/
+/*	$OpenBSD: ip_ipsp.h,v 1.232 2021/12/19 23:30:08 bluhm Exp $	*/
 /*
  * The authors of this code are John Ioannidis (ji@tla.org),
  * Angelos D. Keromytis (kermit@csd.uch.gr),
@@ -335,6 +335,7 @@ struct tdb {				/* tunnel descriptor block */
 	struct tdb	*tdb_snext;	/* [s] src/sproto table */
 	struct tdb	*tdb_inext;
 	struct tdb	*tdb_onext;
+	SIMPLEQ_ENTRY(tdb) tdb_walk;	/* [N] temp list for tdb walker */
 
 	struct refcnt	tdb_refcnt;
 	struct mutex	tdb_mtx;
@@ -583,7 +584,6 @@ struct	tdb *gettdbbysrcdst_dir(u_int, u_int32_t, union sockaddr_union *,
 void	puttdb(struct tdb *);
 void	puttdb_locked(struct tdb *);
 void	tdb_delete(struct tdb *);
-void	tdb_delete_locked(struct tdb *);
 struct	tdb *tdb_alloc(u_int);
 struct	tdb *tdb_ref(struct tdb *);
 void	tdb_unref(struct tdb *);