From: tb <tb@openbsd.org>
Date: Tue, 30 Aug 2022 19:33:26 +0000 (+0000)
Subject: chacha20_poly1305_cleanup() should return 1
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=9a36bc948a2e44d373123d1a3c7836cdd506a1e9;p=openbsd

chacha20_poly1305_cleanup() should return 1

Otherwise EVP_CIPHER_CTX_cleanup() leaks, as spotted by the ASAN CI.

ok jsing
---

diff --git a/lib/libcrypto/evp/e_chacha20poly1305.c b/lib/libcrypto/evp/e_chacha20poly1305.c
index 422eb23758b..674a323258f 100644
--- a/lib/libcrypto/evp/e_chacha20poly1305.c
+++ b/lib/libcrypto/evp/e_chacha20poly1305.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: e_chacha20poly1305.c,v 1.24 2022/08/21 10:47:09 tb Exp $ */
+/* $OpenBSD: e_chacha20poly1305.c,v 1.25 2022/08/30 19:33:26 tb Exp $ */
 
 /*
  * Copyright (c) 2022 Joel Sing <jsing@openbsd.org>
@@ -537,7 +537,7 @@ chacha20_poly1305_cleanup(EVP_CIPHER_CTX *ctx)
 
 	explicit_bzero(cpx, sizeof(*cpx));
 
-	return 0;
+	return 1;
 }
 
 static int