From: zhuk Date: Thu, 7 Dec 2017 05:09:27 +0000 (+0000) Subject: client_addr_init() never fails and its return value is never checked, X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=8adff840dcae1041848600f4d9b04d5fb5b966d8;p=openbsd client_addr_init() never fails and its return value is never checked, so just make it void. okay jmatthew@ --- diff --git a/usr.sbin/ypldap/ldapclient.c b/usr.sbin/ypldap/ldapclient.c index db4b0859e8b..981f610d109 100644 --- a/usr.sbin/ypldap/ldapclient.c +++ b/usr.sbin/ypldap/ldapclient.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ldapclient.c,v 1.40 2017/12/07 05:06:08 zhuk Exp $ */ +/* $OpenBSD: ldapclient.c,v 1.41 2017/12/07 05:09:27 zhuk Exp $ */ /* * Copyright (c) 2008 Alexander Schrijver @@ -54,7 +54,7 @@ int client_build_req(struct idm *, struct idm_req *, struct aldap_message *, int client_search_idm(struct env *, struct idm *, struct aldap *, char **, char *, int, int, enum imsg_type); int client_try_idm(struct env *, struct idm *); -int client_addr_init(struct idm *); +void client_addr_init(struct idm *); int client_addr_free(struct idm *); struct aldap *client_aldap_open(struct ypldap_addr_list *); @@ -97,7 +97,7 @@ client_aldap_open(struct ypldap_addr_list *addr) return al; } -int +void client_addr_init(struct idm *idm) { struct sockaddr_in *sa_in; @@ -131,8 +131,6 @@ client_addr_init(struct idm *idm) /* not reached */ } } - - return (0); } int