From: djm <djm@openbsd.org>
Date: Wed, 31 Mar 2021 21:59:26 +0000 (+0000)
Subject: cannot effectively test posix-rename extension after changes in
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=81f17920895eac29225f190152d72b1d36f7a6b4;p=openbsd

cannot effectively test posix-rename extension after changes in
feature advertisment.
---

diff --git a/regress/usr.bin/ssh/sftp-perm.sh b/regress/usr.bin/ssh/sftp-perm.sh
index 3448740bc14..006e141dd38 100644
--- a/regress/usr.bin/ssh/sftp-perm.sh
+++ b/regress/usr.bin/ssh/sftp-perm.sh
@@ -1,4 +1,4 @@
-#	$OpenBSD: sftp-perm.sh,v 1.2 2013/10/17 22:00:18 djm Exp $
+#	$OpenBSD: sftp-perm.sh,v 1.3 2021/03/31 21:59:26 djm Exp $
 #	Placed in the Public Domain.
 
 tid="sftp permissions"
@@ -220,13 +220,15 @@ perm_test \
 	"test ! -d ${COPY}.dd" \
 	"test -d ${COPY}.dd"
 
-perm_test \
-	"posix-rename" \
-	"realpath,stat,lstat" \
-	"rename $COPY ${COPY}.1" \
-	"touch $COPY" \
-	"test -f ${COPY}.1 -a ! -f $COPY" \
-	"test -f $COPY -a ! -f ${COPY}.1"
+# Can't readily test this because the client falls back to traditional rename.
+# XXX maybe there is a behaviorial difference we can test for?
+#perm_test \
+#	"posix-rename" \
+#	"realpath,stat,lstat" \
+#	"rename $COPY ${COPY}.1" \
+#	"touch $COPY" \
+#	"test -f ${COPY}.1 -a ! -f $COPY" \
+#	"test -f $COPY -a ! -f ${COPY}.1"
 
 perm_test \
 	"rename" \