From: deraadt <deraadt@openbsd.org>
Date: Wed, 5 Apr 2017 15:57:11 +0000 (+0000)
Subject: Clamp size to length if snprintf ever indicates overflow
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=807febab5df9fa49018f9723f7eff4f82638b8b2;p=openbsd

Clamp size to length if snprintf ever indicates overflow
w/ millert
---

diff --git a/usr.bin/systat/engine.c b/usr.bin/systat/engine.c
index 2844f873ee6..64cfc86d334 100644
--- a/usr.bin/systat/engine.c
+++ b/usr.bin/systat/engine.c
@@ -1,4 +1,4 @@
-/* $Id: engine.c,v 1.20 2017/04/05 04:44:03 deraadt Exp $	 */
+/* $Id: engine.c,v 1.21 2017/04/05 15:57:11 deraadt Exp $	 */
 /*
  * Copyright (c) 2001, 2007 Can Erkin Acar <canacar@openbsd.org>
  *
@@ -347,6 +347,8 @@ print_bar_title(field_def *fld)
 		}
 
 		len = snprintf(buf, sizeof(buf), "%d\\", val);
+		if (len >= sizeof(buf))
+			len = strlen(buf);
 		while (cur < pos - len) {
 			tbprintf(" ");
 			cur++;