From: claudio <claudio@openbsd.org>
Date: Mon, 17 May 2021 10:09:53 +0000 (+0000)
Subject: Stop setting IPV6_MINMTU in ip6_send() which is used by the ICMP code.
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=75f91b61a2eeb6b793f67966e5b48b36a2b41a4f;p=openbsd

Stop setting IPV6_MINMTU in ip6_send() which is used by the ICMP code.
Because of this large ping packets where fragmented even if the MTU did
not indicate the need for it. This causes some trouble when system do
not expect to receive a fragmented answer from a system. One such case
is the automated link test from google routers before allowing to establish
a BGP peering session with them. In general PMTU problems should be an
issue from the past and if not it may be better to also break on ping
packets and not only for UDP and TCP. ICMP ping is normaly the first
tool in the admins toolbox to figure out network issues.
OK phessler@ florian@ bluhm@
---

diff --git a/sys/netinet6/ip6_input.c b/sys/netinet6/ip6_input.c
index 7d76fa7dbf9..0c1c5bae03b 100644
--- a/sys/netinet6/ip6_input.c
+++ b/sys/netinet6/ip6_input.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: ip6_input.c,v 1.233 2021/04/30 13:52:48 bluhm Exp $	*/
+/*	$OpenBSD: ip6_input.c,v 1.234 2021/05/17 10:09:53 claudio Exp $	*/
 /*	$KAME: ip6_input.c,v 1.188 2001/03/29 05:34:31 itojun Exp $	*/
 
 /*
@@ -1478,14 +1478,7 @@ ip6_send_dispatch(void *xmq)
 
 	NET_LOCK();
 	while ((m = ml_dequeue(&ml)) != NULL) {
-		/*
-		 * To avoid a "too big" situation at an intermediate router and
-		 * the path MTU discovery process, specify the IPV6_MINMTU
-		 * flag.  Note that only echo and node information replies are
-		 * affected, since the length of ICMP6 errors is limited to the
-		 * minimum MTU.
-		 */
-		ip6_output(m, NULL, NULL, IPV6_MINMTU, NULL, NULL);
+		ip6_output(m, NULL, NULL, 0, NULL, NULL);
 	}
 	NET_UNLOCK();
 }