From: schwarze <schwarze@openbsd.org>
Date: Thu, 9 Sep 2021 11:48:06 +0000 (+0000)
Subject: Do not abuse the "cleandir" target to delete part of the test output.
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=737c6b3ccfcab373031fd397dfa832f0ab65ed4b;p=openbsd

Do not abuse the "cleandir" target to delete part of the test output.
According to /usr/share/mk/bsd.README, that target is only intended
to delete tags files, and there are no tags files here.  Instead,
make sure the "clean" target does not leave any test output behind.

Issue reported and patch OK'ed by bluhm@.
---

diff --git a/regress/usr.bin/mandoc/db/run/Makefile b/regress/usr.bin/mandoc/db/run/Makefile
index 0129843d83f..e9f082733ea 100644
--- a/regress/usr.bin/mandoc/db/run/Makefile
+++ b/regress/usr.bin/mandoc/db/run/Makefile
@@ -1,4 +1,4 @@
-# $OpenBSD: Makefile,v 1.10 2021/07/18 11:25:48 schwarze Exp $
+# $OpenBSD: Makefile,v 1.11 2021/09/09 11:48:06 schwarze Exp $
 #
 # Copyright (c) 2016 Ingo Schwarze <schwarze@openbsd.org>
 #
@@ -75,11 +75,6 @@ diff.merr: all.merr
 
 .PHONY: ${REGRESS_TARGETS}
 
-cleandir: cleandir_local
-
-cleandir_local:
-	rm -rf ${MOB_TESTS:C/$/.dir/}
-
 
 # === RUNNING DBM_DUMP =================================================
 
@@ -476,3 +471,9 @@ binedit dbm_dump makeinodes:
 	ln -sf ${.OBJDIR}/../$@/$@ .
 
 .include <bsd.regress.mk>
+
+# must come after the .include: <bsd.prog.mk> contains .if !target(clean)
+clean: clean_local
+
+clean_local:
+	rm -rf ${MOB_TESTS:C/$/.dir/}