From: claudio <claudio@openbsd.org>
Date: Thu, 4 Mar 2021 14:00:26 +0000 (+0000)
Subject: Simply ignore errors from tls_close(). ftp(1) does the same and it seems
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=6ded7de0b591627b3a5e2ccd6e97e3dd82ccb192;p=openbsd

Simply ignore errors from tls_close(). ftp(1) does the same and it seems
too many servers out there fail to properly close the TLS session which
results in unneccessary warnings like
  TLS close: EOF without close notify
Result of a discussion with job@ and tb@
---

diff --git a/usr.sbin/rpki-client/http.c b/usr.sbin/rpki-client/http.c
index cb2d9dc344d..0e84c0b5c43 100644
--- a/usr.sbin/rpki-client/http.c
+++ b/usr.sbin/rpki-client/http.c
@@ -1,4 +1,4 @@
-/*      $OpenBSD: http.c,v 1.1 2021/03/04 13:01:41 claudio Exp $  */
+/*      $OpenBSD: http.c,v 1.2 2021/03/04 14:00:26 claudio Exp $  */
 /*
  * Copyright (c) 2020 Nils Fisher <nils_fisher@hotmail.com>
  * Copyright (c) 2020 Claudio Jeker <claudio@openbsd.com>
@@ -328,11 +328,8 @@ http_close(struct http_connection *conn)
 		case TLS_WANT_POLLOUT:
 			return WANT_POLLOUT;
 		case 0:
-			break;
 		case -1:
-			warnx("%s: TLS close: %s", http_info(conn->url),
-			    tls_error(conn->tls));
-			return -1;
+			break;
 		}
 	}