From: tb Date: Sat, 22 Sep 2018 15:53:38 +0000 (+0000) Subject: Add a comment on the acceptable RSASSA cases. X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=6c11331781b894d63ac39e45987c9afbff9574c1;p=openbsd Add a comment on the acceptable RSASSA cases. --- diff --git a/regress/lib/libcrypto/wycheproof/wycheproof.go b/regress/lib/libcrypto/wycheproof/wycheproof.go index c7b23b21fc6..fcd806f29e9 100644 --- a/regress/lib/libcrypto/wycheproof/wycheproof.go +++ b/regress/lib/libcrypto/wycheproof/wycheproof.go @@ -1,4 +1,4 @@ -/* $OpenBSD: wycheproof.go,v 1.65 2018/09/22 14:12:47 tb Exp $ */ +/* $OpenBSD: wycheproof.go,v 1.66 2018/09/22 15:53:38 tb Exp $ */ /* * Copyright (c) 2018 Joel Sing * Copyright (c) 2018 Theo Buehler @@ -1385,9 +1385,10 @@ func runRSASSATest(rsa *C.RSA, h hash.Hash, sha *C.EVP_MD, mgfSha *C.EVP_MD, sLe ret = C.RSA_verify_PKCS1_PSS_mgf1(rsa, (*C.uchar)(unsafe.Pointer(&msg[0])), sha, mgfSha, (*C.uchar)(unsafe.Pointer(&sigOut[0])), C.int(sLen)) - // XXX: audit acceptable cases... success := false if ret == 1 && (wt.Result == "valid" || wt.Result == "acceptable") { + // All acceptable cases that pass use SHA-1 and are flagged: + // "WeakHash" : "The key for this test vector uses a weak hash function." if acceptableAudit && wt.Result == "acceptable" { gatherAcceptableStatistics(wt.TCID, wt.Comment, wt.Flags) }