From: claudio <claudio@openbsd.org>
Date: Tue, 30 Aug 2022 12:45:13 +0000 (+0000)
Subject: In RRDP mode it is possible that a file in the validated cache dir is
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=664a7260cfd4d945ffc83e22c027705d5bd105ce;p=openbsd

In RRDP mode it is possible that a file in the validated cache dir is
no longer valid while the newer file in the .rrdp directory is not (yet)
valid. In this case do not copy the old file over the newer file.
RRDP has no method to identiy inconsistent repos (unlike rsync) so if
the wrong file is put in .rrdp it is not noticed appart from the
verification process failing for that file.
OK tb@ job@
---

diff --git a/usr.sbin/rpki-client/repo.c b/usr.sbin/rpki-client/repo.c
index 1133d47f158..80d4dccb8e6 100644
--- a/usr.sbin/rpki-client/repo.c
+++ b/usr.sbin/rpki-client/repo.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: repo.c,v 1.35 2022/07/17 10:32:45 jsg Exp $ */
+/*	$OpenBSD: repo.c,v 1.36 2022/08/30 12:45:13 claudio Exp $ */
 /*
  * Copyright (c) 2021 Claudio Jeker <claudio@openbsd.org>
  * Copyright (c) 2019 Kristaps Dzonsons <kristaps@bsd.lv>
@@ -1396,12 +1396,24 @@ repo_cleanup(struct filepath_tree *tree, int cachefd)
 			}
 			rr = repo_is_rrdp(e->fts_parent->fts_pointer);
 			if (rr != NULL) {
+				struct stat st;
 				char *fn;
 
 				if (asprintf(&fn, "%s/%s", rr->basedir,
 				    path) == -1)
 					err(1, NULL);
 
+				/*
+				 * If the file exists in the rrdp dir
+				 * that file is newer and needs to be kept
+				 * so unlink this file instead of moving
+				 * it over the file in the rrdp dir.
+				 */
+				if (fstatat(cachefd, fn, &st, 0) == 0 &&
+				    S_ISREG(st.st_mode)) {
+					free(fn);
+					goto unlink;
+				}
 				if (repo_mkpath(cachefd, fn) == 0) {
 					if (renameat(AT_FDCWD, e->fts_accpath,
 					    cachefd, fn) == -1)
@@ -1413,6 +1425,7 @@ repo_cleanup(struct filepath_tree *tree, int cachefd)
 				}
 				free(fn);
 			} else {
+ unlink:
 				if (unlink(e->fts_accpath) == -1) {
 					warn("unlink %s", path);
 				} else {