From: sashan <sashan@openbsd.org>
Date: Mon, 6 Dec 2021 07:41:33 +0000 (+0000)
Subject: fix odd check in pfi_kif_free()
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=655f9804762dfa336e800d7bdd3ff15bf9778ee6;p=openbsd

fix odd check in pfi_kif_free()
pointed out by jsg@


OK jsg@
---

diff --git a/sys/net/pf_if.c b/sys/net/pf_if.c
index 8de37375ab4..6a83e86583e 100644
--- a/sys/net/pf_if.c
+++ b/sys/net/pf_if.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: pf_if.c,v 1.101 2021/11/11 12:35:01 sashan Exp $ */
+/*	$OpenBSD: pf_if.c,v 1.102 2021/12/06 07:41:33 sashan Exp $ */
 
 /*
  * Copyright 2005 Henning Brauer <henning@openbsd.org>
@@ -107,9 +107,8 @@ pfi_kif_free(struct pfi_kif *kif)
 	if (kif == NULL)
 		return;
 
-	if ((kif->pfik_rules != 0) || (kif->pfik_states != 0) ||
-	    (kif->pfik_states != 0) || (kif->pfik_states != 0) ||
-	    (kif->pfik_srcnodes != 0))
+	if (kif->pfik_rules || kif->pfik_states || kif->pfik_routes ||
+	    kif->pfik_srcnodes)
 		panic("kif is still alive");
 
 	free(kif, PFI_MTYPE, sizeof(*kif));