From: tb <tb@openbsd.org>
Date: Fri, 23 Jun 2023 10:50:47 +0000 (+0000)
Subject: Codify BN_asc2bn(NULL, *) behavior in regress.
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=6230b67351c594aa6954e0662a54c8f99adfdc38;p=openbsd

Codify BN_asc2bn(NULL, *) behavior in regress.
---

diff --git a/regress/lib/libcrypto/bn/bn_convert.c b/regress/lib/libcrypto/bn/bn_convert.c
index 147bb6839a5..69f7da43b1c 100644
--- a/regress/lib/libcrypto/bn/bn_convert.c
+++ b/regress/lib/libcrypto/bn/bn_convert.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: bn_convert.c,v 1.2 2023/05/27 15:50:56 jsing Exp $ */
+/*	$OpenBSD: bn_convert.c,v 1.3 2023/06/23 10:50:47 tb Exp $ */
 /*
  * Copyright (c) 2023 Joel Sing <jsing@openbsd.org>
  *
@@ -214,6 +214,16 @@ test_bn_asc2bn(void)
 		}
 	}
 
+	/*
+	 * While it makes little sense to call BN_asc2bn() with a NULL bn,
+	 * check for consistent behavior.
+	 */
+	if (!BN_asc2bn(NULL, "1") || !BN_asc2bn(NULL, "-1") ||
+	    !BN_asc2bn(NULL, "0x1") || !BN_asc2bn(NULL, "-0x1")) {
+		fprintf(stderr, "FAIL: BN_asc2bn() with NULL BIGNUM failed\n");
+		goto failure;
+	}
+
 	failed = 0;
 
  failure: