From: jsg <jsg@openbsd.org>
Date: Wed, 14 Feb 2024 02:44:58 +0000 (+0000)
Subject: avoid use after free of q
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=5e763c0b58cd097cacb9dfadbb2542582c0715ad;p=openbsd

avoid use after free of q
found by smatch, ok miod@ deraadt@
---

diff --git a/usr.sbin/radiusd/radiusd.c b/usr.sbin/radiusd/radiusd.c
index 3fc7ad0e454..4419e309552 100644
--- a/usr.sbin/radiusd/radiusd.c
+++ b/usr.sbin/radiusd/radiusd.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: radiusd.c,v 1.35 2024/02/09 07:46:32 yasuoka Exp $	*/
+/*	$OpenBSD: radiusd.c,v 1.36 2024/02/14 02:44:58 jsg Exp $	*/
 
 /*
  * Copyright (c) 2013, 2023 Internet Initiative Japan Inc.
@@ -1286,6 +1286,7 @@ radiusd_module_imsg(struct radiusd_module *module, struct imsg *imsg)
 					log_warn("q=%u wrong pkt from module",
 					    q->id);
 					radiusd_access_request_aborted(q);
+					break;
 				}
 				q->res = radpkt;
 				radiusd_access_request_answer(q);