From: kettenis Date: Sat, 28 Aug 2021 06:03:25 +0000 (+0000) Subject: Remove bogus code that tries to unmap GTT pages in a codepath that clearly X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=5b8bafd5d9fe2aeb337a178fc14ad19328005584;p=openbsd Remove bogus code that tries to unmap GTT pages in a codepath that clearly doesn't deal with non-GTT mappings. What the Linux code does here isn't possible on OpenBSD and probably unecessary. Seems to fix a crash reported by sthen@ ok jsg@ --- diff --git a/sys/dev/pci/drm/i915/gem/i915_gem_mman.c b/sys/dev/pci/drm/i915/gem/i915_gem_mman.c index 8b5bb94a7ef..c326e2f9bd6 100644 --- a/sys/dev/pci/drm/i915/gem/i915_gem_mman.c +++ b/sys/dev/pci/drm/i915/gem/i915_gem_mman.c @@ -841,19 +841,6 @@ void i915_gem_object_release_mmap_offset(struct drm_i915_gem_object *obj) #ifdef __linux__ drm_vma_node_unmap(&mmo->vma_node, obj->base.dev->anon_inode->i_mapping); -#else - if (drm_mm_node_allocated(&mmo->vma_node.vm_node)) { - struct drm_i915_private *dev_priv = obj->base.dev->dev_private; - struct i915_vma *vma; - struct vm_page *pg; - - for_each_ggtt_vma(vma, obj) { - for (pg = &dev_priv->pgs[atop(vma->node.start)]; - pg != &dev_priv->pgs[atop(vma->node.start + vma->size)]; - pg++) - pmap_page_protect(pg, PROT_NONE); - } - } #endif spin_lock(&obj->mmo.lock); }