From: tb <tb@openbsd.org>
Date: Fri, 28 Apr 2023 15:21:22 +0000 (+0000)
Subject: Deassert x509_policy_level_add_nodes()
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=574a74f041dafe8a4d67e672bafbae3338f29221;p=openbsd

Deassert x509_policy_level_add_nodes()

This assert is in debugging code that ensures that there are no duplicate
nodes on this level. This is an expensive and unnecessary check. Duplicates
already cause failures as ensured by regress.

with beck
ok jsing
---

diff --git a/lib/libcrypto/x509/x509_policy.c b/lib/libcrypto/x509/x509_policy.c
index c8f9447e4f6..0f60a11c77d 100644
--- a/lib/libcrypto/x509/x509_policy.c
+++ b/lib/libcrypto/x509/x509_policy.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: x509_policy.c,v 1.17 2023/04/28 15:16:48 tb Exp $ */
+/*	$OpenBSD: x509_policy.c,v 1.18 2023/04/28 15:21:22 tb Exp $ */
 /*
  * Copyright (c) 2022, Google Inc.
  *
@@ -319,15 +319,6 @@ x509_policy_level_add_nodes(X509_POLICY_LEVEL *level,
 	}
 	sk_X509_POLICY_NODE_sort(level->nodes);
 
-#if !defined(NDEBUG)
-	/* There should be no duplicate nodes. */
-	for (i = 1; i < sk_X509_POLICY_NODE_num(level->nodes); i++) {
-		assert(
-		    OBJ_cmp(
-		    sk_X509_POLICY_NODE_value(level->nodes, i - 1)->policy,
-		    sk_X509_POLICY_NODE_value(level->nodes, i)->policy) != 0);
-	}
-#endif
 	return 1;
 }