From: job <job@openbsd.org>
Date: Tue, 20 Jun 2023 11:06:47 +0000 (+0000)
Subject: Be explicit when SIA is without rsync accessLocation
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=49409ac08c77c59c9e749bacfe3e4ca258a1a4e7;p=openbsd

Be explicit when SIA is without rsync accessLocation

OK tb@
---

diff --git a/usr.sbin/rpki-client/x509.c b/usr.sbin/rpki-client/x509.c
index 59f6d10a584..db1d21cde91 100644
--- a/usr.sbin/rpki-client/x509.c
+++ b/usr.sbin/rpki-client/x509.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: x509.c,v 1.71 2023/05/22 15:07:02 tb Exp $ */
+/*	$OpenBSD: x509.c,v 1.72 2023/06/20 11:06:47 job Exp $ */
 /*
  * Copyright (c) 2022 Theo Buehler <tb@openbsd.org>
  * Copyright (c) 2021 Claudio Jeker <claudio@openbsd.org>
@@ -479,8 +479,11 @@ x509_get_sia(X509 *x, const char *fn, char **sia)
 		*sia = NULL;
 	}
 
-	if (!rsync_found)
+	if (!rsync_found) {
+		warnx("%s: RFC 6487 section 4.8.8.2: "
+		    "SIA without rsync accessLocation", fn);
 		goto out;
+	}
 
 	AUTHORITY_INFO_ACCESS_free(info);
 	return 1;