From: stsp <stsp@openbsd.org>
Date: Sun, 18 Aug 2024 07:34:45 +0000 (+0000)
Subject: plug a memory leak in qwx(4) by freeing vifs when the interface goes down
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=3cdb772b7a68146cacd1fd0a9f4f4a28bf6b55cf;p=openbsd

plug a memory leak in qwx(4) by freeing vifs when the interface goes down
---

diff --git a/sys/dev/ic/qwx.c b/sys/dev/ic/qwx.c
index fe079d43c26..684210a993d 100644
--- a/sys/dev/ic/qwx.c
+++ b/sys/dev/ic/qwx.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: qwx.c,v 1.64 2024/08/17 08:12:46 stsp Exp $	*/
+/*	$OpenBSD: qwx.c,v 1.65 2024/08/18 07:34:45 stsp Exp $	*/
 
 /*
  * Copyright 2023 Stefan Sperling <stsp@openbsd.org>
@@ -158,6 +158,7 @@ int qwx_wmi_vdev_install_key(struct qwx_softc *,
 int qwx_dp_peer_rx_pn_replay_config(struct qwx_softc *, struct qwx_vif *,
     struct ieee80211_node *, struct ieee80211_key *, int);
 void qwx_setkey_clear(struct qwx_softc *);
+void qwx_vif_free_all(struct qwx_softc *);
 
 int qwx_scan(struct qwx_softc *);
 void qwx_scan_abort(struct qwx_softc *);
@@ -348,6 +349,8 @@ qwx_stop(struct ifnet *ifp)
 	/* power off hardware */
 	qwx_core_deinit(sc);
 
+	qwx_vif_free_all(sc);
+
 	splx(s);
 }
 
@@ -22815,6 +22818,18 @@ qwx_vif_free(struct qwx_softc *sc, struct qwx_vif *arvif)
 	free(arvif, M_DEVBUF, sizeof(*arvif));
 }
 
+void
+qwx_vif_free_all(struct qwx_softc *sc)
+{
+	struct qwx_vif *arvif;
+
+	while (!TAILQ_EMPTY(&sc->vif_list)) {
+		arvif = TAILQ_FIRST(&sc->vif_list);
+		TAILQ_REMOVE(&sc->vif_list, arvif, entry);
+		qwx_vif_free(sc, arvif);
+	}
+}
+
 struct qwx_vif *
 qwx_vif_alloc(struct qwx_softc *sc)
 {