From: niklas <niklas@openbsd.org>
Date: Wed, 4 Sep 1996 22:24:23 +0000 (+0000)
Subject: Do not do the if(a = b) game even if correct, it is confusing
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=3874e8bf14f911c086ddf0b2e9b5f742ea47351d;p=openbsd

Do not do the if(a = b) game even if correct, it is confusing
---

diff --git a/sys/kern/kern_lkm.c b/sys/kern/kern_lkm.c
index 7d5d3d105d3..93eaa741ff2 100644
--- a/sys/kern/kern_lkm.c
+++ b/sys/kern/kern_lkm.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: kern_lkm.c,v 1.7 1996/08/29 15:17:37 deraadt Exp $	*/
+/*	$OpenBSD: kern_lkm.c,v 1.8 1996/09/04 22:24:23 niklas Exp $	*/
 /*	$NetBSD: kern_lkm.c,v 1.31 1996/03/31 21:40:27 christos Exp $	*/
 
 /*
@@ -407,7 +407,9 @@ lkmioctl(dev, cmd, data, flag, p)
 		}
 
 		/* copy in buffer full of data*/
-		if (error = copyin(loadbufp->data, curp->syms + curp->sym_offset, i))
+		error = copyin(loadbufp->data, curp->syms + curp->sym_offset,
+		    i);
+		if (error)
 			break;
 
 		if ((curp->sym_offset + i) < curp->sym_size) {