From: deraadt Date: Thu, 17 Jul 2014 14:30:41 +0000 (+0000) Subject: "Race-free because we're running single-threaded in a new X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=29a8d8f8233aa7f86e86994c7b6886165d09ae25;p=openbsd "Race-free because we're running single-threaded in a new address space, and once allocated rs is never deallocated." document the forkhandler to save reviewers time, with matthew --- diff --git a/lib/libc/crypt/arc4random.c b/lib/libc/crypt/arc4random.c index 3b7f34faed5..565bfa03336 100644 --- a/lib/libc/crypt/arc4random.c +++ b/lib/libc/crypt/arc4random.c @@ -1,4 +1,4 @@ -/* $OpenBSD: arc4random.c,v 1.45 2014/07/16 00:18:54 deraadt Exp $ */ +/* $OpenBSD: arc4random.c,v 1.46 2014/07/17 14:30:41 deraadt Exp $ */ /* * Copyright (c) 1996, David Mazieres @@ -69,6 +69,10 @@ static inline void _rs_rekey(u_char *dat, size_t datlen); static inline void _rs_forkhandler(void) { + /* + * Race-free because we're running single-threaded in a new + * address space, and once allocated rs is never deallocated. + */ if (rs) rs->rs_count = 0; }