From: dlg <dlg@openbsd.org>
Date: Fri, 31 Mar 2023 23:53:49 +0000 (+0000)
Subject: dont match quectel ec25 by vendor+product id
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=208d6d989ed365cfd69af7d05d7d7b381ccdc599;p=openbsd

dont match quectel ec25 by vendor+product id

quectel seem to provide a sane and consistent set of functionality
built on top of the qualcomm qmi stuff. their linux drivers guide
says quectel modems provide a set of umsm usb interfaces and a
network interface that can be in qmi, ecm, or mbim mode.

if the modem is in mbim mode, it will present the mbim classes which
umb should be able to attach to without this explicit vendor+product
match (assuming umsm doesn't claim the interface first).

based on info in the Quectel LTE&5G Linux USB Driver User Guide V2.0

discussed with and tested by kevlo@
ok patrick@ sthen@ kevlo@
---

diff --git a/sys/dev/usb/if_umb.c b/sys/dev/usb/if_umb.c
index 889be97477c..ca89f55ce1b 100644
--- a/sys/dev/usb/if_umb.c
+++ b/sys/dev/usb/if_umb.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: if_umb.c,v 1.49 2022/01/11 10:34:13 claudio Exp $ */
+/*	$OpenBSD: if_umb.c,v 1.50 2023/03/31 23:53:49 dlg Exp $ */
 
 /*
  * Copyright (c) 2016 genua mbH
@@ -238,13 +238,6 @@ const struct umb_quirk umb_quirks[] = {
 	  UMATCH_VENDOR_PRODUCT
 	},
 
-	{ { USB_VENDOR_QUECTEL, USB_PRODUCT_QUECTEL_EC25 },
-	  0,
-	  1,
-	  UMATCH_VENDOR_PRODUCT
-	},
-
-
 	{ { USB_VENDOR_HUAWEI, USB_PRODUCT_HUAWEI_ME906S },
 	  UMBFLG_NDP_AT_END,
 	  3,