From: kn <kn@openbsd.org>
Date: Fri, 28 Oct 2022 15:02:20 +0000 (+0000)
Subject: Remove audio(9) get_props() from record-only drivers
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=1ed425b445d931aa4607a70227b92ddf8683ea15;p=openbsd

Remove audio(9) get_props() from record-only drivers

utvfu(4) seems to be the only driver that currently supports recording but
not playing and its open() already returns ENXIO when playing is requested,
so no need to add another duplex check after get_props() is gone.

OK ratchov miod
---

diff --git a/sys/dev/usb/utvfu.c b/sys/dev/usb/utvfu.c
index 930f2d12568..e6807f992e0 100644
--- a/sys/dev/usb/utvfu.c
+++ b/sys/dev/usb/utvfu.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: utvfu.c,v 1.18 2022/10/19 19:14:17 kn Exp $ */
+/*	$OpenBSD: utvfu.c,v 1.19 2022/10/28 15:02:20 kn Exp $ */
 /*
  * Copyright (c) 2013 Lubomir Rintel
  * Copyright (c) 2013 Federico Simoncelli
@@ -795,7 +795,6 @@ int		utvfu_audio_halt_in(void *);
 int		utvfu_audio_mixer_set_port(void *, struct mixer_ctrl *);
 int		utvfu_audio_mixer_get_port(void *, struct mixer_ctrl *);
 int		utvfu_audio_query_devinfo(void *, struct mixer_devinfo *);
-int		utvfu_audio_get_props(void *);
 int		utvfu_audio_trigger_output(void *, void *, void *, int,
 		    void (*)(void *), void *, struct audio_params *);
 int		utvfu_audio_trigger_input(void *, void *, void *, int,
@@ -851,7 +850,6 @@ const struct audio_hw_if utvfu_au_hw_if = {
 	.set_port = utvfu_audio_mixer_set_port,
 	.get_port = utvfu_audio_mixer_get_port,
 	.query_devinfo = utvfu_audio_query_devinfo,
-	.get_props = utvfu_audio_get_props,
 	.trigger_output = utvfu_audio_trigger_output,
 	.trigger_input = utvfu_audio_trigger_input,
 };
@@ -1995,12 +1993,6 @@ utvfu_audio_query_devinfo(void *v, struct mixer_devinfo *mi)
 	return (0);
 }
 
-int
-utvfu_audio_get_props(void *v)
-{
-	return (0);
-}
-
 int
 utvfu_audio_trigger_output(void *v, void *start, void *end, int blksize,
     void (*intr)(void *), void *arg, struct audio_params *param)