From: tb <tb@openbsd.org>
Date: Fri, 14 Apr 2023 14:23:05 +0000 (+0000)
Subject: Plug a memleak caused by an extra bump of a refcount
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=1ea2b8b10d9b5a8b32e8e20e1d8ca78b50ab7bd5;p=openbsd

Plug a memleak caused by an extra bump of a refcount

SSL_set_session() should really be called SSL_set1_session()...
---

diff --git a/regress/lib/libssl/exporter/exportertest.c b/regress/lib/libssl/exporter/exportertest.c
index 66155bde574..252fcb062e5 100644
--- a/regress/lib/libssl/exporter/exportertest.c
+++ b/regress/lib/libssl/exporter/exportertest.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: exportertest.c,v 1.2 2022/11/26 16:08:56 tb Exp $ */
+/* $OpenBSD: exportertest.c,v 1.3 2023/04/14 14:23:05 tb Exp $ */
 /*
  * Copyright (c) 2022 Joel Sing <jsing@openbsd.org>
  *
@@ -558,7 +558,6 @@ exporter_test(size_t test_no, const struct exporter_test *et)
 		fprintf(stderr, "FAIL: SSL_set_session\n");
 		goto failure;
 	}
-	SSL_SESSION_up_ref(ssl_session);
 
 	memcpy(ssl_session->master_key, et->master_key,
 	    sizeof(ssl_session->master_key));